From: Alex Elder <elder@linaro.org> To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: mka@chromium.org, evgreen@chromium.org, bjorn.andersson@linaro.org, quic_cpratapa@quicinc.com, quic_avuyyuru@quicinc.com, quic_jponduru@quicinc.com, quic_subashab@quicinc.com, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net 1/2] net: ipa: fix page free in ipa_endpoint_trans_release() Date: Sat, 21 May 2022 19:59:58 -0500 [thread overview] Message-ID: <20220522005959.1175181-2-elder@linaro.org> (raw) In-Reply-To: <20220522005959.1175181-1-elder@linaro.org> Currently the (possibly compound) page used for receive buffers are freed using __free_pages(). But according to this comment above the definition of that function, that's wrong: If you want to use the page's reference count to decide when to free the allocation, you should allocate a compound page, and use put_page() instead of __free_pages(). Convert the call to __free_pages() in ipa_endpoint_trans_release() to use put_page() instead. Fixes: ed23f02680caa ("net: ipa: define per-endpoint receive buffer size") Signed-off-by: Alex Elder <elder@linaro.org> --- drivers/net/ipa/ipa_endpoint.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 0f489723689c5..675b7135644b8 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -1385,11 +1385,8 @@ void ipa_endpoint_trans_release(struct ipa_endpoint *endpoint, } else { struct page *page = trans->data; - if (page) { - u32 buffer_size = endpoint->config.rx.buffer_size; - - __free_pages(page, get_order(buffer_size)); - } + if (page) + put_page(page); } } -- 2.32.0
next prev parent reply other threads:[~2022-05-22 1:00 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-22 0:59 [PATCH net 0/2] net: ipa: fix page free in two spots Alex Elder 2022-05-22 0:59 ` Alex Elder [this message] 2022-05-22 0:59 ` [PATCH net 2/2] net: ipa: fix page free in ipa_endpoint_replenish_one() Alex Elder 2022-05-22 12:46 ` [PATCH net 0/2] net: ipa: fix page free in two spots Alex Elder 2022-05-22 20:00 ` David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220522005959.1175181-2-elder@linaro.org \ --to=elder@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=elder@kernel.org \ --cc=evgreen@chromium.org \ --cc=kuba@kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mka@chromium.org \ --cc=netdev@vger.kernel.org \ --cc=pabeni@redhat.com \ --cc=quic_avuyyuru@quicinc.com \ --cc=quic_cpratapa@quicinc.com \ --cc=quic_jponduru@quicinc.com \ --cc=quic_subashab@quicinc.com \ --subject='Re: [PATCH net 1/2] net: ipa: fix page free in ipa_endpoint_trans_release()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.