From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD9FC433EF for ; Sun, 22 May 2022 15:25:03 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54BC440156; Sun, 22 May 2022 17:25:02 +0200 (CEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id AEC5440040 for ; Sun, 22 May 2022 17:25:01 +0200 (CEST) Received: by mail-pl1-f177.google.com with SMTP id s14so11075151plk.8 for ; Sun, 22 May 2022 08:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3KTi2S5FFxXWXicrZwbS9al7aJ++RtVwPt4JhdVjJtA=; b=ANzLZ+mXETzAqRfKLJFQRmXpvLVAJSfnccCjQQjSL8IDpgA/KGoQ1r0SK8e7ZMh623 afII9OCub+fxbWsbKk0vWjVBFBw6oIO83r8ZR2sl8hXhPZ9pdX9Rrn/ZV0COajNjIwPC 4qnFM4mUGhe2gIG8KeWxiUzta6wjmkL/dzfF+F4iCwIHH6o0ngxenhV8aBPivonm3R8e tBRy9iOVUWZuCsHq5GID1CyABo6mZXWOteV8BJMbyVC6nR0KwnUgQmRZViu0LQvYa6/9 QhLWk1m0ZPmaawjB/5laqTjY17N/XY8yYexDRLZPCuDEYe+18lAPLBgHOp4S0Ten/aFp /2yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3KTi2S5FFxXWXicrZwbS9al7aJ++RtVwPt4JhdVjJtA=; b=Z+FG9ojD4pLRc8W1xPLJSJAxCGEf3US6LQ4XiQfZCO3uG7ac/JNWljeLsYIUazG3s2 0skuniJy7Wm8U9tsmhwgRwVW6U+QNt9tsK0yDgcOyDvzttOF8J1IDAlwU6O4BfBAUGt8 AgGpQCN9UFxu6OkGxJQuONQ29wrn950Kfu3TQlA52hgpTEWFaG+tmsS6niylqZXTrRr3 9DRuOrO740sjIttaT5TKnlIjwpaIEKv4ALMaXSA/9bKO7h2ZNHbDpsy+F1j9DQmDVQUm JlFWt3+DLMjOGXQtvbUVYD0K0WPj7QmrS9I98VJSo7hf47gplMP17niYKTr3+p02sVtK laeQ== X-Gm-Message-State: AOAM530Tyqv5Nye2o/DRHEvEesB75iR4K+i5Q1FmpyAQW/+2YpDNTrDt 5+S0LJjSuo+ysT/5R+E4djVa4Q== X-Google-Smtp-Source: ABdhPJw9u+Ph/VbUtF7Tp0jIbVQTRWafeUGqmpB0y5bcWBFpGaFTnFDQCivwXfkz6nf96tPB6VRrcQ== X-Received: by 2002:a17:902:ee8d:b0:161:5c5c:d0e6 with SMTP id a13-20020a170902ee8d00b001615c5cd0e6mr19651050pld.32.1653233100931; Sun, 22 May 2022 08:25:00 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id d5-20020a170902f14500b00161a89c87d8sm3248948plb.252.2022.05.22.08.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 May 2022 08:25:00 -0700 (PDT) Date: Sun, 22 May 2022 08:24:57 -0700 From: Stephen Hemminger To: Spike Du Cc: , , , , , Subject: Re: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark Message-ID: <20220522082458.621e878d@hermes.local> In-Reply-To: <20220522055900.417282-4-spiked@nvidia.com> References: <20220506035645.4101714-1-spiked@nvidia.com> <20220522055900.417282-1-spiked@nvidia.com> <20220522055900.417282-4-spiked@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 22 May 2022 08:58:56 +0300 Spike Du wrote: > LWM(limit watermark) describes the fullness of a Rx queue. If the Rx > queue fullness is above LWM, the device will trigger the event > RTE_ETH_EVENT_RX_LWM. > LWM is defined as a percentage of Rx queue size with valid value of > [0,99]. > Setting LWM to 0 means disable it, which is the default. > When translate the percentage to queue descriptor number, the numbe > should be bigger than 0 and less than queue size. > Add LWM's configuration and query driver callbacks in eth_dev_ops. > > Signed-off-by: Spike Du One other objection, please don't invent yet another event channel for this. It should be part of existing Rx interrupt logic.