From: kernel test robot <lkp@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net] ice: Fix switchdev rules book keeping
Date: Sun, 22 May 2022 09:29:15 +0800 [thread overview]
Message-ID: <202205220932.IobcFqRE-lkp@intel.com> (raw)
In-Reply-To: <20220520084527.123885-1-wojciech.drewek@intel.com>
Hi Wojciech,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net/master]
url: https://github.com/intel-lab-lkp/linux/commits/Wojciech-Drewek/ice-Fix-switchdev-rules-book-keeping/20220520-164759
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 9b80ccda233fa6c59de411bf889cc4d0e028f2c7
config: i386-debian-10.3-kselftests (https://download.01.org/0day-ci/archive/20220522/202205220932.IobcFqRE-lkp at intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/e04c52f89a78dfae78ac79a71f0c92df8c409146
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Wojciech-Drewek/ice-Fix-switchdev-rules-book-keeping/20220520-164759
git checkout e04c52f89a78dfae78ac79a71f0c92df8c409146
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/i915/ drivers/net/ethernet/intel/ice/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/net/ethernet/intel/ice/ice_tc_lib.c: In function 'ice_eswitch_add_tc_fltr':
>> drivers/net/ethernet/intel/ice/ice_tc_lib.c:527:13: error: 'struct ice_tc_flower_fltr' has no member named 'dest_vsi_handle'
527 | fltr->dest_vsi_handle = rule_added.vsi_handle;
| ^~
vim +527 drivers/net/ethernet/intel/ice/ice_tc_lib.c
452
453 static int
454 ice_eswitch_add_tc_fltr(struct ice_vsi *vsi, struct ice_tc_flower_fltr *fltr)
455 {
456 struct ice_tc_flower_lyr_2_4_hdrs *headers = &fltr->outer_headers;
457 struct ice_adv_rule_info rule_info = { 0 };
458 struct ice_rule_query_data rule_added;
459 struct ice_hw *hw = &vsi->back->hw;
460 struct ice_adv_lkup_elem *list;
461 u32 flags = fltr->flags;
462 int lkups_cnt;
463 int ret;
464 int i;
465
466 if (!flags || (flags & ICE_TC_FLWR_FIELD_ENC_SRC_L4_PORT)) {
467 NL_SET_ERR_MSG_MOD(fltr->extack, "Unsupported encap field(s)");
468 return -EOPNOTSUPP;
469 }
470
471 lkups_cnt = ice_tc_count_lkups(flags, headers, fltr);
472 list = kcalloc(lkups_cnt, sizeof(*list), GFP_ATOMIC);
473 if (!list)
474 return -ENOMEM;
475
476 i = ice_tc_fill_rules(hw, flags, fltr, list, &rule_info, NULL);
477 if (i != lkups_cnt) {
478 ret = -EINVAL;
479 goto exit;
480 }
481
482 /* egress traffic is always redirect to uplink */
483 if (fltr->direction == ICE_ESWITCH_FLTR_EGRESS)
484 fltr->dest_vsi = vsi->back->switchdev.uplink_vsi;
485
486 rule_info.sw_act.fltr_act = fltr->action.fltr_act;
487 if (fltr->action.fltr_act != ICE_DROP_PACKET)
488 rule_info.sw_act.vsi_handle = fltr->dest_vsi->idx;
489 /* For now, making priority to be highest, and it also becomes
490 * the priority for recipe which will get created as a result of
491 * new extraction sequence based on input set.
492 * Priority '7' is max val for switch recipe, higher the number
493 * results into order of switch rule evaluation.
494 */
495 rule_info.priority = 7;
496
497 if (fltr->direction == ICE_ESWITCH_FLTR_INGRESS) {
498 rule_info.sw_act.flag |= ICE_FLTR_RX;
499 rule_info.sw_act.src = hw->pf_id;
500 rule_info.rx = true;
501 } else {
502 rule_info.sw_act.flag |= ICE_FLTR_TX;
503 rule_info.sw_act.src = vsi->idx;
504 rule_info.rx = false;
505 rule_info.flags_info.act = ICE_SINGLE_ACT_LAN_ENABLE;
506 rule_info.flags_info.act_valid = true;
507 }
508
509 /* specify the cookie as filter_rule_id */
510 rule_info.fltr_rule_id = fltr->cookie;
511
512 ret = ice_add_adv_rule(hw, list, lkups_cnt, &rule_info, &rule_added);
513 if (ret == -EEXIST) {
514 NL_SET_ERR_MSG_MOD(fltr->extack, "Unable to add filter because it already exist");
515 ret = -EINVAL;
516 goto exit;
517 } else if (ret) {
518 NL_SET_ERR_MSG_MOD(fltr->extack, "Unable to add filter due to error");
519 goto exit;
520 }
521
522 /* store the output params, which are needed later for removing
523 * advanced switch filter
524 */
525 fltr->rid = rule_added.rid;
526 fltr->rule_id = rule_added.rule_id;
> 527 fltr->dest_vsi_handle = rule_added.vsi_handle;
528
529 exit:
530 kfree(list);
531 return ret;
532 }
533
--
0-DAY CI Kernel Test Service
https://01.org/lkp
prev parent reply other threads:[~2022-05-22 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 8:45 [Intel-wired-lan] [PATCH net] ice: Fix switchdev rules book keeping Wojciech Drewek
2022-05-20 20:54 ` Tony Nguyen
2022-05-21 10:14 ` kernel test robot
2022-05-21 10:14 ` kernel test robot
2022-05-22 1:29 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205220932.IobcFqRE-lkp@intel.com \
--to=lkp@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.