* [PATCH -next] zram: fix Kconfig dependency warning
@ 2022-05-22 20:40 Randy Dunlap
2022-05-23 13:45 ` Johannes Weiner
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2022-05-22 20:40 UTC (permalink / raw)
To: linux-mm
Cc: patches, Randy Dunlap, Johannes Weiner, Minchan Kim, Nitin Gupta,
Sergey Senozhatsky, Jens Axboe, linux-block, Andrew Morton
ZSMALLOC depends on MMU so ZRAM should also depend on MMU
since 'select' does not follow any dependency chains.
Fixes this Kconfig warning:
WARNING: unmet direct dependencies detected for ZSMALLOC
Depends on [n]: MMU [=n]
Selected by [y]:
- ZRAM [=y] && BLK_DEV [=y] && BLOCK [=y] && SYSFS [=y] && (CRYPTO_LZO [=y] || CRYPTO_ZSTD [=m] || CRYPTO_LZ4 [=m] || CRYPTO_LZ4HC [=n] || CRYPTO_842 [=n])
Fixes: b3fbd58fcbb10 ("mm: Kconfig: simplify zswap configuration")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Nitin Gupta <ngupta@vflare.org>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>
---
drivers/block/zram/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/block/zram/Kconfig
+++ b/drivers/block/zram/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
config ZRAM
tristate "Compressed RAM block device support"
- depends on BLOCK && SYSFS
+ depends on BLOCK && SYSFS && MMU
depends on CRYPTO_LZO || CRYPTO_ZSTD || CRYPTO_LZ4 || CRYPTO_LZ4HC || CRYPTO_842
select ZSMALLOC
help
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] zram: fix Kconfig dependency warning
2022-05-22 20:40 [PATCH -next] zram: fix Kconfig dependency warning Randy Dunlap
@ 2022-05-23 13:45 ` Johannes Weiner
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Weiner @ 2022-05-23 13:45 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-mm, patches, Minchan Kim, Nitin Gupta, Sergey Senozhatsky,
Jens Axboe, linux-block, Andrew Morton
On Sun, May 22, 2022 at 01:40:27PM -0700, Randy Dunlap wrote:
> ZSMALLOC depends on MMU so ZRAM should also depend on MMU
> since 'select' does not follow any dependency chains.
>
> Fixes this Kconfig warning:
>
> WARNING: unmet direct dependencies detected for ZSMALLOC
> Depends on [n]: MMU [=n]
> Selected by [y]:
> - ZRAM [=y] && BLK_DEV [=y] && BLOCK [=y] && SYSFS [=y] && (CRYPTO_LZO [=y] || CRYPTO_ZSTD [=m] || CRYPTO_LZ4 [=m] || CRYPTO_LZ4HC [=n] || CRYPTO_842 [=n])
>
> Fixes: b3fbd58fcbb10 ("mm: Kconfig: simplify zswap configuration")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Minchan Kim <minchan@kernel.org>
> Cc: Nitin Gupta <ngupta@vflare.org>
> Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-block@vger.kernel.org
> Cc: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Thanks Randy!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-23 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-22 20:40 [PATCH -next] zram: fix Kconfig dependency warning Randy Dunlap
2022-05-23 13:45 ` Johannes Weiner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.