All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
@ 2022-05-23  6:06 gaochao
  2022-05-24  2:45   ` gaochao
  0 siblings, 1 reply; 11+ messages in thread
From: gaochao @ 2022-05-23  6:06 UTC (permalink / raw)
  To: alexs, corbet
  Cc: siyanteng01, bobwxc, src.res, wanjiabing, linux-doc,
	linux-kernel, zhengbin13

If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
bulding fails:

drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
 `drm_panel_dp_aux_backlight'
make: *** [vmlinux] Error 1

Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
CONFIG_DRM_DISPLAY_HELPER to fix this error.

Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: gaochao <gaochao49@huawei.com>
---
 drivers/gpu/drm/panel/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 38799effd00a..4f1f004b3c54 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -438,6 +438,8 @@ config DRM_PANEL_SAMSUNG_ATNA33XC20
 	depends on OF
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on PM
+	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_HELPER
 	select DRM_DP_AUX_BUS
 	help
 	  DRM panel driver for the Samsung ATNA33XC20 panel. This panel can't
--
2.17.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2 -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
  2022-05-23  6:06 [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m gaochao
@ 2022-05-24  2:45   ` gaochao
  0 siblings, 0 replies; 11+ messages in thread
From: gaochao @ 2022-05-24  2:45 UTC (permalink / raw)
  To: thierry.reding, sam, airlied, daniel, dianders
  Cc: seanpaul, zhengbin13, dri-devel, linux-kernel

From: Gao Chao <gaochao49@huawei.com>

If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
bulding fails:

drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
 `drm_panel_dp_aux_backlight'
make: *** [vmlinux] Error 1

Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
CONFIG_DRM_DISPLAY_HELPER to fix this error.

Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Gao Chao <gaochao49@huawei.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
v1->v2: fix Signed-off-by name
---
 drivers/gpu/drm/panel/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 38799effd00a..4f1f004b3c54 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -438,6 +438,8 @@ config DRM_PANEL_SAMSUNG_ATNA33XC20
 	depends on OF
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on PM
+	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_HELPER
 	select DRM_DP_AUX_BUS
 	help
 	  DRM panel driver for the Samsung ATNA33XC20 panel. This panel can't
--
2.17.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH v2 -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
@ 2022-05-24  2:45   ` gaochao
  0 siblings, 0 replies; 11+ messages in thread
From: gaochao @ 2022-05-24  2:45 UTC (permalink / raw)
  To: thierry.reding, sam, airlied, daniel, dianders
  Cc: zhengbin13, seanpaul, linux-kernel, dri-devel

From: Gao Chao <gaochao49@huawei.com>

If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
bulding fails:

drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
 `drm_panel_dp_aux_backlight'
make: *** [vmlinux] Error 1

Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
CONFIG_DRM_DISPLAY_HELPER to fix this error.

Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Gao Chao <gaochao49@huawei.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
v1->v2: fix Signed-off-by name
---
 drivers/gpu/drm/panel/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 38799effd00a..4f1f004b3c54 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -438,6 +438,8 @@ config DRM_PANEL_SAMSUNG_ATNA33XC20
 	depends on OF
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on PM
+	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_HELPER
 	select DRM_DP_AUX_BUS
 	help
 	  DRM panel driver for the Samsung ATNA33XC20 panel. This panel can't
--
2.17.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
  2022-05-24  2:45   ` gaochao
@ 2022-05-24 19:34     ` Doug Anderson
  -1 siblings, 0 replies; 11+ messages in thread
From: Doug Anderson @ 2022-05-24 19:34 UTC (permalink / raw)
  To: gaochao
  Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
	zhengbin13, Sean Paul, LKML, dri-devel

Hi,

On Mon, May 23, 2022 at 7:46 PM gaochao <gaochao49@huawei.com> wrote:
>
> From: Gao Chao <gaochao49@huawei.com>
>
> If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
> bulding fails:
>
> drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
> panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
>  `drm_panel_dp_aux_backlight'
> make: *** [vmlinux] Error 1
>
> Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
> CONFIG_DRM_DISPLAY_HELPER to fix this error.
>
> Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Gao Chao <gaochao49@huawei.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
> v1->v2: fix Signed-off-by name
> ---
>  drivers/gpu/drm/panel/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

The patch this is "fixing" is in mainline so theoretically this should
land in drm-misc-fixes, but it gets messy because it would need to be
adapted because commit 1e0f66420b13 ("drm/display: Introduce a DRM
display-helper module") isn't in mainline. Since this doesn't feel
urgent, I'm landing this in drm-misc/drm-misc-next.

a67664860f78 drm/panel: Fix build error when
CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m

-Doug

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH v2 -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
@ 2022-05-24 19:34     ` Doug Anderson
  0 siblings, 0 replies; 11+ messages in thread
From: Doug Anderson @ 2022-05-24 19:34 UTC (permalink / raw)
  To: gaochao
  Cc: David Airlie, LKML, dri-devel, zhengbin13, Thierry Reding,
	Sean Paul, Sam Ravnborg

Hi,

On Mon, May 23, 2022 at 7:46 PM gaochao <gaochao49@huawei.com> wrote:
>
> From: Gao Chao <gaochao49@huawei.com>
>
> If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
> bulding fails:
>
> drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
> panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
>  `drm_panel_dp_aux_backlight'
> make: *** [vmlinux] Error 1
>
> Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
> CONFIG_DRM_DISPLAY_HELPER to fix this error.
>
> Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Gao Chao <gaochao49@huawei.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
> v1->v2: fix Signed-off-by name
> ---
>  drivers/gpu/drm/panel/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

The patch this is "fixing" is in mainline so theoretically this should
land in drm-misc-fixes, but it gets messy because it would need to be
adapted because commit 1e0f66420b13 ("drm/display: Introduce a DRM
display-helper module") isn't in mainline. Since this doesn't feel
urgent, I'm landing this in drm-misc/drm-misc-next.

a67664860f78 drm/panel: Fix build error when
CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m

-Doug

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
  2022-05-23 16:47   ` Doug Anderson
@ 2022-05-24  2:27     ` gaochao (L)
  -1 siblings, 0 replies; 11+ messages in thread
From: gaochao (L) @ 2022-05-24  2:27 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
	Sean Paul, zhengbin13, dri-devel, LKML



在 2022/5/24 0:47, Doug Anderson 写道:
> Hi,
> 
> On Mon, May 23, 2022 at 1:58 AM gaochao <gaochao49@huawei.com> wrote:
>>
>> If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
>> bulding fails:
>>
>> drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
>> panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
>>  `drm_panel_dp_aux_backlight'
>> make: *** [vmlinux] Error 1
>>
>> Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
>> CONFIG_DRM_DISPLAY_HELPER to fix this error.
>>
>> Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: gaochao <gaochao49@huawei.com>
> 
> I think the author / Signed-off-by are supposed to be real names. Is
> "gaochao" your legal name?
Thank you for the review.
Should be "Gao Chao", fixing in the second version.
> 
>> ---
>>  drivers/gpu/drm/panel/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Other than the Signed-off-by / Author issue:
> 
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> .

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
@ 2022-05-24  2:27     ` gaochao (L)
  0 siblings, 0 replies; 11+ messages in thread
From: gaochao (L) @ 2022-05-24  2:27 UTC (permalink / raw)
  To: Doug Anderson
  Cc: David Airlie, LKML, dri-devel, zhengbin13, Thierry Reding,
	Sean Paul, Sam Ravnborg



在 2022/5/24 0:47, Doug Anderson 写道:
> Hi,
> 
> On Mon, May 23, 2022 at 1:58 AM gaochao <gaochao49@huawei.com> wrote:
>>
>> If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
>> bulding fails:
>>
>> drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
>> panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
>>  `drm_panel_dp_aux_backlight'
>> make: *** [vmlinux] Error 1
>>
>> Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
>> CONFIG_DRM_DISPLAY_HELPER to fix this error.
>>
>> Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: gaochao <gaochao49@huawei.com>
> 
> I think the author / Signed-off-by are supposed to be real names. Is
> "gaochao" your legal name?
Thank you for the review.
Should be "Gao Chao", fixing in the second version.
> 
>> ---
>>  drivers/gpu/drm/panel/Kconfig | 2 ++
>>  1 file changed, 2 insertions(+)
> 
> Other than the Signed-off-by / Author issue:
> 
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> .

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
  2022-05-23  8:57 ` gaochao
@ 2022-05-23 16:47   ` Doug Anderson
  -1 siblings, 0 replies; 11+ messages in thread
From: Doug Anderson @ 2022-05-23 16:47 UTC (permalink / raw)
  To: gaochao
  Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
	Sean Paul, zhengbin13, dri-devel, LKML

Hi,

On Mon, May 23, 2022 at 1:58 AM gaochao <gaochao49@huawei.com> wrote:
>
> If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
> bulding fails:
>
> drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
> panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
>  `drm_panel_dp_aux_backlight'
> make: *** [vmlinux] Error 1
>
> Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
> CONFIG_DRM_DISPLAY_HELPER to fix this error.
>
> Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: gaochao <gaochao49@huawei.com>

I think the author / Signed-off-by are supposed to be real names. Is
"gaochao" your legal name?

> ---
>  drivers/gpu/drm/panel/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

Other than the Signed-off-by / Author issue:

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
@ 2022-05-23 16:47   ` Doug Anderson
  0 siblings, 0 replies; 11+ messages in thread
From: Doug Anderson @ 2022-05-23 16:47 UTC (permalink / raw)
  To: gaochao
  Cc: David Airlie, LKML, dri-devel, zhengbin13, Thierry Reding,
	Sean Paul, Sam Ravnborg

Hi,

On Mon, May 23, 2022 at 1:58 AM gaochao <gaochao49@huawei.com> wrote:
>
> If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
> bulding fails:
>
> drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
> panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
>  `drm_panel_dp_aux_backlight'
> make: *** [vmlinux] Error 1
>
> Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
> CONFIG_DRM_DISPLAY_HELPER to fix this error.
>
> Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: gaochao <gaochao49@huawei.com>

I think the author / Signed-off-by are supposed to be real names. Is
"gaochao" your legal name?

> ---
>  drivers/gpu/drm/panel/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)

Other than the Signed-off-by / Author issue:

Reviewed-by: Douglas Anderson <dianders@chromium.org>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
@ 2022-05-23  8:57 ` gaochao
  0 siblings, 0 replies; 11+ messages in thread
From: gaochao @ 2022-05-23  8:57 UTC (permalink / raw)
  To: thierry.reding, sam, airlied, daniel
  Cc: dianders, seanpaul, zhengbin13, dri-devel, linux-kernel

If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
bulding fails:

drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
 `drm_panel_dp_aux_backlight'
make: *** [vmlinux] Error 1

Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
CONFIG_DRM_DISPLAY_HELPER to fix this error.

Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: gaochao <gaochao49@huawei.com>
---
 drivers/gpu/drm/panel/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 38799effd00a..4f1f004b3c54 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -438,6 +438,8 @@ config DRM_PANEL_SAMSUNG_ATNA33XC20
 	depends on OF
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on PM
+	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_HELPER
 	select DRM_DP_AUX_BUS
 	help
 	  DRM panel driver for the Samsung ATNA33XC20 panel. This panel can't
--
2.17.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m
@ 2022-05-23  8:57 ` gaochao
  0 siblings, 0 replies; 11+ messages in thread
From: gaochao @ 2022-05-23  8:57 UTC (permalink / raw)
  To: thierry.reding, sam, airlied, daniel
  Cc: zhengbin13, seanpaul, dianders, dri-devel, linux-kernel

If CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m,
bulding fails:

drivers/gpu/drm/panel/panel-samsung-atna33xc20.o: In function `atana33xc20_probe':
panel-samsung-atna33xc20.c:(.text+0x744): undefined reference to
 `drm_panel_dp_aux_backlight'
make: *** [vmlinux] Error 1

Let CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20 select DRM_DISPLAY_DP_HELPER and
CONFIG_DRM_DISPLAY_HELPER to fix this error.

Fixes: 32ce3b320343 ("drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: gaochao <gaochao49@huawei.com>
---
 drivers/gpu/drm/panel/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 38799effd00a..4f1f004b3c54 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -438,6 +438,8 @@ config DRM_PANEL_SAMSUNG_ATNA33XC20
 	depends on OF
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on PM
+	select DRM_DISPLAY_DP_HELPER
+	select DRM_DISPLAY_HELPER
 	select DRM_DP_AUX_BUS
 	help
 	  DRM panel driver for the Samsung ATNA33XC20 panel. This panel can't
--
2.17.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2022-05-24 19:35 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-23  6:06 [PATCH -next] drm/panel: Fix build error when CONFIG_DRM_PANEL_SAMSUNG_ATNA33XC20=y && CONFIG_DRM_DISPLAY_HELPER=m gaochao
2022-05-24  2:45 ` [PATCH v2 " gaochao
2022-05-24  2:45   ` gaochao
2022-05-24 19:34   ` Doug Anderson
2022-05-24 19:34     ` Doug Anderson
2022-05-23  8:57 [PATCH " gaochao
2022-05-23  8:57 ` gaochao
2022-05-23 16:47 ` Doug Anderson
2022-05-23 16:47   ` Doug Anderson
2022-05-24  2:27   ` gaochao (L)
2022-05-24  2:27     ` gaochao (L)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.