All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")
@ 2022-05-23 10:23 ` matthias.bgg
  0 siblings, 0 replies; 21+ messages in thread
From: matthias.bgg @ 2022-05-23 10:23 UTC (permalink / raw)
  To: mturquette, sboyd
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger, Krzysztof Kozlowski, devicetree

From: Matthias Brugger <matthias.bgg@gmail.com>


The mt8192-msdc clock is only a single clock gate. This gate is accessed
from the mmc driver directly. With
4a1d1379ebf6 ("arm64: dts: mt8192: Add mmc device nodes")
the only consumer of this binding was deleted. Delete the binding
decription and the clock driver bound to it.

Changes in v3:
- Update commit message to explain better why we do ABI breakage here
- add Reviewed-by tag

Changes in v2:
- Delete compatible in binding descprition as well
- Add RvB tags
- add Reviewed-by tag

Matthias Brugger (2):
  dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
  clk: mediatek: Delete MT8192 msdc gate

 .../arm/mediatek/mediatek,mt8192-clock.yaml   |  8 -------
 drivers/clk/mediatek/clk-mt8192-msdc.c        | 21 -------------------
 2 files changed, 29 deletions(-)

-- 
2.36.0


^ permalink raw reply	[flat|nested] 21+ messages in thread

* [PATCH v3 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")
@ 2022-05-23 10:23 ` matthias.bgg
  0 siblings, 0 replies; 21+ messages in thread
From: matthias.bgg @ 2022-05-23 10:23 UTC (permalink / raw)
  To: mturquette, sboyd
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger, Krzysztof Kozlowski, devicetree

From: Matthias Brugger <matthias.bgg@gmail.com>


The mt8192-msdc clock is only a single clock gate. This gate is accessed
from the mmc driver directly. With
4a1d1379ebf6 ("arm64: dts: mt8192: Add mmc device nodes")
the only consumer of this binding was deleted. Delete the binding
decription and the clock driver bound to it.

Changes in v3:
- Update commit message to explain better why we do ABI breakage here
- add Reviewed-by tag

Changes in v2:
- Delete compatible in binding descprition as well
- Add RvB tags
- add Reviewed-by tag

Matthias Brugger (2):
  dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
  clk: mediatek: Delete MT8192 msdc gate

 .../arm/mediatek/mediatek,mt8192-clock.yaml   |  8 -------
 drivers/clk/mediatek/clk-mt8192-msdc.c        | 21 -------------------
 2 files changed, 29 deletions(-)

-- 
2.36.0


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 21+ messages in thread

* [PATCH v3 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")
@ 2022-05-23 10:23 ` matthias.bgg
  0 siblings, 0 replies; 21+ messages in thread
From: matthias.bgg @ 2022-05-23 10:23 UTC (permalink / raw)
  To: mturquette, sboyd
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger, Krzysztof Kozlowski, devicetree

From: Matthias Brugger <matthias.bgg@gmail.com>


The mt8192-msdc clock is only a single clock gate. This gate is accessed
from the mmc driver directly. With
4a1d1379ebf6 ("arm64: dts: mt8192: Add mmc device nodes")
the only consumer of this binding was deleted. Delete the binding
decription and the clock driver bound to it.

Changes in v3:
- Update commit message to explain better why we do ABI breakage here
- add Reviewed-by tag

Changes in v2:
- Delete compatible in binding descprition as well
- Add RvB tags
- add Reviewed-by tag

Matthias Brugger (2):
  dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
  clk: mediatek: Delete MT8192 msdc gate

 .../arm/mediatek/mediatek,mt8192-clock.yaml   |  8 -------
 drivers/clk/mediatek/clk-mt8192-msdc.c        | 21 -------------------
 2 files changed, 29 deletions(-)

-- 
2.36.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread

* [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
  2022-05-23 10:23 ` matthias.bgg
  (?)
@ 2022-05-23 10:23   ` matthias.bgg
  -1 siblings, 0 replies; 21+ messages in thread
From: matthias.bgg @ 2022-05-23 10:23 UTC (permalink / raw)
  To: mturquette, sboyd
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger, Krzysztof Kozlowski, devicetree

From: Matthias Brugger <matthias.bgg@gmail.com>

The code controlling msdc clock gate was moved inthe the consumer, the MMC
driver. This node did never represent a working implementation of any
peripheral. It was just a lonely clock gate that wasn't used. Delete the
binding description of this node.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>

---

Changes in v3:
- Update commit message to explain better why we do ABI breakage here

Changes in v2:
- Delete compatible in binding descprition as well
- Add RvB tags

 .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index c8c67c033f8c..b57cc2e69efb 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -24,7 +24,6 @@ properties:
           - mediatek,mt8192-imp_iic_wrap_w
           - mediatek,mt8192-imp_iic_wrap_n
           - mediatek,mt8192-msdc_top
-          - mediatek,mt8192-msdc
           - mediatek,mt8192-mfgcfg
           - mediatek,mt8192-imgsys
           - mediatek,mt8192-imgsys2
@@ -107,13 +106,6 @@ examples:
         #clock-cells = <1>;
     };
 
-  - |
-    msdc: clock-controller@11f60000 {
-        compatible = "mediatek,mt8192-msdc";
-        reg = <0x11f60000 0x1000>;
-        #clock-cells = <1>;
-    };
-
   - |
     mfgcfg: clock-controller@13fbf000 {
         compatible = "mediatek,mt8192-mfgcfg";
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 21+ messages in thread

* [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-05-23 10:23   ` matthias.bgg
  0 siblings, 0 replies; 21+ messages in thread
From: matthias.bgg @ 2022-05-23 10:23 UTC (permalink / raw)
  To: mturquette, sboyd
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger, Krzysztof Kozlowski, devicetree

From: Matthias Brugger <matthias.bgg@gmail.com>

The code controlling msdc clock gate was moved inthe the consumer, the MMC
driver. This node did never represent a working implementation of any
peripheral. It was just a lonely clock gate that wasn't used. Delete the
binding description of this node.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>

---

Changes in v3:
- Update commit message to explain better why we do ABI breakage here

Changes in v2:
- Delete compatible in binding descprition as well
- Add RvB tags

 .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index c8c67c033f8c..b57cc2e69efb 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -24,7 +24,6 @@ properties:
           - mediatek,mt8192-imp_iic_wrap_w
           - mediatek,mt8192-imp_iic_wrap_n
           - mediatek,mt8192-msdc_top
-          - mediatek,mt8192-msdc
           - mediatek,mt8192-mfgcfg
           - mediatek,mt8192-imgsys
           - mediatek,mt8192-imgsys2
@@ -107,13 +106,6 @@ examples:
         #clock-cells = <1>;
     };
 
-  - |
-    msdc: clock-controller@11f60000 {
-        compatible = "mediatek,mt8192-msdc";
-        reg = <0x11f60000 0x1000>;
-        #clock-cells = <1>;
-    };
-
   - |
     mfgcfg: clock-controller@13fbf000 {
         compatible = "mediatek,mt8192-mfgcfg";
-- 
2.36.0


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 21+ messages in thread

* [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-05-23 10:23   ` matthias.bgg
  0 siblings, 0 replies; 21+ messages in thread
From: matthias.bgg @ 2022-05-23 10:23 UTC (permalink / raw)
  To: mturquette, sboyd
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger, Krzysztof Kozlowski, devicetree

From: Matthias Brugger <matthias.bgg@gmail.com>

The code controlling msdc clock gate was moved inthe the consumer, the MMC
driver. This node did never represent a working implementation of any
peripheral. It was just a lonely clock gate that wasn't used. Delete the
binding description of this node.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>

---

Changes in v3:
- Update commit message to explain better why we do ABI breakage here

Changes in v2:
- Delete compatible in binding descprition as well
- Add RvB tags

 .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
index c8c67c033f8c..b57cc2e69efb 100644
--- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
@@ -24,7 +24,6 @@ properties:
           - mediatek,mt8192-imp_iic_wrap_w
           - mediatek,mt8192-imp_iic_wrap_n
           - mediatek,mt8192-msdc_top
-          - mediatek,mt8192-msdc
           - mediatek,mt8192-mfgcfg
           - mediatek,mt8192-imgsys
           - mediatek,mt8192-imgsys2
@@ -107,13 +106,6 @@ examples:
         #clock-cells = <1>;
     };
 
-  - |
-    msdc: clock-controller@11f60000 {
-        compatible = "mediatek,mt8192-msdc";
-        reg = <0x11f60000 0x1000>;
-        #clock-cells = <1>;
-    };
-
   - |
     mfgcfg: clock-controller@13fbf000 {
         compatible = "mediatek,mt8192-mfgcfg";
-- 
2.36.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 21+ messages in thread

* [PATCH v3 2/2] clk: mediatek: Delete MT8192 msdc gate
  2022-05-23 10:23 ` matthias.bgg
  (?)
@ 2022-05-23 10:23   ` matthias.bgg
  -1 siblings, 0 replies; 21+ messages in thread
From: matthias.bgg @ 2022-05-23 10:23 UTC (permalink / raw)
  To: mturquette, sboyd
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger

From: Matthias Brugger <matthias.bgg@gmail.com>

The msdc gate is part of the MMC driver. Delete the not used code.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>

---

Changes in v3:
- add Reviewed-by tag

Changes in v2:
- add Reviewed-by tag

 drivers/clk/mediatek/clk-mt8192-msdc.c | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/drivers/clk/mediatek/clk-mt8192-msdc.c b/drivers/clk/mediatek/clk-mt8192-msdc.c
index 87c3b79b79cf..635f7a0b629a 100644
--- a/drivers/clk/mediatek/clk-mt8192-msdc.c
+++ b/drivers/clk/mediatek/clk-mt8192-msdc.c
@@ -12,28 +12,15 @@
 
 #include <dt-bindings/clock/mt8192-clk.h>
 
-static const struct mtk_gate_regs msdc_cg_regs = {
-	.set_ofs = 0xb4,
-	.clr_ofs = 0xb4,
-	.sta_ofs = 0xb4,
-};
-
 static const struct mtk_gate_regs msdc_top_cg_regs = {
 	.set_ofs = 0x0,
 	.clr_ofs = 0x0,
 	.sta_ofs = 0x0,
 };
 
-#define GATE_MSDC(_id, _name, _parent, _shift)	\
-	GATE_MTK(_id, _name, _parent, &msdc_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv)
-
 #define GATE_MSDC_TOP(_id, _name, _parent, _shift)	\
 	GATE_MTK(_id, _name, _parent, &msdc_top_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv)
 
-static const struct mtk_gate msdc_clks[] = {
-	GATE_MSDC(CLK_MSDC_AXI_WRAP, "msdc_axi_wrap", "axi_sel", 22),
-};
-
 static const struct mtk_gate msdc_top_clks[] = {
 	GATE_MSDC_TOP(CLK_MSDC_TOP_AES_0P, "msdc_top_aes_0p", "aes_msdcfde_sel", 0),
 	GATE_MSDC_TOP(CLK_MSDC_TOP_SRC_0P, "msdc_top_src_0p", "infra_msdc0_src", 1),
@@ -52,11 +39,6 @@ static const struct mtk_gate msdc_top_clks[] = {
 	GATE_MSDC_TOP(CLK_MSDC_TOP_AHB2AXI_BRG_AXI, "msdc_top_ahb2axi_brg_axi", "axi_sel", 14),
 };
 
-static const struct mtk_clk_desc msdc_desc = {
-	.clks = msdc_clks,
-	.num_clks = ARRAY_SIZE(msdc_clks),
-};
-
 static const struct mtk_clk_desc msdc_top_desc = {
 	.clks = msdc_top_clks,
 	.num_clks = ARRAY_SIZE(msdc_top_clks),
@@ -64,9 +46,6 @@ static const struct mtk_clk_desc msdc_top_desc = {
 
 static const struct of_device_id of_match_clk_mt8192_msdc[] = {
 	{
-		.compatible = "mediatek,mt8192-msdc",
-		.data = &msdc_desc,
-	}, {
 		.compatible = "mediatek,mt8192-msdc_top",
 		.data = &msdc_top_desc,
 	}, {
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 21+ messages in thread

* [PATCH v3 2/2] clk: mediatek: Delete MT8192 msdc gate
@ 2022-05-23 10:23   ` matthias.bgg
  0 siblings, 0 replies; 21+ messages in thread
From: matthias.bgg @ 2022-05-23 10:23 UTC (permalink / raw)
  To: mturquette, sboyd
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger

From: Matthias Brugger <matthias.bgg@gmail.com>

The msdc gate is part of the MMC driver. Delete the not used code.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>

---

Changes in v3:
- add Reviewed-by tag

Changes in v2:
- add Reviewed-by tag

 drivers/clk/mediatek/clk-mt8192-msdc.c | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/drivers/clk/mediatek/clk-mt8192-msdc.c b/drivers/clk/mediatek/clk-mt8192-msdc.c
index 87c3b79b79cf..635f7a0b629a 100644
--- a/drivers/clk/mediatek/clk-mt8192-msdc.c
+++ b/drivers/clk/mediatek/clk-mt8192-msdc.c
@@ -12,28 +12,15 @@
 
 #include <dt-bindings/clock/mt8192-clk.h>
 
-static const struct mtk_gate_regs msdc_cg_regs = {
-	.set_ofs = 0xb4,
-	.clr_ofs = 0xb4,
-	.sta_ofs = 0xb4,
-};
-
 static const struct mtk_gate_regs msdc_top_cg_regs = {
 	.set_ofs = 0x0,
 	.clr_ofs = 0x0,
 	.sta_ofs = 0x0,
 };
 
-#define GATE_MSDC(_id, _name, _parent, _shift)	\
-	GATE_MTK(_id, _name, _parent, &msdc_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv)
-
 #define GATE_MSDC_TOP(_id, _name, _parent, _shift)	\
 	GATE_MTK(_id, _name, _parent, &msdc_top_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv)
 
-static const struct mtk_gate msdc_clks[] = {
-	GATE_MSDC(CLK_MSDC_AXI_WRAP, "msdc_axi_wrap", "axi_sel", 22),
-};
-
 static const struct mtk_gate msdc_top_clks[] = {
 	GATE_MSDC_TOP(CLK_MSDC_TOP_AES_0P, "msdc_top_aes_0p", "aes_msdcfde_sel", 0),
 	GATE_MSDC_TOP(CLK_MSDC_TOP_SRC_0P, "msdc_top_src_0p", "infra_msdc0_src", 1),
@@ -52,11 +39,6 @@ static const struct mtk_gate msdc_top_clks[] = {
 	GATE_MSDC_TOP(CLK_MSDC_TOP_AHB2AXI_BRG_AXI, "msdc_top_ahb2axi_brg_axi", "axi_sel", 14),
 };
 
-static const struct mtk_clk_desc msdc_desc = {
-	.clks = msdc_clks,
-	.num_clks = ARRAY_SIZE(msdc_clks),
-};
-
 static const struct mtk_clk_desc msdc_top_desc = {
 	.clks = msdc_top_clks,
 	.num_clks = ARRAY_SIZE(msdc_top_clks),
@@ -64,9 +46,6 @@ static const struct mtk_clk_desc msdc_top_desc = {
 
 static const struct of_device_id of_match_clk_mt8192_msdc[] = {
 	{
-		.compatible = "mediatek,mt8192-msdc",
-		.data = &msdc_desc,
-	}, {
 		.compatible = "mediatek,mt8192-msdc_top",
 		.data = &msdc_top_desc,
 	}, {
-- 
2.36.0


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 21+ messages in thread

* [PATCH v3 2/2] clk: mediatek: Delete MT8192 msdc gate
@ 2022-05-23 10:23   ` matthias.bgg
  0 siblings, 0 replies; 21+ messages in thread
From: matthias.bgg @ 2022-05-23 10:23 UTC (permalink / raw)
  To: mturquette, sboyd
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger

From: Matthias Brugger <matthias.bgg@gmail.com>

The msdc gate is part of the MMC driver. Delete the not used code.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Miles Chen <miles.chen@mediatek.com>

---

Changes in v3:
- add Reviewed-by tag

Changes in v2:
- add Reviewed-by tag

 drivers/clk/mediatek/clk-mt8192-msdc.c | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/drivers/clk/mediatek/clk-mt8192-msdc.c b/drivers/clk/mediatek/clk-mt8192-msdc.c
index 87c3b79b79cf..635f7a0b629a 100644
--- a/drivers/clk/mediatek/clk-mt8192-msdc.c
+++ b/drivers/clk/mediatek/clk-mt8192-msdc.c
@@ -12,28 +12,15 @@
 
 #include <dt-bindings/clock/mt8192-clk.h>
 
-static const struct mtk_gate_regs msdc_cg_regs = {
-	.set_ofs = 0xb4,
-	.clr_ofs = 0xb4,
-	.sta_ofs = 0xb4,
-};
-
 static const struct mtk_gate_regs msdc_top_cg_regs = {
 	.set_ofs = 0x0,
 	.clr_ofs = 0x0,
 	.sta_ofs = 0x0,
 };
 
-#define GATE_MSDC(_id, _name, _parent, _shift)	\
-	GATE_MTK(_id, _name, _parent, &msdc_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv)
-
 #define GATE_MSDC_TOP(_id, _name, _parent, _shift)	\
 	GATE_MTK(_id, _name, _parent, &msdc_top_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv)
 
-static const struct mtk_gate msdc_clks[] = {
-	GATE_MSDC(CLK_MSDC_AXI_WRAP, "msdc_axi_wrap", "axi_sel", 22),
-};
-
 static const struct mtk_gate msdc_top_clks[] = {
 	GATE_MSDC_TOP(CLK_MSDC_TOP_AES_0P, "msdc_top_aes_0p", "aes_msdcfde_sel", 0),
 	GATE_MSDC_TOP(CLK_MSDC_TOP_SRC_0P, "msdc_top_src_0p", "infra_msdc0_src", 1),
@@ -52,11 +39,6 @@ static const struct mtk_gate msdc_top_clks[] = {
 	GATE_MSDC_TOP(CLK_MSDC_TOP_AHB2AXI_BRG_AXI, "msdc_top_ahb2axi_brg_axi", "axi_sel", 14),
 };
 
-static const struct mtk_clk_desc msdc_desc = {
-	.clks = msdc_clks,
-	.num_clks = ARRAY_SIZE(msdc_clks),
-};
-
 static const struct mtk_clk_desc msdc_top_desc = {
 	.clks = msdc_top_clks,
 	.num_clks = ARRAY_SIZE(msdc_top_clks),
@@ -64,9 +46,6 @@ static const struct mtk_clk_desc msdc_top_desc = {
 
 static const struct of_device_id of_match_clk_mt8192_msdc[] = {
 	{
-		.compatible = "mediatek,mt8192-msdc",
-		.data = &msdc_desc,
-	}, {
 		.compatible = "mediatek,mt8192-msdc_top",
 		.data = &msdc_top_desc,
 	}, {
-- 
2.36.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")
  2022-05-23 10:23 ` matthias.bgg
  (?)
@ 2022-05-24  6:27   ` Chen-Yu Tsai
  -1 siblings, 0 replies; 21+ messages in thread
From: Chen-Yu Tsai @ 2022-05-24  6:27 UTC (permalink / raw)
  To: matthias.bgg
  Cc: mturquette, sboyd, allen-kh.cheng, weiyi.lu, chun-jie.chen,
	linux-kernel, ikjn, miles.chen, robh+dt, linux-mediatek,
	krzysztof.kozlowski+dt, linux-clk, linux-arm-kernel,
	angelogioacchino.delregno, Matthias Brugger, Krzysztof Kozlowski,
	devicetree

On Mon, May 23, 2022 at 7:19 PM <matthias.bgg@kernel.org> wrote:
>
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
>
> The mt8192-msdc clock is only a single clock gate. This gate is accessed
> from the mmc driver directly. With
> 4a1d1379ebf6 ("arm64: dts: mt8192: Add mmc device nodes")
> the only consumer of this binding was deleted. Delete the binding
> decription and the clock driver bound to it.
>
> Changes in v3:
> - Update commit message to explain better why we do ABI breakage here
> - add Reviewed-by tag
>
> Changes in v2:
> - Delete compatible in binding descprition as well
> - Add RvB tags
> - add Reviewed-by tag
>
> Matthias Brugger (2):
>   dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
>   clk: mediatek: Delete MT8192 msdc gate

Whole series is

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")
@ 2022-05-24  6:27   ` Chen-Yu Tsai
  0 siblings, 0 replies; 21+ messages in thread
From: Chen-Yu Tsai @ 2022-05-24  6:27 UTC (permalink / raw)
  To: matthias.bgg
  Cc: mturquette, sboyd, allen-kh.cheng, weiyi.lu, chun-jie.chen,
	linux-kernel, ikjn, miles.chen, robh+dt, linux-mediatek,
	krzysztof.kozlowski+dt, linux-clk, linux-arm-kernel,
	angelogioacchino.delregno, Matthias Brugger, Krzysztof Kozlowski,
	devicetree

On Mon, May 23, 2022 at 7:19 PM <matthias.bgg@kernel.org> wrote:
>
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
>
> The mt8192-msdc clock is only a single clock gate. This gate is accessed
> from the mmc driver directly. With
> 4a1d1379ebf6 ("arm64: dts: mt8192: Add mmc device nodes")
> the only consumer of this binding was deleted. Delete the binding
> decription and the clock driver bound to it.
>
> Changes in v3:
> - Update commit message to explain better why we do ABI breakage here
> - add Reviewed-by tag
>
> Changes in v2:
> - Delete compatible in binding descprition as well
> - Add RvB tags
> - add Reviewed-by tag
>
> Matthias Brugger (2):
>   dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
>   clk: mediatek: Delete MT8192 msdc gate

Whole series is

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")
@ 2022-05-24  6:27   ` Chen-Yu Tsai
  0 siblings, 0 replies; 21+ messages in thread
From: Chen-Yu Tsai @ 2022-05-24  6:27 UTC (permalink / raw)
  To: matthias.bgg
  Cc: mturquette, sboyd, allen-kh.cheng, weiyi.lu, chun-jie.chen,
	linux-kernel, ikjn, miles.chen, robh+dt, linux-mediatek,
	krzysztof.kozlowski+dt, linux-clk, linux-arm-kernel,
	angelogioacchino.delregno, Matthias Brugger, Krzysztof Kozlowski,
	devicetree

On Mon, May 23, 2022 at 7:19 PM <matthias.bgg@kernel.org> wrote:
>
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
>
> The mt8192-msdc clock is only a single clock gate. This gate is accessed
> from the mmc driver directly. With
> 4a1d1379ebf6 ("arm64: dts: mt8192: Add mmc device nodes")
> the only consumer of this binding was deleted. Delete the binding
> decription and the clock driver bound to it.
>
> Changes in v3:
> - Update commit message to explain better why we do ABI breakage here
> - add Reviewed-by tag
>
> Changes in v2:
> - Delete compatible in binding descprition as well
> - Add RvB tags
> - add Reviewed-by tag
>
> Matthias Brugger (2):
>   dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
>   clk: mediatek: Delete MT8192 msdc gate

Whole series is

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
  2022-05-23 10:23   ` matthias.bgg
  (?)
@ 2022-06-02 13:05     ` Rob Herring
  -1 siblings, 0 replies; 21+ messages in thread
From: Rob Herring @ 2022-06-02 13:05 UTC (permalink / raw)
  To: matthias.bgg
  Cc: mturquette, ikjn, krzysztof.kozlowski+dt, devicetree, weiyi.lu,
	Krzysztof Kozlowski, linux-kernel, miles.chen, Matthias Brugger,
	linux-arm-kernel, linux-mediatek, robh+dt, allen-kh.cheng,
	angelogioacchino.delregno, sboyd, chun-jie.chen, linux-clk

On Mon, 23 May 2022 12:23:38 +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The code controlling msdc clock gate was moved inthe the consumer, the MMC
> driver. This node did never represent a working implementation of any
> peripheral. It was just a lonely clock gate that wasn't used. Delete the
> binding description of this node.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> 
> ---
> 
> Changes in v3:
> - Update commit message to explain better why we do ABI breakage here
> 
> Changes in v2:
> - Delete compatible in binding descprition as well
> - Add RvB tags
> 
>  .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
>  1 file changed, 8 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-06-02 13:05     ` Rob Herring
  0 siblings, 0 replies; 21+ messages in thread
From: Rob Herring @ 2022-06-02 13:05 UTC (permalink / raw)
  To: matthias.bgg
  Cc: mturquette, ikjn, krzysztof.kozlowski+dt, devicetree, weiyi.lu,
	Krzysztof Kozlowski, linux-kernel, miles.chen, Matthias Brugger,
	linux-arm-kernel, linux-mediatek, robh+dt, allen-kh.cheng,
	angelogioacchino.delregno, sboyd, chun-jie.chen, linux-clk

On Mon, 23 May 2022 12:23:38 +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The code controlling msdc clock gate was moved inthe the consumer, the MMC
> driver. This node did never represent a working implementation of any
> peripheral. It was just a lonely clock gate that wasn't used. Delete the
> binding description of this node.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> 
> ---
> 
> Changes in v3:
> - Update commit message to explain better why we do ABI breakage here
> 
> Changes in v2:
> - Delete compatible in binding descprition as well
> - Add RvB tags
> 
>  .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
>  1 file changed, 8 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-06-02 13:05     ` Rob Herring
  0 siblings, 0 replies; 21+ messages in thread
From: Rob Herring @ 2022-06-02 13:05 UTC (permalink / raw)
  To: matthias.bgg
  Cc: mturquette, ikjn, krzysztof.kozlowski+dt, devicetree, weiyi.lu,
	Krzysztof Kozlowski, linux-kernel, miles.chen, Matthias Brugger,
	linux-arm-kernel, linux-mediatek, robh+dt, allen-kh.cheng,
	angelogioacchino.delregno, sboyd, chun-jie.chen, linux-clk

On Mon, 23 May 2022 12:23:38 +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The code controlling msdc clock gate was moved inthe the consumer, the MMC
> driver. This node did never represent a working implementation of any
> peripheral. It was just a lonely clock gate that wasn't used. Delete the
> binding description of this node.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> 
> ---
> 
> Changes in v3:
> - Update commit message to explain better why we do ABI breakage here
> 
> Changes in v2:
> - Delete compatible in binding descprition as well
> - Add RvB tags
> 
>  .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
>  1 file changed, 8 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
  2022-05-23 10:23   ` matthias.bgg
  (?)
@ 2022-06-10 18:42     ` Stephen Boyd
  -1 siblings, 0 replies; 21+ messages in thread
From: Stephen Boyd @ 2022-06-10 18:42 UTC (permalink / raw)
  To: matthias.bgg, mturquette
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger, Krzysztof Kozlowski, devicetree

Quoting matthias.bgg@kernel.org (2022-05-23 03:23:38)
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The code controlling msdc clock gate was moved inthe the consumer, the MMC
> driver. This node did never represent a working implementation of any
> peripheral. It was just a lonely clock gate that wasn't used. Delete the
> binding description of this node.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> 
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-06-10 18:42     ` Stephen Boyd
  0 siblings, 0 replies; 21+ messages in thread
From: Stephen Boyd @ 2022-06-10 18:42 UTC (permalink / raw)
  To: matthias.bgg, mturquette
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger, Krzysztof Kozlowski, devicetree

Quoting matthias.bgg@kernel.org (2022-05-23 03:23:38)
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The code controlling msdc clock gate was moved inthe the consumer, the MMC
> driver. This node did never represent a working implementation of any
> peripheral. It was just a lonely clock gate that wasn't used. Delete the
> binding description of this node.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> 
> ---

Applied to clk-next

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
@ 2022-06-10 18:42     ` Stephen Boyd
  0 siblings, 0 replies; 21+ messages in thread
From: Stephen Boyd @ 2022-06-10 18:42 UTC (permalink / raw)
  To: matthias.bgg, mturquette
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger, Krzysztof Kozlowski, devicetree

Quoting matthias.bgg@kernel.org (2022-05-23 03:23:38)
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The code controlling msdc clock gate was moved inthe the consumer, the MMC
> driver. This node did never represent a working implementation of any
> peripheral. It was just a lonely clock gate that wasn't used. Delete the
> binding description of this node.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> 
> ---

Applied to clk-next

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 2/2] clk: mediatek: Delete MT8192 msdc gate
  2022-05-23 10:23   ` matthias.bgg
  (?)
@ 2022-06-10 18:42     ` Stephen Boyd
  -1 siblings, 0 replies; 21+ messages in thread
From: Stephen Boyd @ 2022-06-10 18:42 UTC (permalink / raw)
  To: matthias.bgg, mturquette
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger

Quoting matthias.bgg@kernel.org (2022-05-23 03:23:39)
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The msdc gate is part of the MMC driver. Delete the not used code.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> 
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 2/2] clk: mediatek: Delete MT8192 msdc gate
@ 2022-06-10 18:42     ` Stephen Boyd
  0 siblings, 0 replies; 21+ messages in thread
From: Stephen Boyd @ 2022-06-10 18:42 UTC (permalink / raw)
  To: matthias.bgg, mturquette
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger

Quoting matthias.bgg@kernel.org (2022-05-23 03:23:39)
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The msdc gate is part of the MMC driver. Delete the not used code.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> 
> ---

Applied to clk-next

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 21+ messages in thread

* Re: [PATCH v3 2/2] clk: mediatek: Delete MT8192 msdc gate
@ 2022-06-10 18:42     ` Stephen Boyd
  0 siblings, 0 replies; 21+ messages in thread
From: Stephen Boyd @ 2022-06-10 18:42 UTC (permalink / raw)
  To: matthias.bgg, mturquette
  Cc: allen-kh.cheng, weiyi.lu, chun-jie.chen, linux-kernel, ikjn,
	miles.chen, robh+dt, linux-mediatek, krzysztof.kozlowski+dt,
	linux-clk, linux-arm-kernel, angelogioacchino.delregno,
	Matthias Brugger

Quoting matthias.bgg@kernel.org (2022-05-23 03:23:39)
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The msdc gate is part of the MMC driver. Delete the not used code.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Reviewed-by: Miles Chen <miles.chen@mediatek.com>
> 
> ---

Applied to clk-next

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2022-06-10 18:43 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-23 10:23 [PATCH v3 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate") matthias.bgg
2022-05-23 10:23 ` matthias.bgg
2022-05-23 10:23 ` matthias.bgg
2022-05-23 10:23 ` [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock matthias.bgg
2022-05-23 10:23   ` matthias.bgg
2022-05-23 10:23   ` matthias.bgg
2022-06-02 13:05   ` Rob Herring
2022-06-02 13:05     ` Rob Herring
2022-06-02 13:05     ` Rob Herring
2022-06-10 18:42   ` Stephen Boyd
2022-06-10 18:42     ` Stephen Boyd
2022-06-10 18:42     ` Stephen Boyd
2022-05-23 10:23 ` [PATCH v3 2/2] clk: mediatek: Delete MT8192 msdc gate matthias.bgg
2022-05-23 10:23   ` matthias.bgg
2022-05-23 10:23   ` matthias.bgg
2022-06-10 18:42   ` Stephen Boyd
2022-06-10 18:42     ` Stephen Boyd
2022-06-10 18:42     ` Stephen Boyd
2022-05-24  6:27 ` [PATCH v3 0/2] Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate") Chen-Yu Tsai
2022-05-24  6:27   ` Chen-Yu Tsai
2022-05-24  6:27   ` Chen-Yu Tsai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.