All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: sbabic@denx.de, festevam@gmail.com,
	Tim Harvey <tharvey@gateworks.com>,
	"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>
Cc: u-boot@lists.denx.de, Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 17/22] imx: imx8mm/n/p-venice: enable pinctrl_wdog in SPL
Date: Mon, 23 May 2022 20:40:29 +0800	[thread overview]
Message-ID: <20220523124034.12813-18-peng.fan@oss.nxp.com> (raw)
In-Reply-To: <20220523124034.12813-1-peng.fan@oss.nxp.com>

From: Peng Fan <peng.fan@nxp.com>

Mark pinctrl_wdog as u-boot,dm-spl to clean up board code,

The set_wdog_reset() function is not necessary as this is handled by
the imx_watchdog.c driver due to the 'fsl,ext-reset-output' property
being set.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm/dts/imx8mm-venice-u-boot.dtsi |  4 ++++
 arch/arm/dts/imx8mn-venice-u-boot.dtsi |  4 ++++
 arch/arm/dts/imx8mp-venice-u-boot.dtsi |  4 ++++
 board/gateworks/venice/spl.c           | 29 --------------------------
 4 files changed, 12 insertions(+), 29 deletions(-)

diff --git a/arch/arm/dts/imx8mm-venice-u-boot.dtsi b/arch/arm/dts/imx8mm-venice-u-boot.dtsi
index c61c6de935f..68978a0413e 100644
--- a/arch/arm/dts/imx8mm-venice-u-boot.dtsi
+++ b/arch/arm/dts/imx8mm-venice-u-boot.dtsi
@@ -72,3 +72,7 @@
 &wdog1 {
 	u-boot,dm-spl;
 };
+
+&pinctrl_wdog {
+	u-boot,dm-spl;
+};
diff --git a/arch/arm/dts/imx8mn-venice-u-boot.dtsi b/arch/arm/dts/imx8mn-venice-u-boot.dtsi
index 4f23da35676..35819553879 100644
--- a/arch/arm/dts/imx8mn-venice-u-boot.dtsi
+++ b/arch/arm/dts/imx8mn-venice-u-boot.dtsi
@@ -110,6 +110,10 @@
 	u-boot,dm-spl;
 };
 
+&pinctrl_wdog {
+	u-boot,dm-spl;
+};
+
 &binman {
 	u-boot-spl-ddr {
 		align = <4>;
diff --git a/arch/arm/dts/imx8mp-venice-u-boot.dtsi b/arch/arm/dts/imx8mp-venice-u-boot.dtsi
index 37f3edc9817..96b9fa89cf4 100644
--- a/arch/arm/dts/imx8mp-venice-u-boot.dtsi
+++ b/arch/arm/dts/imx8mp-venice-u-boot.dtsi
@@ -72,3 +72,7 @@
 &wdog1 {
 	u-boot,dm-spl;
 };
+
+&pinctrl_wdog {
+	u-boot,dm-spl;
+};
diff --git a/board/gateworks/venice/spl.c b/board/gateworks/venice/spl.c
index 6e6ce015f28..4c0feb4381c 100644
--- a/board/gateworks/venice/spl.c
+++ b/board/gateworks/venice/spl.c
@@ -87,33 +87,6 @@ static void spl_dram_init(int size)
 	ddr_init(dram_timing);
 }
 
-#define WDOG_PAD_CTRL	(PAD_CTL_DSE6 | PAD_CTL_ODE | PAD_CTL_PUE | PAD_CTL_PE)
-
-#ifdef CONFIG_IMX8MM
-static iomux_v3_cfg_t const wdog_pads[] = {
-	IMX8MM_PAD_GPIO1_IO02_WDOG1_WDOG_B  | MUX_PAD_CTRL(WDOG_PAD_CTRL),
-};
-#elif CONFIG_IMX8MN
-static const iomux_v3_cfg_t wdog_pads[] = {
-	IMX8MN_PAD_GPIO1_IO02__WDOG1_WDOG_B  | MUX_PAD_CTRL(WDOG_PAD_CTRL),
-};
-#elif CONFIG_IMX8MP
-static const iomux_v3_cfg_t wdog_pads[] = {
-	MX8MP_PAD_GPIO1_IO02__WDOG1_WDOG_B  | MUX_PAD_CTRL(WDOG_PAD_CTRL),
-};
-#endif
-
-int board_early_init_f(void)
-{
-	struct wdog_regs *wdog = (struct wdog_regs *)WDOG1_BASE_ADDR;
-
-	imx_iomux_v3_setup_multiple_pads(wdog_pads, ARRAY_SIZE(wdog_pads));
-
-	set_wdog_reset(wdog);
-
-	return 0;
-}
-
 /*
  * Model specific PMIC adjustments necessary prior to DRAM init
  *
@@ -253,8 +226,6 @@ void board_init_f(ulong dummy)
 
 	init_uart_clk(1);
 
-	board_early_init_f();
-
 	timer_init();
 
 	/* Clear the BSS. */
-- 
2.36.0


  parent reply	other threads:[~2022-05-23 12:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-23 12:40 [PATCH 00/22] imx: patches in queue Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 01/22] imx: drop CONFIG_MXC_UART_BASE Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 02/22] imx: imx8m[m/n/p]_venice: Enable SPL_DM_SERIAL Peng Fan (OSS)
2022-05-23 17:10   ` Tim Harvey
2022-05-23 12:40 ` [PATCH 03/22] imx: imx8m[m/n]_beacon: " Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 04/22] imx: imx8mm-cl-iot-gate: Enable DM_SERIAL Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 05/22] imx: imx8mm_icore: Enable SPL_DM_SERIAL Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 06/22] imx: imx8m[m/p]_phycore: Enable DM_SERIAL Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 07/22] imx: imx8mn_var_som: enable DM_SERIAL Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 08/22] imx: kontron-sl-mx8mm: " Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 09/22] configs: drop CONFIG_SPL_ABORT_ON_RAW_IMAGE Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 10/22] configs: imx8m: use common imx8m.h for i.MX8MM Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 11/22] configs: imx8m: use common imx8m.h for i.MX8MN Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 12/22] configs: imx8m: use common imx8m.h for i.MX8MP Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 13/22] configs: imx8m: use common imx8m.h for i.MX8MQ Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 14/22] imx: imx8mm_beacon: enable pinctrl_wdog in SPL Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 15/22] imx: imx8mm-cl-iot-gate: " Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 16/22] imx: engicam-imx8mm: drop unused macro Peng Fan (OSS)
2022-05-23 12:40 ` Peng Fan (OSS) [this message]
2022-05-23 12:40 ` [PATCH 18/22] imx: imx8mn-beacon: enable pinctrl_wdog in SPL Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 19/22] imx: imx8mn_var_som: clean up board watchdog code Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 20/22] imx: imx8mp_rsb7320a1: enable wdog driver model in SPL Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 21/22] imx: imx8mn-kontron-n801x: enable pinctrl_wdog " Peng Fan (OSS)
2022-05-23 12:40 ` [PATCH 22/22] imx: phycore_imx8mm/p: clean up board watchdog code Peng Fan (OSS)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220523124034.12813-18-peng.fan@oss.nxp.com \
    --to=peng.fan@oss.nxp.com \
    --cc=festevam@gmail.com \
    --cc=peng.fan@nxp.com \
    --cc=sbabic@denx.de \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.