From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0ED65C433F5 for ; Mon, 23 May 2022 14:10:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9793C83F72; Mon, 23 May 2022 16:10:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="TaYdqURP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7D14383F72; Mon, 23 May 2022 16:10:35 +0200 (CEST) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 016CA801BF for ; Mon, 23 May 2022 16:10:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2e.google.com with SMTP id dm17so12171343qvb.2 for ; Mon, 23 May 2022 07:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=p7XgtA72WsaBoYq75XjFmaK69KYg0VzY5rD9NsfCxtM=; b=TaYdqURPdYQJKWHwDyUlq3lz0++IatJBaXY4mt96yYvbI4drzMinKAy+RAL4OLjlJu fPtt0KfA+jDIRi9D/waaPJws6llyicDvPPjDqC8d7Tx/C1JvHybYeZY2I35/FGltxELB dRh8ZfC5wnrhrf3/7CeEuqMwaDMowHjoygk0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=p7XgtA72WsaBoYq75XjFmaK69KYg0VzY5rD9NsfCxtM=; b=7cEA0/FR0sq3tfTnITFYkJ5ZMkIU6fwlJ5iomi/0bDcbzNg/NggC0iFiISf36C9Naz bBrGPTvvniUmOhO0DQDMjGnywz0IBhd0NXt+uV9YIX8f6K+qIM4+veTfZRQa+M/AQACT 5ThYG09iBzyJy/daKqURxPMJGgHltd0+FenDLbkAzPIEZzkGepUUpif7R8VzGGFiuxrU kdjoUFXtRPhnIMBy04Zfr/Zhba6n2pVBzKs1sNSptufach1GuL1EDR54B3wX4kcI+D+h byj2j/Gni0/LzXg14hFoVkQlQMgsn/OmeafwICXMtZ+tm6+WX1cHKAiDv6tMAK+gIzkP 7Fjw== X-Gm-Message-State: AOAM533y5aYQSMYffDnGPoTX1pcOkbK1swpvju35D/kOEO0CchnsWDaM e5gzpEqKnlVR/7ArM8uEHUoukw== X-Google-Smtp-Source: ABdhPJyXTlRL93xQZI3Tr8RskqJvt6GQsp9Xtx+C/xtJq0NwLchbiax2vAd8GFRda+eZvmkUg12SOA== X-Received: by 2002:ad4:5c6f:0:b0:462:483f:650b with SMTP id i15-20020ad45c6f000000b00462483f650bmr1755765qvh.27.1653315030801; Mon, 23 May 2022 07:10:30 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-25fd-0000-0000-0000-1003.res6.spectrum.com. [2603:6081:7b00:25fd::1003]) by smtp.gmail.com with ESMTPSA id u2-20020a05620a120200b0069fc13ce206sm4286672qkj.55.2022.05.23.07.10.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 May 2022 07:10:29 -0700 (PDT) Date: Mon, 23 May 2022 10:10:27 -0400 From: Tom Rini To: "Peng Fan (OSS)" Cc: "sbabic@denx.de" , "festevam@gmail.com" , "ariel.dalessandro@collabora.com" , "michael@amarulasolutions.com" , "tharvey@gateworks.com" , "sjg@chromium.org" , "alpernebiyasak@gmail.com" , "marek.behun@nic.cz" , "pali@kernel.org" , "sr@denx.de" , Ricardo Salveti , "patrick.delaunay@foss.st.com" , "u-boot@lists.denx.de" Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 Message-ID: <20220523141027.GM13239@bill-the-cat> References: <20220520141048.20034-1-peng.fan@oss.nxp.com> <20220520141048.20034-2-peng.fan@oss.nxp.com> <20220520152127.GC13239@bill-the-cat> <20220521120518.GI13239@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yQDbd2FCF2Yhw41T" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --yQDbd2FCF2Yhw41T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 23, 2022 at 06:28:44AM +0000, Peng Fan (OSS) wrote: > > Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > >=20 > > On Sat, May 21, 2022 at 08:33:56AM +0000, Peng Fan wrote: > > > > Subject: Re: [PATCH V4 1/8] spl: guard u_boot_any with X86 > > > > > > > > On Fri, May 20, 2022 at 10:10:40PM +0800, Peng Fan (OSS) wrote: > > > > > > > > > From: Peng Fan > > > > > > > > > > set the symbol as weak not work if LTO is enabled. Since > > > > > u_boot_any is only used on X86 for now, so guard it with X86, > > > > > otherwise build break if we use BINMAN_SYMBOLS on i.MX. > > > > > > > > > > Tested-by: Tim Harvey #imx8m[m,n,p]-venice > > > > > Signed-off-by: Peng Fan > > > > > --- > > > > > common/spl/spl.c | 8 ++++++-- > > > > > common/spl/spl_ram.c | 4 ++++ > > > > > 2 files changed, 10 insertions(+), 2 deletions(-) > > > > > > > > I think we long term need to figure this out and address it so LTO > > > > works. But for now can you please guard this with a test on LTO > > > > instead, so it's clear where the problem is? > > > > > > Sorry, I could not get your point about guard with a test on LTO. > > > > > > Actually binman weak symbol will report a warning log if there is no > > > u_boot_any binman symbol. Since only X86 use it, I guard with X86. > >=20 > > Why are you mentioning LTO in the commit message? When I read the > > commit message it sounds like you're saying the problem is that LTO doe= sn't > > like how this symbol is handled, but if LTO was disabled, everything wo= uld be > > fine. If it's not LTO-related, please re-word the message instead. >=20 > Sorry, I could reword the commit message, but currently I have no better > idea to address the issue unless use X86 as a guard in the code as this > patch does. If you agree the code in this patch, I could reword commit msg > and send v5. Well, lets see what Alper says in the other part of the thread. I'd really like to solve this not work around this. But I'll take documenting the problem for the person that has X86 && LTO as good enough for the moment. --=20 Tom --yQDbd2FCF2Yhw41T Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmKLlc8ACgkQFHw5/5Y0 tyy0AQwAp2rxXxIh02zdSqyO9rdO/kmmVHRYYeBVo0OW1Wxtac5Mt/JpwgSAS4Et 9hJukU3CYUyqnhw9xLthAmPvLuemm7qUcCNDO3+Y7tpQajdhLdBXnEuNihK93URL xae911CoPH0firxkFTe6K2h7pFfkoGOuDPydbi2bd3Tnz2nEvIZOHg2kcngFVc0o YJMN8q59FL20djDxVg5vnW1VHq1EdmG0XI866yeqZ2I/Rq18K+gXFAUY9YR4yzk7 G3mu3ltZh1tpm1ABySfvVgSsBLEgR9RXAgMHbZlJ00poAaoz5HDCeLhHp/356Szv R1fQv9qoQ0AaPLsLPG46ct462/2hjcIgeqyTfIttF9rlkz/Q4KjMM4Fd821PZurf Z2omJRko3NTQmzcS6BhfE0FydcxARETkYhAWOLmJ3k/HSVlv7HCzqb0fHQzq6QbC wQm72X/TzgXwKAqLt1F7+UzHe35ubxRLlI86+fX4/AHsA7QajYdmSQVJpyl7kYwZ Ss3d98m+ =B/Lc -----END PGP SIGNATURE----- --yQDbd2FCF2Yhw41T--