From: Pavel Machek <pavel@ucw.cz>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: leds: Add bindings for the TLC5925 controller
Date: Mon, 23 May 2022 22:05:52 +0200 [thread overview]
Message-ID: <20220523200552.GB15554@duo.ucw.cz> (raw)
In-Reply-To: <20220523084958.2723943-2-jjhiblot@traphandler.com>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
Hi!
> + led-satus@0 {
led-status.
> + led-alive@24 {
> + reg = <24>;
> + label = "green:alive"
> + };
> +
> + led-panic@31 {
> + reg = <31>;
> + label = "red:panic"
> + };
Please check documentation, if live and panic leds are common, you may
want to add it there. But better make it green:power or something.
BR,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2022-05-23 20:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220523084958.2723943-1-jjhiblot@traphandler.com>
2022-05-23 8:49 ` [PATCH 1/3] dt-bindings: leds: Add bindings for the TLC5925 controller Jean-Jacques Hiblot
2022-05-23 10:14 ` Krzysztof Kozlowski
2022-05-23 13:07 ` Jean-Jacques Hiblot
2022-05-23 15:16 ` Jean-Jacques Hiblot
2022-05-23 15:30 ` Krzysztof Kozlowski
2022-05-23 15:37 ` Jean-Jacques Hiblot
2022-05-23 15:39 ` Krzysztof Kozlowski
2022-05-23 12:33 ` Rob Herring
2022-05-23 20:05 ` Pavel Machek [this message]
2022-05-23 8:49 ` [PATCH 2/3] leds: Add driver for the TLC5925 LED controller Jean-Jacques Hiblot
2022-05-23 8:49 ` [PATCH 3/3] leds: tlc5925: Add support for non blocking operations Jean-Jacques Hiblot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220523200552.GB15554@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=jjhiblot@traphandler.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.