Re: [PATCH] fix: nvme_update_ns_info method should be called even if nvme_ms_ids_equal return false

From: "hch@lst.de" <hch@lst.de>
To: Arman Hajishafieha <arman.hajishafieha@hotmail.com>
Cc: "hch@lst.de" <hch@lst.de>, "me@kingtous.cn" <me@kingtous.cn>,
	"kbusch@kernel.org" <kbusch@kernel.org>,
	"kingtous@qq.com" <kingtous@qq.com>,
	"sagi@grimberg.me" <sagi@grimberg.me>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"axboe@fb.com" <axboe@fb.com>
Subject: Re: [PATCH] fix: nvme_update_ns_info method should be called even if nvme_ms_ids_equal return false
Date: Tue, 24 May 2022 15:50:58 +0200	[thread overview]
Message-ID: <20220524135058.GA31121@lst.de> (raw)
In-Reply-To: <741c80abb8a443c4745f213e9ecd413f6a6a7467.camel@hotmail.com>

On Mon, May 23, 2022 at 06:18:01PM +0000, Arman Hajishafieha wrote:
> I can confirm that "MAXIO MAP1001" (1e4b:1001) controller found in
> "Asgard N2 1TB SSD" suffers from the exact same issue as well.
> After applying the patch to disable checking namespace identifiers it
> can resume from suspend normally. It seems like this issue affects a
> wider range of Maxio controllers.
> Could you please add a quirk for this device as well?

Please try this:

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 5a98a7de09642..cb4adc0c22843 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3453,6 +3453,8 @@ static const struct pci_device_id nvme_id_table[] = {
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
 	{ PCI_DEVICE(0x2646, 0x2263),   /* KINGSTON A2000 NVMe SSD  */
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS, },
+	{ PCI_DEVICE(0x1e4B, 0x1001),   /* MAXIO MAP1001 */
+		.driver_data = NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1e4B, 0x1002),   /* MAXIO MAP1002 */
 		.driver_data = NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x1e4B, 0x1202),   /* MAXIO MAP1202 */


