From: Rob Herring <robh@kernel.org>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: bjorn.andersson@linaro.org, krzysztof.kozlowski+dt@linaro.org,
ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
swboyd@chromium.org, mka@chromium.org
Subject: Re: [PATCH v4 3/3] dt-bindings: remoteproc: qcom: Convert SC7180 MSS bindings to YAML
Date: Tue, 24 May 2022 09:09:40 -0500 [thread overview]
Message-ID: <20220524140940.GA3687200-robh@kernel.org> (raw)
In-Reply-To: <b495fa6c-6964-d8fa-0baf-acd719cd8779@quicinc.com>
On Tue, May 24, 2022 at 07:40:51AM +0530, Sibi Sankar wrote:
> Hey Rob,
> Thanks for taking time to review the series.
>
> On 5/21/22 4:10 AM, Rob Herring wrote:
> > On Thu, May 19, 2022 at 10:17:05PM +0530, Sibi Sankar wrote:
> > > Convert SC7180 MSS PIL loading bindings to YAML.
> >
> > I suppose there is a reason the sc7180 is being split out and the only
> > one converted, but this doesn't tell me.
>
> https://lore.kernel.org/all/e3543961-1645-b02a-c869-f8fa1ad2d41c@quicinc.com/#t
>
> The reason for the split was discussed on the list ^^, thought it
> wouldn't make much sense adding any of it to the commit message.
Why not? If you did, then we wouldn't be having this conversation.
Commit messages, at a minimum, should answer why are you making the
change. They don't really need to explain what the change is. We can all
read the diff to understand that.
Rob
next prev parent reply other threads:[~2022-05-24 14:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 16:47 [PATCH v4 0/3] Add support for proxy interconnect bandwidth votes Sibi Sankar
2022-05-19 16:47 ` [PATCH v4 1/3] arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem Sibi Sankar
2022-05-19 20:35 ` Bjorn Andersson
2022-05-20 18:08 ` Sibi Sankar
2022-05-20 19:07 ` Stephen Boyd
2022-05-26 11:16 ` Sibi Sankar
2022-07-03 3:56 ` (subset) " Bjorn Andersson
2022-05-19 16:47 ` [PATCH v4 2/3] dt-bindings: remoteproc: qcom: Convert SC7280 MSS bindings to YAML Sibi Sankar
2022-05-19 19:23 ` Rob Herring
2022-05-19 22:35 ` Stephen Boyd
2022-05-20 18:46 ` Sibi Sankar
2022-05-20 20:10 ` Stephen Boyd
2022-05-24 2:22 ` Sibi Sankar
2022-05-21 14:33 ` Krzysztof Kozlowski
2022-05-19 16:47 ` [PATCH v4 3/3] dt-bindings: remoteproc: qcom: Convert SC7180 " Sibi Sankar
2022-05-20 22:40 ` Rob Herring
2022-05-21 14:34 ` Krzysztof Kozlowski
2022-05-24 2:00 ` Sibi Sankar
2022-05-24 17:33 ` Krzysztof Kozlowski
2022-05-25 5:30 ` Sibi Sankar
2022-05-24 2:10 ` Sibi Sankar
2022-05-24 14:09 ` Rob Herring [this message]
2022-05-25 5:29 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524140940.GA3687200-robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mka@chromium.org \
--cc=ohad@wizery.com \
--cc=quic_sibis@quicinc.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.