All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
	<linux-ide@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>, <hdegoede@redhat.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH 3/3] ahci: Document the loss of hotplug by new LPM policy
Date: Tue, 24 May 2022 12:05:08 -0500	[thread overview]
Message-ID: <20220524170508.563-4-mario.limonciello@amd.com> (raw)
In-Reply-To: <20220524170508.563-1-mario.limonciello@amd.com>

Per AHCI spec v1.3.1, "7.3 Native Hot Plug Support", once LPM is
enabled hotplug support needs to be disabled.

The LPM code always followed this and disabled the port when no
drives were connected, but as more machines will be exposed to
this code it might be an unexpected behavior to some users.

Add a note to parameter documentation to explain the new behavior.

Link: https://bugs.launchpad.net/bugs/1971576
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 Documentation/admin-guide/kernel-parameters.txt | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 9e6bd212004d..4dcd9a3ba4a5 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -279,6 +279,13 @@
 			3 => Medium power with Device Initiated PM enabled
 			4 => Minimum power
 
+			NOTE: Enabling LPM when no drive is connected will disable
+			the port which means hotplug will not work.
+
+			If hotplug is an important use case, this can be modified
+			at runtime by changing
+			/sys/module/ahci/parameters/lpm_policy
+
 	ALSA		[HW,ALSA]
 			See Documentation/sound/alsa-configuration.rst
 
-- 
2.34.1


  parent reply	other threads:[~2022-05-24 17:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-24 17:05 [PATCH v3 0/3] Drop mobile board support Mario Limonciello
2022-05-24 17:05 ` [PATCH 1/3] ata: ahci: Drop low power policy board type Mario Limonciello
2022-05-24 17:05 ` [PATCH 2/3] ata: ahci: Rename module parameter for lpm policy Mario Limonciello
2022-05-25  9:03   ` Christoph Hellwig
2022-05-25 11:11     ` Damien Le Moal
2022-05-24 17:05 ` Mario Limonciello [this message]
2022-05-25  9:04   ` [PATCH 3/3] ahci: Document the loss of hotplug by new LPM policy Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220524170508.563-4-mario.limonciello@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.