From: Dmitry Rokosov <DDRokosov@sberdevices.ru>
To: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"lorenzo.bianconi83@gmail.com" <lorenzo.bianconi83@gmail.com>,
"srinivas.pandruvada@linux.intel.com"
<srinivas.pandruvada@linux.intel.com>,
"teodora.baluta@intel.com" <teodora.baluta@intel.com>,
"narcisaanamaria12@gmail.com" <narcisaanamaria12@gmail.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
kernel <kernel@sberdevices.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Rokosov <DDRokosov@sberdevices.ru>
Subject: [PATCH v2 3/5] iio:accel:mxc4005: rearrange iio trigger get and register
Date: Tue, 24 May 2022 18:14:43 +0000 [thread overview]
Message-ID: <20220524181150.9240-4-ddrokosov@sberdevices.ru> (raw)
In-Reply-To: <20220524181150.9240-1-ddrokosov@sberdevices.ru>
IIO trigger interface function iio_trigger_get() should be called after
iio_trigger_register() (or its devm analogue) strictly, because of
iio_trigger_get() acquires module refcnt based on the trigger->owner
pointer, which is initialized inside iio_trigger_register() to
THIS_MODULE.
If this call order is wrong, the next iio_trigger_put() (from sysfs
callback or "delete module" path) will dereference "default" module
refcnt, which is incorrect behaviour.
Fixes: 47196620c82f ("iio: mxc4005: add data ready trigger for mxc4005")
Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
---
drivers/iio/accel/mxc4005.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/accel/mxc4005.c b/drivers/iio/accel/mxc4005.c
index b3afbf064915..df600d2917c0 100644
--- a/drivers/iio/accel/mxc4005.c
+++ b/drivers/iio/accel/mxc4005.c
@@ -456,8 +456,6 @@ static int mxc4005_probe(struct i2c_client *client,
data->dready_trig->ops = &mxc4005_trigger_ops;
iio_trigger_set_drvdata(data->dready_trig, indio_dev);
- indio_dev->trig = data->dready_trig;
- iio_trigger_get(indio_dev->trig);
ret = devm_iio_trigger_register(&client->dev,
data->dready_trig);
if (ret) {
@@ -465,6 +463,8 @@ static int mxc4005_probe(struct i2c_client *client,
"failed to register trigger\n");
return ret;
}
+
+ indio_dev->trig = iio_trigger_get(data->dready_trig);
}
return devm_iio_device_register(&client->dev, indio_dev);
--
2.36.0
next prev parent reply other threads:[~2022-05-24 18:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 18:14 [PATCH v2 0/5] iio: treewide: rearrange iio trig get/register Dmitry Rokosov
2022-05-24 18:14 ` [PATCH v2 1/5] iio:accel:bma180: rearrange iio trigger get and register Dmitry Rokosov
2022-05-24 19:53 ` Andy Shevchenko
2022-05-24 18:14 ` [PATCH v2 2/5] iio:accel:kxcjk-1013: " Dmitry Rokosov
2022-05-24 19:49 ` Andy Shevchenko
2022-05-24 18:14 ` Dmitry Rokosov [this message]
2022-05-24 19:50 ` [PATCH v2 3/5] iio:accel:mxc4005: " Andy Shevchenko
2022-05-24 18:14 ` [PATCH v2 4/5] iio:chemical:ccs811: " Dmitry Rokosov
2022-05-24 19:51 ` Andy Shevchenko
2022-05-24 18:14 ` [PATCH v2 5/5] iio:humidity:hts221: " Dmitry Rokosov
2022-05-24 19:52 ` Andy Shevchenko
2022-05-28 17:10 ` [PATCH v2 0/5] iio: treewide: rearrange iio trig get/register Jonathan Cameron
2022-05-30 15:29 ` Dmitry Rokosov
2022-05-31 18:20 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220524181150.9240-4-ddrokosov@sberdevices.ru \
--to=ddrokosov@sberdevices.ru \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=narcisaanamaria12@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=teodora.baluta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.