All of lore.kernel.org
 help / color / mirror / Atom feed
From: Subendu Santra <subendu@arista.com>
To: Maryam Tahhan <maryam.tahhan@intel.com>,
	Reshma Pattan <reshma.pattan@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, Subendu Santra <subendu@arista.com>
Subject: [PATCH v2] app/procinfo: show all non-owned ports
Date: Tue, 24 May 2022 22:52:50 -0700	[thread overview]
Message-ID: <20220525055250.22541-1-subendu@arista.com> (raw)
In-Reply-To: <20220510132118.22688-1-subendu@arista.com>

Show all non-owned ports when no port mask is specified

show-port option without the mask option, displays only the last
non-owned port. Show all the non-owned ports instead.

Fixes: 1dd6cffb6571 ("app/procinfo: provide way to request info on owned
ports")
Cc: stephen@networkplumber.org

Signed-off-by: Subendu Santra <subendu@arista.com>
---
 app/proc-info/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index 56070a3317..2be24b584e 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -1504,10 +1504,10 @@ main(int argc, char **argv)
 	if (nb_ports == 0)
 		rte_exit(EXIT_FAILURE, "No Ethernet ports - bye\n");
 
-	/* If no port mask was specified, then show non-owned ports */
+	/* If no port mask was specified, then show all non-owned ports */
 	if (enabled_port_mask == 0) {
 		RTE_ETH_FOREACH_DEV(i)
-			enabled_port_mask = 1ul << i;
+			enabled_port_mask |= (1ul << i);
 	}
 
 	for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
-- 
2.28.0


  parent reply	other threads:[~2022-05-25  5:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 13:21 [PATCH] app/procinfo: show all non-owned ports Subendu Santra
2022-05-23 10:53 ` Subendu Santra
2022-05-23 14:41   ` Thomas Monjalon
2022-05-23 16:10     ` Subendu Santra
2022-05-23 18:00       ` Thomas Monjalon
2022-05-25  5:52 ` Subendu Santra [this message]
2022-05-25  5:58   ` [PATCH v2] " Subendu Santra
2022-05-25  5:46 Subendu Santra
2022-05-25  6:04 ` Stephen Hemminger
2022-05-25  7:14   ` Morten Brørup
2022-06-06 14:20     ` Subendu Santra
2022-06-26 15:26     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220525055250.22541-1-subendu@arista.com \
    --to=subendu@arista.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=maryam.tahhan@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.