On Tue, May 24, 2022 at 03:37:23PM -0600, Jens Axboe wrote: >Almost all of them are, the odd ones out are the poll remove and the >files update request. Name them like the others, which is: > >io_#cmdname_prep for request preparation >io_#cmdname for request issue case IORING_OP_READV: case IORING_OP_READ_FIXED: case IORING_OP_READ: case IORING_OP_WRITEV: case IORING_OP_WRITE_FIXED: case IORING_OP_WRITE: return io_prep_rw(req, sqe); Should io_prep_rw be renamed to io_rw_prep as well? Looks good. Reviewed-by: Kanchan Joshi