From: Dave Chinner <david@fromorbit.com>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 2/2] tests: remove redundant common/$FSTYP importing
Date: Thu, 26 May 2022 10:13:26 +1000 [thread overview]
Message-ID: <20220526001326.GX2306852@dread.disaster.area> (raw)
In-Reply-To: <20220525073427.3355242-3-zlang@kernel.org>
On Wed, May 25, 2022 at 03:34:27PM +0800, Zorro Lang wrote:
> As fstests intensively source specific common/$FSTYP files in
> common/rc, at the beginning of ./check running. Each single case
> doesn't need to import that again.
>
> Signed-off-by: Zorro Lang <zlang@kernel.org>
> ---
> tests/btrfs/177 | 1 -
> tests/btrfs/258 | 1 -
> tests/btrfs/259 | 1 -
> tests/xfs/422 | 1 -
> tests/xfs/423 | 1 -
> tests/xfs/517 | 1 -
> 6 files changed, 6 deletions(-)
>
> diff --git a/tests/btrfs/177 b/tests/btrfs/177
> index 2fd11e89..7b004b83 100755
> --- a/tests/btrfs/177
> +++ b/tests/btrfs/177
> @@ -10,7 +10,6 @@
> _begin_fstest auto quick swap balance
>
> . ./common/filter
> -. ./common/btrfs
>
> # Modify as appropriate.
> _supported_fs btrfs
> diff --git a/tests/btrfs/258 b/tests/btrfs/258
> index 158eaf79..8fc828df 100755
> --- a/tests/btrfs/258
> +++ b/tests/btrfs/258
> @@ -11,7 +11,6 @@
> _begin_fstest auto defrag quick
>
> . ./common/btrfs
> -. ./common/filter
I think you removed the wrong line here.
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-05-26 0:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 7:34 [PATCH 0/2] source fs specific common file properly Zorro Lang
2022-05-25 7:34 ` [PATCH 1/2] common: source base fs specific common file Zorro Lang
2022-05-26 6:39 ` Amir Goldstein
2022-05-25 7:34 ` [PATCH 2/2] tests: remove redundant common/$FSTYP importing Zorro Lang
2022-05-26 0:13 ` Dave Chinner [this message]
2022-05-26 1:14 ` Zorro Lang
2022-05-26 1:23 ` [PATCH v2 " Zorro Lang
2022-05-26 2:28 ` Dave Chinner
2022-05-26 6:51 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220526001326.GX2306852@dread.disaster.area \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.