From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C87DC433FE for ; Thu, 26 May 2022 01:40:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245169AbiEZBkI (ORCPT ); Wed, 25 May 2022 21:40:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229458AbiEZBkG (ORCPT ); Wed, 25 May 2022 21:40:06 -0400 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2073.outbound.protection.outlook.com [40.107.93.73]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2490A9E9C9; Wed, 25 May 2022 18:40:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QkomaV7CbOhAcjainTvxliPpZSHFQp4OpXLIOE9bZnLK9pt7a8AHDv+2wmdcPHzj90CtKGMmnIxtIgjSdp+/YWt2+PKK/BIm1c7IKgCWJXkHFWylbPeSmNSc261oS4w5hdhz8hnQkONv49aS0qG4911SFMTeGqZ5pOELp7/Sxf4aPa/HOTfK+/K7pP4lXdWph83Um11kpDr5MiVBrJ9GEgusv2t9svt+o3W5Y1NXu52fAuq+DxTEI9t23veR0/XXIMoD57tH50kl86DTTUClmpDoplL0+5S8Bjph8OBt2kxFKj55FzqDL/2m17tcwgTgd/mBCgOuvcB5VWbvhrgCfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PsOmawRqNbcPIBFzTVggIjeM2cLvhIgOZYMdfCRxcrg=; b=LxUUkXjeTXEE1NwGEN1vyjuUrZnCVBFL0KvEuJmy7CidGcTkA2EaCttfqa/e84ooIdN7QkHu99UhHcm0TEjaPfOaSKIis2mYsNJ6/NWFUbI8QR820mPRR/a6OLOrfT1ULg+XnJfg9yomA+bIWe7F0ELhEo2RPzP02s0XKL64H3eYzDrif6eAHg4IaYEULi4gsHEGQjumEZPkrnvXrABbTh9FkUTXhxYLVIHpM0PY0r1ZlwUQ7dtvXQfctH5prmllVAKqWxicJJTr9NLSnzcrlUdUQe78FKtHvPGGC0DUugAcaZ7DAApBR+y4M7cHIznkrKHazX3dCLL4kzcUGVKwJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PsOmawRqNbcPIBFzTVggIjeM2cLvhIgOZYMdfCRxcrg=; b=UWyh4QRxNNKIOKh7s9peha4cwLW6YOswLbNv44/tVCUr+dsrjNP2kW1qaqxKKPJ1/KQ1hl+P3i8ITqN++lwxQufx3A4oq6VYfMkfxTfeOKQw5LvRFBJqAHDktzcg48KM4DiEJtf8QsZXeOZu/q2Crd8BJ3hruSMcX0RRqt2fftyBGB6gN4F47u70RwTyTnwnQ7IK5eXYM5eWEmfNjYJwrJ7gmiKsemGrBEQpMSjfdJFgzIyr9QPNdtc/PQOeYJmUdvYiOuQAMAC4vvh2yRi0Arflv0TN4YQbS3DLRYMsNJ0e3aXfPdhbyU7sUBEnEZAr8qdlEHPu5SHru94rvwA8Iw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) by BL1PR12MB5256.namprd12.prod.outlook.com (2603:10b6:208:319::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 01:40:03 +0000 Received: from MN2PR12MB4192.namprd12.prod.outlook.com ([fe80::2484:51da:d56f:f1a5]) by MN2PR12MB4192.namprd12.prod.outlook.com ([fe80::2484:51da:d56f:f1a5%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 01:40:03 +0000 Date: Wed, 25 May 2022 22:40:00 -0300 From: Jason Gunthorpe To: "Tian, Kevin" Cc: Baolu Lu , "devicetree@vger.kernel.org" , "yuji2.ishikawa@toshiba.co.jp" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Rob Herring , Nobuhiro Iwamatsu , Will Deacon , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/3] iommu: Add Visconti5 IOMMU driver Message-ID: <20220526014000.GJ1343366@nvidia.com> References: <20220525013147.2215355-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20220525013147.2215355-2-nobuhiro1.iwamatsu@toshiba.co.jp> <63369db0-cf7f-aa53-bf9f-de2b0b2289ac@linux.intel.com> <20220525182644.GF1343366@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BL1PR13CA0065.namprd13.prod.outlook.com (2603:10b6:208:2b8::10) To MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c3aeb99-e00b-44d0-cc1f-08da3eb8a786 X-MS-TrafficTypeDiagnostic: BL1PR12MB5256:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hK9j97MoFANU1dtsTS5FXzxR4WaicMOSnxEzOtEPZ7adFRxvRzsl9FeimleXAvnWaewJuVin8yKf6xmtfiXSyf4p6XUsV2pujRiR78vCgaUYOFbuf7G/F6Kwz8H8o6gT0FpNUK9+EpbOPu+rsDpGoi/KAFqZi6xbBPfl/4RZUt6OMrkF/sW13D0+NRlQtOW2Mgz7Z0ajVUjl19fl5X/WI/XeZJMIMuuPwjgKjoepw9M3JnIN1tg4lQBHdJ1A2vbiHc+frRx3obXBXpan7TCsnjpTAE8rC58OOwU0cLb0OTcByMBhnGJRPfSSxlf7O7C4zygj/BKEXSD0gT2ActCIZmbgvxGMZuLvAs29T3qppQEoHJOIh/OswU77TPenE2MMa7sIc+BX+xLZlN00tBN0Rf0SGFIHIlODn9B6vMWbL/9IWSjDWRC5hj6X1qOIcH+ztRy9sCPX2nDNNgFe005vhtAgNTFDUuo/MjxndfBe+GcaqW5e4DkV7bE16Di9oyzTTUz/l5d/bh3utFGVoWS8YSDiJIW/aufm6C0+WymuJURxg+VB/ZAHuXIqBYkBF/83OJyqM5b8BFCnC5O5tbFsdvV++5n1KjWLuQiz4De0CukUZwVh0MsH5sXtfjY1ftIdQ2Fve1DYZzEZHdM65IMH7w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4192.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(4326008)(83380400001)(5660300002)(316002)(6916009)(54906003)(66946007)(66556008)(66476007)(86362001)(36756003)(6486002)(4744005)(508600001)(2616005)(1076003)(7416002)(38100700002)(8936002)(26005)(6506007)(6512007)(33656002)(2906002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+E8tFhFCbzlwRbTy2MpfvfQTeE+0glU61/n66lmRkMQw4uqdySmBO2gTTIk/?= =?us-ascii?Q?hEoAapKX2TJgtuyhv2KFFsXTS3jx0xZKnpb+W1fGCzym32KjgeIThR3GbDwP?= =?us-ascii?Q?DwjU4zeiaoDk90cLk2fTTwv1U3PO2FdgXN45eSAorhOBHQVLDgz/gsERLgrw?= =?us-ascii?Q?UKom7/zQAMsLTnkU+Lqcbz0Bhd3PwvnTFnB03/EYVJIkkaZ6o8F0AqBov3as?= =?us-ascii?Q?uiPXgOZRnDjvD2s9QMuq00uTwQXLT+lV6Vi6mw847tqYgqRwjfz8+WPAgNVX?= =?us-ascii?Q?ITYANTqoY6jvb6jzPKCnWnQs0pJXsO7/3RoG6g9Yt3giLLy8D37maFreCsAF?= =?us-ascii?Q?A7ld/VcOq1SDeEoY6ElO0X3pZFdM9bfELW1v7TG7SHU5V6COvEpDd3rYgtD9?= =?us-ascii?Q?1KhsV94qKfE2zKqwd1o6fwa+0zW/la8gx5TltFUh7KElMBRvwhHd85e4/84S?= =?us-ascii?Q?QZmYbjOIQ3yMnEgPegZNP3z8X9LkjoLOcxO5JUeMOlCyJR+5wT5wjx76WCXa?= =?us-ascii?Q?v3zwN4KREMIGJgk0bt28J9WHfEyX6mRIAUm3TjNxRjcfFZCdQu6hAbr+tJ6W?= =?us-ascii?Q?QR+c3SMuNamai6THVNBXlBKrBQCL+qiHqGpjQllCjfjRNiR+fNM819fKB5te?= =?us-ascii?Q?1wmAZX+A03Tw7/s20f4Q1zqZOtXv7w/LZMlaV0vZpeP5adxIJYB/o65pBZ/S?= =?us-ascii?Q?ZGGTMyPvg7Y8P5afoTngf8pw96tljvpwxHriMbr8tW9p9nwZRnwCgS26f+bX?= =?us-ascii?Q?A5F1/Tz8lVWpwPWkuzD5VGndkPwVg64yF1OjdK9Dia9TFfgRhpGCqtKgFLhx?= =?us-ascii?Q?dpa5bNKUxOG42aa2PIrrg2qHmFG6OHCZQxVkWiWujY5SOPRJqL7tbsGsvXMU?= =?us-ascii?Q?6BQjAEDu90Y2QUBzQ8JAS73SGlomlCLc9hkwEHLE6p7TS5fun4H1Px+CoHnu?= =?us-ascii?Q?2fn+O+DzXf/8FAydsuuQABKA36ragxL1H547v5eFvSLP4EDuEawL/M5sRAn1?= =?us-ascii?Q?m5d+uh0uPNYpobJEhY9X3Fbv3g2gn5fJIFrdCkQ7cMNMGuUv1Irt6YEq6fBz?= =?us-ascii?Q?wM5lbXAkCBE/cVFBIJhngt3dllKDq+1/dyluD2iQL7+CfntSSmix5kGfztO/?= =?us-ascii?Q?H1JkO/da5SL5J2Q9roQZ3mrUasv/L7drAbBp+WPNh/F5qAcBgEzkJfUjJ1nk?= =?us-ascii?Q?4E9f29rqWji4ZXnhopMuixzKNKkW7fBEu0BLRiHJem6d1OqoxchE4LPwlDvO?= =?us-ascii?Q?pBtjOSVzL/JprWEr2hLiKZKNMFC6hLSNAV17+oRIrnQKgUg1gC/wTT0QGXdB?= =?us-ascii?Q?Pjr9cPJaVYOthfm5w7NWFV2oYIztl6YwliEmurrtlxr1Ftz65hPQRW3d8wG5?= =?us-ascii?Q?LANEYTW+CuL2/E76NlcDWWH7mKsDInLfTd/i4mLrd9IYaLvAY4k4j127qZ0y?= =?us-ascii?Q?RmfespkqjRGAUHBI4g8ysWzVbpoZLu4+DeXWNal2sbrDkY7OiGcLQ16U5ZcH?= =?us-ascii?Q?01zkSTQ4QELc5gMoDFR3ECiU/Fu6JdPTQQoibGs33DeW+9jdEM8Y2jQg4QQx?= =?us-ascii?Q?Ci0vP2Ajqhh0QLiRWCuwWjSiutDmnozhI8nnuJSL4xjCpymswTg9EGx4ibQl?= =?us-ascii?Q?W3/DgEh7EHUBFvm0UIUChjfmBh4sOPbDOu2HLfVZaQrDzR6KrT7nwn0LAStg?= =?us-ascii?Q?ey0P3FKnTd8Luv7YII+XVD+H40QRBV0LZM/60pIQhOH01yw40NzaojByGULt?= =?us-ascii?Q?t+dUHGWOQA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c3aeb99-e00b-44d0-cc1f-08da3eb8a786 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 01:40:03.3598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 64kup6Msg0HoQRhp3WyGVgiOgGgbAZnMfjqMvxxNmM6WzJN1NhlzuCzDEKx7DIMP X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5256 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 26, 2022 at 12:43:25AM +0000, Tian, Kevin wrote: > iiuc then this suggests there should be only one iommu group per atu, > instead of using generic_device_group() to create one group per > device. Sounds like it > > rejected then this driver should have a IOMMU_DOMAIN_BLOCKING and > > return that from ops->def_domain_type(). > > BLOCKING should not be used as a default domain type for DMA API > which needs either a DMA or IDENTITY type. New drivers should not have a NULL group->default_domain. IMHO this driver does not support the DMA API so the default_domain should be assigned to blocking and the DMA API disabled. We might need some core changes to accommodate this. The alternative would be to implement the identity domain, assuming the ATU thing can store that kind of translation. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47799C433EF for ; Thu, 26 May 2022 01:40:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id D9870410F3; Thu, 26 May 2022 01:40:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z6yZLjOu_TUq; Thu, 26 May 2022 01:40:09 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id C0DB6400A4; Thu, 26 May 2022 01:40:08 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 94731C0032; Thu, 26 May 2022 01:40:08 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3F127C002D for ; Thu, 26 May 2022 01:40:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3A37840347 for ; Thu, 26 May 2022 01:40:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AUZ2XaJvFpgj for ; Thu, 26 May 2022 01:40:05 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20610.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::610]) by smtp2.osuosl.org (Postfix) with ESMTPS id CCE3E400A4 for ; Thu, 26 May 2022 01:40:05 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QkomaV7CbOhAcjainTvxliPpZSHFQp4OpXLIOE9bZnLK9pt7a8AHDv+2wmdcPHzj90CtKGMmnIxtIgjSdp+/YWt2+PKK/BIm1c7IKgCWJXkHFWylbPeSmNSc261oS4w5hdhz8hnQkONv49aS0qG4911SFMTeGqZ5pOELp7/Sxf4aPa/HOTfK+/K7pP4lXdWph83Um11kpDr5MiVBrJ9GEgusv2t9svt+o3W5Y1NXu52fAuq+DxTEI9t23veR0/XXIMoD57tH50kl86DTTUClmpDoplL0+5S8Bjph8OBt2kxFKj55FzqDL/2m17tcwgTgd/mBCgOuvcB5VWbvhrgCfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PsOmawRqNbcPIBFzTVggIjeM2cLvhIgOZYMdfCRxcrg=; b=LxUUkXjeTXEE1NwGEN1vyjuUrZnCVBFL0KvEuJmy7CidGcTkA2EaCttfqa/e84ooIdN7QkHu99UhHcm0TEjaPfOaSKIis2mYsNJ6/NWFUbI8QR820mPRR/a6OLOrfT1ULg+XnJfg9yomA+bIWe7F0ELhEo2RPzP02s0XKL64H3eYzDrif6eAHg4IaYEULi4gsHEGQjumEZPkrnvXrABbTh9FkUTXhxYLVIHpM0PY0r1ZlwUQ7dtvXQfctH5prmllVAKqWxicJJTr9NLSnzcrlUdUQe78FKtHvPGGC0DUugAcaZ7DAApBR+y4M7cHIznkrKHazX3dCLL4kzcUGVKwJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PsOmawRqNbcPIBFzTVggIjeM2cLvhIgOZYMdfCRxcrg=; b=UWyh4QRxNNKIOKh7s9peha4cwLW6YOswLbNv44/tVCUr+dsrjNP2kW1qaqxKKPJ1/KQ1hl+P3i8ITqN++lwxQufx3A4oq6VYfMkfxTfeOKQw5LvRFBJqAHDktzcg48KM4DiEJtf8QsZXeOZu/q2Crd8BJ3hruSMcX0RRqt2fftyBGB6gN4F47u70RwTyTnwnQ7IK5eXYM5eWEmfNjYJwrJ7gmiKsemGrBEQpMSjfdJFgzIyr9QPNdtc/PQOeYJmUdvYiOuQAMAC4vvh2yRi0Arflv0TN4YQbS3DLRYMsNJ0e3aXfPdhbyU7sUBEnEZAr8qdlEHPu5SHru94rvwA8Iw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) by BL1PR12MB5256.namprd12.prod.outlook.com (2603:10b6:208:319::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 01:40:03 +0000 Received: from MN2PR12MB4192.namprd12.prod.outlook.com ([fe80::2484:51da:d56f:f1a5]) by MN2PR12MB4192.namprd12.prod.outlook.com ([fe80::2484:51da:d56f:f1a5%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 01:40:03 +0000 Date: Wed, 25 May 2022 22:40:00 -0300 To: "Tian, Kevin" Subject: Re: [PATCH 1/3] iommu: Add Visconti5 IOMMU driver Message-ID: <20220526014000.GJ1343366@nvidia.com> References: <20220525013147.2215355-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20220525013147.2215355-2-nobuhiro1.iwamatsu@toshiba.co.jp> <63369db0-cf7f-aa53-bf9f-de2b0b2289ac@linux.intel.com> <20220525182644.GF1343366@nvidia.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BL1PR13CA0065.namprd13.prod.outlook.com (2603:10b6:208:2b8::10) To MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c3aeb99-e00b-44d0-cc1f-08da3eb8a786 X-MS-TrafficTypeDiagnostic: BL1PR12MB5256:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hK9j97MoFANU1dtsTS5FXzxR4WaicMOSnxEzOtEPZ7adFRxvRzsl9FeimleXAvnWaewJuVin8yKf6xmtfiXSyf4p6XUsV2pujRiR78vCgaUYOFbuf7G/F6Kwz8H8o6gT0FpNUK9+EpbOPu+rsDpGoi/KAFqZi6xbBPfl/4RZUt6OMrkF/sW13D0+NRlQtOW2Mgz7Z0ajVUjl19fl5X/WI/XeZJMIMuuPwjgKjoepw9M3JnIN1tg4lQBHdJ1A2vbiHc+frRx3obXBXpan7TCsnjpTAE8rC58OOwU0cLb0OTcByMBhnGJRPfSSxlf7O7C4zygj/BKEXSD0gT2ActCIZmbgvxGMZuLvAs29T3qppQEoHJOIh/OswU77TPenE2MMa7sIc+BX+xLZlN00tBN0Rf0SGFIHIlODn9B6vMWbL/9IWSjDWRC5hj6X1qOIcH+ztRy9sCPX2nDNNgFe005vhtAgNTFDUuo/MjxndfBe+GcaqW5e4DkV7bE16Di9oyzTTUz/l5d/bh3utFGVoWS8YSDiJIW/aufm6C0+WymuJURxg+VB/ZAHuXIqBYkBF/83OJyqM5b8BFCnC5O5tbFsdvV++5n1KjWLuQiz4De0CukUZwVh0MsH5sXtfjY1ftIdQ2Fve1DYZzEZHdM65IMH7w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4192.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8676002)(4326008)(83380400001)(5660300002)(316002)(6916009)(54906003)(66946007)(66556008)(66476007)(86362001)(36756003)(6486002)(4744005)(508600001)(2616005)(1076003)(7416002)(38100700002)(8936002)(26005)(6506007)(6512007)(33656002)(2906002)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+E8tFhFCbzlwRbTy2MpfvfQTeE+0glU61/n66lmRkMQw4uqdySmBO2gTTIk/?= =?us-ascii?Q?hEoAapKX2TJgtuyhv2KFFsXTS3jx0xZKnpb+W1fGCzym32KjgeIThR3GbDwP?= =?us-ascii?Q?DwjU4zeiaoDk90cLk2fTTwv1U3PO2FdgXN45eSAorhOBHQVLDgz/gsERLgrw?= =?us-ascii?Q?UKom7/zQAMsLTnkU+Lqcbz0Bhd3PwvnTFnB03/EYVJIkkaZ6o8F0AqBov3as?= =?us-ascii?Q?uiPXgOZRnDjvD2s9QMuq00uTwQXLT+lV6Vi6mw847tqYgqRwjfz8+WPAgNVX?= =?us-ascii?Q?ITYANTqoY6jvb6jzPKCnWnQs0pJXsO7/3RoG6g9Yt3giLLy8D37maFreCsAF?= =?us-ascii?Q?A7ld/VcOq1SDeEoY6ElO0X3pZFdM9bfELW1v7TG7SHU5V6COvEpDd3rYgtD9?= =?us-ascii?Q?1KhsV94qKfE2zKqwd1o6fwa+0zW/la8gx5TltFUh7KElMBRvwhHd85e4/84S?= =?us-ascii?Q?QZmYbjOIQ3yMnEgPegZNP3z8X9LkjoLOcxO5JUeMOlCyJR+5wT5wjx76WCXa?= =?us-ascii?Q?v3zwN4KREMIGJgk0bt28J9WHfEyX6mRIAUm3TjNxRjcfFZCdQu6hAbr+tJ6W?= =?us-ascii?Q?QR+c3SMuNamai6THVNBXlBKrBQCL+qiHqGpjQllCjfjRNiR+fNM819fKB5te?= =?us-ascii?Q?1wmAZX+A03Tw7/s20f4Q1zqZOtXv7w/LZMlaV0vZpeP5adxIJYB/o65pBZ/S?= =?us-ascii?Q?ZGGTMyPvg7Y8P5afoTngf8pw96tljvpwxHriMbr8tW9p9nwZRnwCgS26f+bX?= =?us-ascii?Q?A5F1/Tz8lVWpwPWkuzD5VGndkPwVg64yF1OjdK9Dia9TFfgRhpGCqtKgFLhx?= =?us-ascii?Q?dpa5bNKUxOG42aa2PIrrg2qHmFG6OHCZQxVkWiWujY5SOPRJqL7tbsGsvXMU?= =?us-ascii?Q?6BQjAEDu90Y2QUBzQ8JAS73SGlomlCLc9hkwEHLE6p7TS5fun4H1Px+CoHnu?= =?us-ascii?Q?2fn+O+DzXf/8FAydsuuQABKA36ragxL1H547v5eFvSLP4EDuEawL/M5sRAn1?= =?us-ascii?Q?m5d+uh0uPNYpobJEhY9X3Fbv3g2gn5fJIFrdCkQ7cMNMGuUv1Irt6YEq6fBz?= =?us-ascii?Q?wM5lbXAkCBE/cVFBIJhngt3dllKDq+1/dyluD2iQL7+CfntSSmix5kGfztO/?= =?us-ascii?Q?H1JkO/da5SL5J2Q9roQZ3mrUasv/L7drAbBp+WPNh/F5qAcBgEzkJfUjJ1nk?= =?us-ascii?Q?4E9f29rqWji4ZXnhopMuixzKNKkW7fBEu0BLRiHJem6d1OqoxchE4LPwlDvO?= =?us-ascii?Q?pBtjOSVzL/JprWEr2hLiKZKNMFC6hLSNAV17+oRIrnQKgUg1gC/wTT0QGXdB?= =?us-ascii?Q?Pjr9cPJaVYOthfm5w7NWFV2oYIztl6YwliEmurrtlxr1Ftz65hPQRW3d8wG5?= =?us-ascii?Q?LANEYTW+CuL2/E76NlcDWWH7mKsDInLfTd/i4mLrd9IYaLvAY4k4j127qZ0y?= =?us-ascii?Q?RmfespkqjRGAUHBI4g8ysWzVbpoZLu4+DeXWNal2sbrDkY7OiGcLQ16U5ZcH?= =?us-ascii?Q?01zkSTQ4QELc5gMoDFR3ECiU/Fu6JdPTQQoibGs33DeW+9jdEM8Y2jQg4QQx?= =?us-ascii?Q?Ci0vP2Ajqhh0QLiRWCuwWjSiutDmnozhI8nnuJSL4xjCpymswTg9EGx4ibQl?= =?us-ascii?Q?W3/DgEh7EHUBFvm0UIUChjfmBh4sOPbDOu2HLfVZaQrDzR6KrT7nwn0LAStg?= =?us-ascii?Q?ey0P3FKnTd8Luv7YII+XVD+H40QRBV0LZM/60pIQhOH01yw40NzaojByGULt?= =?us-ascii?Q?t+dUHGWOQA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c3aeb99-e00b-44d0-cc1f-08da3eb8a786 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 01:40:03.3598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 64kup6Msg0HoQRhp3WyGVgiOgGgbAZnMfjqMvxxNmM6WzJN1NhlzuCzDEKx7DIMP X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5256 Cc: "devicetree@vger.kernel.org" , Will Deacon , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Rob Herring , Nobuhiro Iwamatsu , "yuji2.ishikawa@toshiba.co.jp" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Jason Gunthorpe via iommu Reply-To: Jason Gunthorpe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, May 26, 2022 at 12:43:25AM +0000, Tian, Kevin wrote: > iiuc then this suggests there should be only one iommu group per atu, > instead of using generic_device_group() to create one group per > device. Sounds like it > > rejected then this driver should have a IOMMU_DOMAIN_BLOCKING and > > return that from ops->def_domain_type(). > > BLOCKING should not be used as a default domain type for DMA API > which needs either a DMA or IDENTITY type. New drivers should not have a NULL group->default_domain. IMHO this driver does not support the DMA API so the default_domain should be assigned to blocking and the DMA API disabled. We might need some core changes to accommodate this. The alternative would be to implement the identity domain, assuming the ATU thing can store that kind of translation. Jason _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2324C433F5 for ; Thu, 26 May 2022 01:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NGr1ag7OEXDhpiMTGA0LqWwKwBiDevBUDxbzmy7YSYQ=; b=bgzl+UfsvWW0am tfpZvgf5+uBoQJu4QcxIF6KMouSUAnIMhzQT+QtLyUQzbBtppmv2gUkX7a+zcgxsHLTPNEVAA4o3b soDKjnpz8MMvjtqQmgc18ZxFJbk86kvJmzNx4tkjglafbrr6PeXLWR7cE+01uq9zz7pABPoR1cV7d OSQNhKlEX+bCpkJPnoM3Kujdo6HtFRuA4Z7F7Ss9TAufAwrcPKz57kMX3MVT/8Hyp0bZVoreohZtm XLo5gfTZ+cc7vge5GHVVxJNajkwWKAqtKAQPEC5Fy3u9ybBNa9o+OzPOwjdZZLZg0RAhcJG1t4HfQ vPmcYyFJ3U9O1/rOX2sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu2jJ-00DEiq-N5; Thu, 26 May 2022 01:56:01 +0000 Received: from mail-bn8nam12on20617.outbound.protection.outlook.com ([2a01:111:f400:fe5b::617] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nu2jG-00DEi6-HP for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 01:55:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QkomaV7CbOhAcjainTvxliPpZSHFQp4OpXLIOE9bZnLK9pt7a8AHDv+2wmdcPHzj90CtKGMmnIxtIgjSdp+/YWt2+PKK/BIm1c7IKgCWJXkHFWylbPeSmNSc261oS4w5hdhz8hnQkONv49aS0qG4911SFMTeGqZ5pOELp7/Sxf4aPa/HOTfK+/K7pP4lXdWph83Um11kpDr5MiVBrJ9GEgusv2t9svt+o3W5Y1NXu52fAuq+DxTEI9t23veR0/XXIMoD57tH50kl86DTTUClmpDoplL0+5S8Bjph8OBt2kxFKj55FzqDL/2m17tcwgTgd/mBCgOuvcB5VWbvhrgCfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PsOmawRqNbcPIBFzTVggIjeM2cLvhIgOZYMdfCRxcrg=; b=LxUUkXjeTXEE1NwGEN1vyjuUrZnCVBFL0KvEuJmy7CidGcTkA2EaCttfqa/e84ooIdN7QkHu99UhHcm0TEjaPfOaSKIis2mYsNJ6/NWFUbI8QR820mPRR/a6OLOrfT1ULg+XnJfg9yomA+bIWe7F0ELhEo2RPzP02s0XKL64H3eYzDrif6eAHg4IaYEULi4gsHEGQjumEZPkrnvXrABbTh9FkUTXhxYLVIHpM0PY0r1ZlwUQ7dtvXQfctH5prmllVAKqWxicJJTr9NLSnzcrlUdUQe78FKtHvPGGC0DUugAcaZ7DAApBR+y4M7cHIznkrKHazX3dCLL4kzcUGVKwJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PsOmawRqNbcPIBFzTVggIjeM2cLvhIgOZYMdfCRxcrg=; b=UWyh4QRxNNKIOKh7s9peha4cwLW6YOswLbNv44/tVCUr+dsrjNP2kW1qaqxKKPJ1/KQ1hl+P3i8ITqN++lwxQufx3A4oq6VYfMkfxTfeOKQw5LvRFBJqAHDktzcg48KM4DiEJtf8QsZXeOZu/q2Crd8BJ3hruSMcX0RRqt2fftyBGB6gN4F47u70RwTyTnwnQ7IK5eXYM5eWEmfNjYJwrJ7gmiKsemGrBEQpMSjfdJFgzIyr9QPNdtc/PQOeYJmUdvYiOuQAMAC4vvh2yRi0Arflv0TN4YQbS3DLRYMsNJ0e3aXfPdhbyU7sUBEnEZAr8qdlEHPu5SHru94rvwA8Iw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) by BL1PR12MB5256.namprd12.prod.outlook.com (2603:10b6:208:319::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 01:40:03 +0000 Received: from MN2PR12MB4192.namprd12.prod.outlook.com ([fe80::2484:51da:d56f:f1a5]) by MN2PR12MB4192.namprd12.prod.outlook.com ([fe80::2484:51da:d56f:f1a5%7]) with mapi id 15.20.5293.013; Thu, 26 May 2022 01:40:03 +0000 Date: Wed, 25 May 2022 22:40:00 -0300 From: Jason Gunthorpe To: "Tian, Kevin" Cc: Baolu Lu , "devicetree@vger.kernel.org" , "yuji2.ishikawa@toshiba.co.jp" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Rob Herring , Nobuhiro Iwamatsu , Will Deacon , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/3] iommu: Add Visconti5 IOMMU driver Message-ID: <20220526014000.GJ1343366@nvidia.com> References: <20220525013147.2215355-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20220525013147.2215355-2-nobuhiro1.iwamatsu@toshiba.co.jp> <63369db0-cf7f-aa53-bf9f-de2b0b2289ac@linux.intel.com> <20220525182644.GF1343366@nvidia.com> Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BL1PR13CA0065.namprd13.prod.outlook.com (2603:10b6:208:2b8::10) To MN2PR12MB4192.namprd12.prod.outlook.com (2603:10b6:208:1d5::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c3aeb99-e00b-44d0-cc1f-08da3eb8a786 X-MS-TrafficTypeDiagnostic: BL1PR12MB5256:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hK9j97MoFANU1dtsTS5FXzxR4WaicMOSnxEzOtEPZ7adFRxvRzsl9FeimleXAvnWaewJuVin8yKf6xmtfiXSyf4p6XUsV2pujRiR78vCgaUYOFbuf7G/F6Kwz8H8o6gT0FpNUK9+EpbOPu+rsDpGoi/KAFqZi6xbBPfl/4RZUt6OMrkF/sW13D0+NRlQtOW2Mgz7Z0ajVUjl19fl5X/WI/XeZJMIMuuPwjgKjoepw9M3JnIN1tg4lQBHdJ1A2vbiHc+frRx3obXBXpan7TCsnjpTAE8rC58OOwU0cLb0OTcByMBhnGJRPfSSxlf7O7C4zygj/BKEXSD0gT2ActCIZmbgvxGMZuLvAs29T3qppQEoHJOIh/OswU77TPenE2MMa7sIc+BX+xLZlN00tBN0Rf0SGFIHIlODn9B6vMWbL/9IWSjDWRC5hj6X1qOIcH+ztRy9sCPX2nDNNgFe005vhtAgNTFDUuo/MjxndfBe+GcaqW5e4DkV7bE16Di9oyzTTUz/l5d/bh3utFGVoWS8YSDiJIW/aufm6C0+WymuJURxg+VB/ZAHuXIqBYkBF/83OJyqM5b8BFCnC5O5tbFsdvV++5n1KjWLuQiz4De0CukUZwVh0MsH5sXtfjY1ftIdQ2Fve1DYZzEZHdM65IMH7w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB4192.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(8676002)(4326008)(83380400001)(5660300002)(316002)(6916009)(54906003)(66946007)(66556008)(66476007)(86362001)(36756003)(6486002)(4744005)(508600001)(2616005)(1076003)(7416002)(38100700002)(8936002)(26005)(6506007)(6512007)(33656002)(2906002)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+E8tFhFCbzlwRbTy2MpfvfQTeE+0glU61/n66lmRkMQw4uqdySmBO2gTTIk/?= =?us-ascii?Q?hEoAapKX2TJgtuyhv2KFFsXTS3jx0xZKnpb+W1fGCzym32KjgeIThR3GbDwP?= =?us-ascii?Q?DwjU4zeiaoDk90cLk2fTTwv1U3PO2FdgXN45eSAorhOBHQVLDgz/gsERLgrw?= =?us-ascii?Q?UKom7/zQAMsLTnkU+Lqcbz0Bhd3PwvnTFnB03/EYVJIkkaZ6o8F0AqBov3as?= =?us-ascii?Q?uiPXgOZRnDjvD2s9QMuq00uTwQXLT+lV6Vi6mw847tqYgqRwjfz8+WPAgNVX?= =?us-ascii?Q?ITYANTqoY6jvb6jzPKCnWnQs0pJXsO7/3RoG6g9Yt3giLLy8D37maFreCsAF?= =?us-ascii?Q?A7ld/VcOq1SDeEoY6ElO0X3pZFdM9bfELW1v7TG7SHU5V6COvEpDd3rYgtD9?= =?us-ascii?Q?1KhsV94qKfE2zKqwd1o6fwa+0zW/la8gx5TltFUh7KElMBRvwhHd85e4/84S?= =?us-ascii?Q?QZmYbjOIQ3yMnEgPegZNP3z8X9LkjoLOcxO5JUeMOlCyJR+5wT5wjx76WCXa?= =?us-ascii?Q?v3zwN4KREMIGJgk0bt28J9WHfEyX6mRIAUm3TjNxRjcfFZCdQu6hAbr+tJ6W?= =?us-ascii?Q?QR+c3SMuNamai6THVNBXlBKrBQCL+qiHqGpjQllCjfjRNiR+fNM819fKB5te?= =?us-ascii?Q?1wmAZX+A03Tw7/s20f4Q1zqZOtXv7w/LZMlaV0vZpeP5adxIJYB/o65pBZ/S?= =?us-ascii?Q?ZGGTMyPvg7Y8P5afoTngf8pw96tljvpwxHriMbr8tW9p9nwZRnwCgS26f+bX?= =?us-ascii?Q?A5F1/Tz8lVWpwPWkuzD5VGndkPwVg64yF1OjdK9Dia9TFfgRhpGCqtKgFLhx?= =?us-ascii?Q?dpa5bNKUxOG42aa2PIrrg2qHmFG6OHCZQxVkWiWujY5SOPRJqL7tbsGsvXMU?= =?us-ascii?Q?6BQjAEDu90Y2QUBzQ8JAS73SGlomlCLc9hkwEHLE6p7TS5fun4H1Px+CoHnu?= =?us-ascii?Q?2fn+O+DzXf/8FAydsuuQABKA36ragxL1H547v5eFvSLP4EDuEawL/M5sRAn1?= =?us-ascii?Q?m5d+uh0uPNYpobJEhY9X3Fbv3g2gn5fJIFrdCkQ7cMNMGuUv1Irt6YEq6fBz?= =?us-ascii?Q?wM5lbXAkCBE/cVFBIJhngt3dllKDq+1/dyluD2iQL7+CfntSSmix5kGfztO/?= =?us-ascii?Q?H1JkO/da5SL5J2Q9roQZ3mrUasv/L7drAbBp+WPNh/F5qAcBgEzkJfUjJ1nk?= =?us-ascii?Q?4E9f29rqWji4ZXnhopMuixzKNKkW7fBEu0BLRiHJem6d1OqoxchE4LPwlDvO?= =?us-ascii?Q?pBtjOSVzL/JprWEr2hLiKZKNMFC6hLSNAV17+oRIrnQKgUg1gC/wTT0QGXdB?= =?us-ascii?Q?Pjr9cPJaVYOthfm5w7NWFV2oYIztl6YwliEmurrtlxr1Ftz65hPQRW3d8wG5?= =?us-ascii?Q?LANEYTW+CuL2/E76NlcDWWH7mKsDInLfTd/i4mLrd9IYaLvAY4k4j127qZ0y?= =?us-ascii?Q?RmfespkqjRGAUHBI4g8ysWzVbpoZLu4+DeXWNal2sbrDkY7OiGcLQ16U5ZcH?= =?us-ascii?Q?01zkSTQ4QELc5gMoDFR3ECiU/Fu6JdPTQQoibGs33DeW+9jdEM8Y2jQg4QQx?= =?us-ascii?Q?Ci0vP2Ajqhh0QLiRWCuwWjSiutDmnozhI8nnuJSL4xjCpymswTg9EGx4ibQl?= =?us-ascii?Q?W3/DgEh7EHUBFvm0UIUChjfmBh4sOPbDOu2HLfVZaQrDzR6KrT7nwn0LAStg?= =?us-ascii?Q?ey0P3FKnTd8Luv7YII+XVD+H40QRBV0LZM/60pIQhOH01yw40NzaojByGULt?= =?us-ascii?Q?t+dUHGWOQA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c3aeb99-e00b-44d0-cc1f-08da3eb8a786 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 01:40:03.3598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 64kup6Msg0HoQRhp3WyGVgiOgGgbAZnMfjqMvxxNmM6WzJN1NhlzuCzDEKx7DIMP X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5256 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220525_185558_618483_D4FC8F18 X-CRM114-Status: GOOD ( 13.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 26, 2022 at 12:43:25AM +0000, Tian, Kevin wrote: > iiuc then this suggests there should be only one iommu group per atu, > instead of using generic_device_group() to create one group per > device. Sounds like it > > rejected then this driver should have a IOMMU_DOMAIN_BLOCKING and > > return that from ops->def_domain_type(). > > BLOCKING should not be used as a default domain type for DMA API > which needs either a DMA or IDENTITY type. New drivers should not have a NULL group->default_domain. IMHO this driver does not support the DMA API so the default_domain should be assigned to blocking and the DMA API disabled. We might need some core changes to accommodate this. The alternative would be to implement the identity domain, assuming the ATU thing can store that kind of translation. Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel