From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 807A1C433F5 for ; Thu, 26 May 2022 08:32:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2F56C8432A; Thu, 26 May 2022 10:32:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="F6hDVrNf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9C10B84320; Thu, 26 May 2022 10:32:18 +0200 (CEST) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AC2B883EFE for ; Thu, 26 May 2022 10:32:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id C3B0BCE210E; Thu, 26 May 2022 08:32:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B52EC385A9; Thu, 26 May 2022 08:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653553930; bh=b86HURHy6mRnRAk1A9YM3htMZYFCczws4QpUC34AX/s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F6hDVrNfrekAshflCyMliTfw8rI4Hz8eNcIKX1L3zLyKajg5Sw6ictH0lKTbWtG3H mWWjk8vWqS4OXBxYLzUQP8IsfJBwEKBXfjUk+bZ3z1dUcbboe/b75tiZSpHR+Vxr2e aKDWt4oSTjKzoazoyLRTF7UWozekZfY8AJkHQYvzr4SDvnuwXr4rpCKD9MGIypbV/g X+SRzwxCrO0vxthp/ijNmWFKJl3GElm/38mcwy/FQicCVU35e/XYTIXy6HIpO5PoDG PoMi20h0i25QJKWDTnM8hl9aaFglypDMLdOLZEfOvyUzHS3qCCjkvvrNWSV7R1TQDS kVPctibY0tyRg== Received: by pali.im (Postfix) id C33D24F8; Thu, 26 May 2022 10:32:06 +0200 (CEST) Date: Thu, 26 May 2022 10:32:06 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: "Priyanka Jain (OSS)" Cc: Qiang Zhao , Shengzhou Liu , Sinan Akman , "u-boot@lists.denx.de" Subject: Re: [PATCH v2] board: freescale: p1_p2_rdb_pc: Move boot reset macros to p1_p2_bootsrc.h Message-ID: <20220526083206.wdl4gxorlpwbuk5m@pali> References: <20220407101624.15850-11-pali@kernel.org> <20220425144823.9831-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thursday 26 May 2022 06:08:04 Priyanka Jain (OSS) wrote: > >-----Original Message----- > >From: U-Boot On Behalf Of Pali Rohár > >Sent: Monday, April 25, 2022 8:18 PM > >To: Priyanka Jain ; Qiang Zhao ; > >Shengzhou Liu ; Sinan Akman > >Cc: u-boot@lists.denx.de > >Subject: [PATCH v2] board: freescale: p1_p2_rdb_pc: Move boot reset macros to > >p1_p2_bootsrc.h > > > >Code for changing boot source is platform generic and can be used by any > >P1* and P2* compatible RDB board. Not only by boards which use config header > >file p1_p2_rdb_pc.h. > > > >So move this code from p1_p2_rdb_pc.h to p1_p2_bootsrc.h and cleanup macros > >for generating boot source env variables in CONFIG_EXTRA_ENV_SETTINGS. > > > >This allows to use code for resetting board and rebooting to other boot source > >also by other boards in future. > > > >Signed-off-by: Pali Rohár > >--- > >Changes in v2: > >* Fix commit message > >* Move macros to file p1_p2_bootsrc.h > >* Rewrite macros even more to be more generic and use them without custom > > macros in p1_p2_rdb_pc.h > >--- > > include/configs/p1_p2_bootsrc.h | 55 +++++++++++++++++++++++++++++++++ > >include/configs/p1_p2_rdb_pc.h | 41 ++++++------------------ > > 2 files changed, 64 insertions(+), 32 deletions(-) create mode 100644 > >include/configs/p1_p2_bootsrc.h > > > >diff --git a/include/configs/p1_p2_bootsrc.h b/include/configs/p1_p2_bootsrc.h > >new file mode 100644 index 000000000000..a274c57786f5 > >--- /dev/null > >+++ b/include/configs/p1_p2_bootsrc.h > >@@ -0,0 +1,55 @@ > >+// SPDX-License-Identifier: GPL-2.0+ > >+// (C) 2022 Pali Rohár > >+ > Code is copied from one file to another. Please don’t remove original copyright I rewritten all those macros from scratch during moving and I therefore I have thought about copyright header (I just put default one here). But I can copy+paste copyright header from old file, no problem. > > > Regards > Priyanka