From: Peter Zijlstra <peterz@infradead.org>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
vschneid@redhat.com, kernel-team@android.com,
Derek Dolney <z23@posteo.net>
Subject: Re: [PATCH v2] cpu/hotplug: Do not bail-out in DYING/STARTING sections
Date: Thu, 26 May 2022 12:15:36 +0200 [thread overview]
Message-ID: <20220526101536.GP2578@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <Yo85PLANCnCcMgvD@google.com>
On Thu, May 26, 2022 at 09:24:28AM +0100, Vincent Donnefort wrote:
> On Wed, May 25, 2022 at 06:52:48PM +0200, Peter Zijlstra wrote:
> > On Mon, May 23, 2022 at 05:05:36PM +0100, Vincent Donnefort wrote:
> > > The DYING/STARTING callbacks are not expected to fail. However, as reported
> > > by Derek, drivers such as tboot are still free to return errors within
> > > those sections. In that case, there's nothing the hotplug machinery can do,
> > > so let's just proceed and log the failures.
> > >
> >
> > I'm confused. Why isn't this a driver bug?
>
> It is a entirely a driver bug which has been reported already. but 453e41085183
> (cpu/hotplug: Add cpuhp_invoke_callback_range()) changed the behaviour so I
> thought it would be worth to revert to the original one which is to not break
> the entire up/down for a single driver error.
Ah I see. Fair enough I suppose.
next prev parent reply other threads:[~2022-05-26 10:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 16:05 [PATCH v2] cpu/hotplug: Do not bail-out in DYING/STARTING sections Vincent Donnefort
2022-05-25 16:52 ` Peter Zijlstra
2022-05-26 8:24 ` Vincent Donnefort
2022-05-26 10:15 ` Peter Zijlstra [this message]
2022-05-29 18:01 ` Derek Dolney
2022-05-26 11:48 ` Derek Dolney
2022-05-26 12:27 ` Derek Dolney
2022-06-13 12:36 ` Thomas Gleixner
2022-06-13 13:37 ` Vincent Donnefort
2022-07-04 10:01 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220526101536.GP2578@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vdonnefort@google.com \
--cc=vschneid@redhat.com \
--cc=z23@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.