From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CD2CC433F5 for ; Thu, 26 May 2022 19:24:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id B54E9C34116; Thu, 26 May 2022 19:24:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8ECAAC385A9; Thu, 26 May 2022 19:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653593052; bh=/lByU2XT//2hgm1wryTBQF92iMF6iHi5yygjAKhmCgM=; h=In-Reply-To:References:Subject:From:List-Id:Cc:To:Date:From; b=hxiGMM8dBcCYcqqtYgqZKK6bbmGgMrK1FF05cXVJAFAu2415wRbsiM+ixRpIzxt/c an7l1ZCdy9ljiZBdfF9z8vqPrFsIyHVVl5A0u0zsCehorPxqYftZwpb1Jdvmps6uzC AJB7uS2OyIj5aSNJ3ZzsBhUPnARsPTw8rHZyJVqZVaCoef3pppsw54L8bov69n1tjB qG9srSMTs+uTTZUj5CgKF3zeq3WkjGWuIfDACQ6Cpi/Gy/Di+EGSeoDalkYCLp2XOS 2ELXT+bCECHsu//E/7Cu2MLsgTDO4OQ45jKLNNtfbHXtekDC1y0tibP6G8PzSSJdaG p9lIAUwAqz+ag== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220522155046.260146-8-tmaimon77@gmail.com> References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-8-tmaimon77@gmail.com> Subject: Re: [PATCH v1 07/19] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock From: Stephen Boyd List-Id: Cc: soc@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tomer Maimon To: Tomer Maimon , arnd@arndb.de, avifishman70@gmail.com, benjaminfair@google.com, biju.das.jz@bp.renesas.com, bjorn.andersson@linaro.org, catalin.marinas@arm.com, daniel.lezcano@linaro.org, geert+renesas@glider.be, gregkh@linuxfoundation.org, j.neuschaefer@gmx.net, jirislaby@kernel.org, joel@jms.id.au, krzysztof.kozlowski+dt@linaro.org, linux@roeck-us.net, lkundrak@v3.sk, marcel.ziswiler@toradex.com, mturquette@baylibre.com, nobuhiro1.iwamatsu@toshiba.co.jp, olof@lixom.net, p.zabel@pengutronix.de, robert.hancock@calian.com, robh+dt@kernel.org, shawnguo@kernel.org, tali.perry1@gmail.com, tglx@linutronix.de, venture@google.com, vkoul@kernel.org, will@kernel.org, wim@linux-watchdog.org, yuenn@google.com Date: Thu, 26 May 2022 12:24:10 -0700 User-Agent: alot/0.10 Message-Id: <20220526192412.8ECAAC385A9@smtp.kernel.org> Quoting Tomer Maimon (2022-05-22 08:50:34) > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.= yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > new file mode 100644 > index 000000000000..f305c7c7eaf0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > @@ -0,0 +1,68 @@ [...] > + > +required: > + - compatible > + - reg > + - "#clock-cells" Are clocks not required because sometimes the reference clk isn't connected? > + > +additionalProperties: false > + > +examples: > + # Clock Control Module node: > + - | > + > + ahb { drop ahb node please. > + #address-cells =3D <2>; > + #size-cells =3D <2>; > + > + clk: clock-controller@f0801000 { Drop label 'clk' as well please. > + compatible =3D "nuvoton,npcm845-clk"; > + reg =3D <0x0 0xf0801000 0x0 0x1000>; > + #clock-cells =3D <1>; > + }; > + }; > + > +... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB4F2C433F5 for ; Thu, 26 May 2022 19:25:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RToaF3Vwbw7QDyvASmrERoCMAwArhIm5Yu/jfIKeDLE=; b=NLiNnA7ZF1HIAk mTLvPSN9h7o+Q/FAEhjAVIweFhInzERLLcXIOXFBLXnDtuiZG3xZdDwa8YmNCIGTJ985JXHYdoYbr eorTNJuMwJnJkX+reWAP+K72STrFRQ1xrjuSDgNaFhabVRVoVUSs+NOH+cAiPn0ekbMV9fAdC5oBR 9rbLU8FVN7a/L4t8mAeLVWZ7EtHcAlw/zAvA/l9xgIG3gcFDBo2NjM6a6Q1Luuon8sVXTuJPf2cw8 wbkNKi/+fwqNzgUTOldoH7UNrmLaxsy8HAW0y8ISpKbrLnj/kQ0T15R+ePKazstQHUDUu8hSfo+xs m+QSBbyHdx7sL/iZgNcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuJ5m-00FhCT-7u; Thu, 26 May 2022 19:24:18 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuJ5j-00FhC7-8D for linux-arm-kernel@lists.infradead.org; Thu, 26 May 2022 19:24:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EC73BB82202; Thu, 26 May 2022 19:24:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8ECAAC385A9; Thu, 26 May 2022 19:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653593052; bh=/lByU2XT//2hgm1wryTBQF92iMF6iHi5yygjAKhmCgM=; h=In-Reply-To:References:Subject:From:List-Id:Cc:To:Date:From; b=hxiGMM8dBcCYcqqtYgqZKK6bbmGgMrK1FF05cXVJAFAu2415wRbsiM+ixRpIzxt/c an7l1ZCdy9ljiZBdfF9z8vqPrFsIyHVVl5A0u0zsCehorPxqYftZwpb1Jdvmps6uzC AJB7uS2OyIj5aSNJ3ZzsBhUPnARsPTw8rHZyJVqZVaCoef3pppsw54L8bov69n1tjB qG9srSMTs+uTTZUj5CgKF3zeq3WkjGWuIfDACQ6Cpi/Gy/Di+EGSeoDalkYCLp2XOS 2ELXT+bCECHsu//E/7Cu2MLsgTDO4OQ45jKLNNtfbHXtekDC1y0tibP6G8PzSSJdaG p9lIAUwAqz+ag== MIME-Version: 1.0 In-Reply-To: <20220522155046.260146-8-tmaimon77@gmail.com> References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-8-tmaimon77@gmail.com> Subject: Re: [PATCH v1 07/19] dt-binding: clk: npcm845: Add binding for Nuvoton NPCM8XX Clock From: Stephen Boyd Cc: soc@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tomer Maimon To: Tomer Maimon , arnd@arndb.de, avifishman70@gmail.com, benjaminfair@google.com, biju.das.jz@bp.renesas.com, bjorn.andersson@linaro.org, catalin.marinas@arm.com, daniel.lezcano@linaro.org, geert+renesas@glider.be, gregkh@linuxfoundation.org, j.neuschaefer@gmx.net, jirislaby@kernel.org, joel@jms.id.au, krzysztof.kozlowski+dt@linaro.org, linux@roeck-us.net, lkundrak@v3.sk, marcel.ziswiler@toradex.com, mturquette@baylibre.com, nobuhiro1.iwamatsu@toshiba.co.jp, olof@lixom.net, p.zabel@pengutronix.de, robert.hancock@calian.com, robh+dt@kernel.org, shawnguo@kernel.org, tali.perry1@gmail.com, tglx@linutronix.de, venture@google.com, vkoul@kernel.org, will@kernel.org, wim@linux-watchdog.org, yuenn@google.com Date: Thu, 26 May 2022 12:24:10 -0700 User-Agent: alot/0.10 Message-Id: <20220526192412.8ECAAC385A9@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_122415_475694_73E2BB68 X-CRM114-Status: GOOD ( 10.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Tomer Maimon (2022-05-22 08:50:34) > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > new file mode 100644 > index 000000000000..f305c7c7eaf0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > @@ -0,0 +1,68 @@ [...] > + > +required: > + - compatible > + - reg > + - "#clock-cells" Are clocks not required because sometimes the reference clk isn't connected? > + > +additionalProperties: false > + > +examples: > + # Clock Control Module node: > + - | > + > + ahb { drop ahb node please. > + #address-cells = <2>; > + #size-cells = <2>; > + > + clk: clock-controller@f0801000 { Drop label 'clk' as well please. > + compatible = "nuvoton,npcm845-clk"; > + reg = <0x0 0xf0801000 0x0 0x1000>; > + #clock-cells = <1>; > + }; > + }; > + > +... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel