From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D846C433EF for ; Thu, 26 May 2022 20:27:04 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E4D4427EC; Thu, 26 May 2022 22:27:02 +0200 (CEST) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by mails.dpdk.org (Postfix) with ESMTP id 71FD140DF7 for ; Thu, 26 May 2022 22:26:58 +0200 (CEST) Received: by mail-pf1-f172.google.com with SMTP id x143so2581041pfc.11 for ; Thu, 26 May 2022 13:26:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HeE7fHxqMA863zxLIscJSWOqklG7gOFE2iJ5Kfe2h7s=; b=4P2it92/N4pJQZnWLrp5dwqD6XE+OAUCqZVgrntkR3sreIt/0ljQY3A3Yp72zhditn 60NXOrHDKfLKr19oSFkKUm44dF6/XuMWXcn2Il8tSRBiZkGbYtIMSSCDKwZT+ZXRpR7E RbK4dZ4L3WmiWnemPdgZyJr8wqKhqB7cX0U90w7XLf1+wWHdN28erClnKtwTCulfLxkm 2XhQk5bd2PsfKYkCmvDGmPdPQLcGPs/DfcbiT/rAad2OZiQ/PNQPx33Vuhf9FS3JYn+B afy3Pa1l+k+4bkIDAtgJZU53K3GUlL1E/569vLtfU6K8nIqkRpKxNsxUL5DFbZ4ANPVH COWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HeE7fHxqMA863zxLIscJSWOqklG7gOFE2iJ5Kfe2h7s=; b=eeqWNFWsw0jBEwFgkUnizOZ1ARRfk2J9PMT0Wj2YoDwzVLug6B2RSBDQeuwAHmJAL/ lcZa3riD5wTMX/v/5ftyDGAfLN/YzNmbKa4RNmEK3Iv+8+e6AASHVS9IXL+c1grQQbxb 0cNiQgr7jz3F05k8d0zM+Dpc1KLcH2WRlVrSGO7AdRPKLoqspJnsVmEYX7MRrs6jvWDX fcxmrUkQs8K659x+HxS5Jc4u1EhYx+Z6sV04l6md8+SfqmXZb4aDHkF361EcZpin+03K vbWjhRVAoTF6SZweMhFRFnGgHkcDM6kfaNN5cqVGSDL6ZNjkGEZ5iyoLQ87v7CnFQYzP 3XNA== X-Gm-Message-State: AOAM530uFjKGojGtSZJnhe8gS4u8wBywIOhc3X1Y5D4EM2lN9vzuyeQo CgoS3zI5TZydUmOmMIfbjhqhEc9NQG8cjA== X-Google-Smtp-Source: ABdhPJx6qeJEd5px6XHwgN3l8S7yeF44/xq28wpu1k1q6w7MZYnCtWpUwRlRhw9Vqj/NJlGr4K51vQ== X-Received: by 2002:a63:4d2:0:b0:3fa:b0a0:450e with SMTP id 201-20020a6304d2000000b003fab0a0450emr12380899pge.95.1653596817309; Thu, 26 May 2022 13:26:57 -0700 (PDT) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id c20-20020a170902b69400b0015e8d4eb1e5sm2025316pls.47.2022.05.26.13.26.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 May 2022 13:26:56 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ray Kinsella , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= , Ray Kinsella Subject: [PATCH v5 1/3] random: add rte_drand() function Date: Thu, 26 May 2022 13:26:51 -0700 Message-Id: <20220526202653.99796-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220526202653.99796-1-stephen@networkplumber.org> References: <20220524184623.480646-1-stephen@networkplumber.org> <20220526202653.99796-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The PIE code and other applications can benefit from having a fast way to get a random floating point value. This new function is equivalent to drand() in the standard library. Signed-off-by: Stephen Hemminger Acked-by: Ray Kinsella --- app/test/test_rand_perf.c | 7 +++++++ doc/guides/rel_notes/release_22_07.rst | 5 +++++ lib/eal/common/rte_random.c | 19 +++++++++++++++++++ lib/eal/include/rte_random.h | 18 ++++++++++++++++++ lib/eal/version.map | 1 + 5 files changed, 50 insertions(+) diff --git a/app/test/test_rand_perf.c b/app/test/test_rand_perf.c index fe797ebfa1ca..26fb1d9a586e 100644 --- a/app/test/test_rand_perf.c +++ b/app/test/test_rand_perf.c @@ -20,6 +20,7 @@ static volatile uint64_t vsum; enum rand_type { rand_type_64, + rand_type_float, rand_type_bounded_best_case, rand_type_bounded_worst_case }; @@ -30,6 +31,8 @@ rand_type_desc(enum rand_type rand_type) switch (rand_type) { case rand_type_64: return "Full 64-bit [rte_rand()]"; + case rand_type_float: + return "Floating point [rte_drand()]"; case rand_type_bounded_best_case: return "Bounded average best-case [rte_rand_max()]"; case rand_type_bounded_worst_case: @@ -55,6 +58,9 @@ test_rand_perf_type(enum rand_type rand_type) case rand_type_64: sum += rte_rand(); break; + case rand_type_float: + sum += 1000. * rte_drand(); + break; case rand_type_bounded_best_case: sum += rte_rand_max(BEST_CASE_BOUND); break; @@ -83,6 +89,7 @@ test_rand_perf(void) printf("Pseudo-random number generation latencies:\n"); test_rand_perf_type(rand_type_64); + test_rand_perf_type(rand_type_float); test_rand_perf_type(rand_type_bounded_best_case); test_rand_perf_type(rand_type_bounded_worst_case); diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst index e49cacecefd4..b131ea577226 100644 --- a/doc/guides/rel_notes/release_22_07.rst +++ b/doc/guides/rel_notes/release_22_07.rst @@ -104,6 +104,11 @@ New Features * ``RTE_EVENT_QUEUE_ATTR_WEIGHT`` * ``RTE_EVENT_QUEUE_ATTR_AFFINITY`` +* ** Added function get random floating point number.** + + Added the function ``rte_drand()`` to provide a pseudo-random + floating point number. + Removed Items ------------- diff --git a/lib/eal/common/rte_random.c b/lib/eal/common/rte_random.c index 4535cc980cec..166b0d8921c9 100644 --- a/lib/eal/common/rte_random.c +++ b/lib/eal/common/rte_random.c @@ -173,6 +173,25 @@ rte_rand_max(uint64_t upper_bound) return res; } +double +rte_drand(void) +{ + static const uint64_t denom = (uint64_t)1 << 53; + uint64_t rand64 = rte_rand(); + + /* + * The double mantissa only has 53 bits, so we uniformly mask off the + * high 11 bits and then floating-point divide by 2^53 to achieve a + * result in [0, 1). + * + * We are not allowed to emit 1.0, so denom must be one greater than + * the possible range of the preceding step. + */ + + rand64 &= denom - 1; + return (double)rand64 / denom; +} + static uint64_t __rte_random_initial_seed(void) { diff --git a/lib/eal/include/rte_random.h b/lib/eal/include/rte_random.h index 29f5f1325a30..f6541c2b0f08 100644 --- a/lib/eal/include/rte_random.h +++ b/lib/eal/include/rte_random.h @@ -65,6 +65,24 @@ rte_rand(void); uint64_t rte_rand_max(uint64_t upper_bound); +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice + * + * Generates a pseudo-random floating point number. + * + * This function returns a nonnegative double-precision floating random + * number uniformly distributed over the interval [0.0, 1.0). + * + * The generator is not cryptographically secure. + * If called from lcore threads, this function is thread-safe. + * + * @return + * A pseudo-random value between 0 and 1.0. + */ +__rte_experimental +double rte_drand(void); + #ifdef __cplusplus } #endif diff --git a/lib/eal/version.map b/lib/eal/version.map index d49e30bd042f..cfbade9a33e9 100644 --- a/lib/eal/version.map +++ b/lib/eal/version.map @@ -422,6 +422,7 @@ EXPERIMENTAL { rte_intr_type_set; # added in 22.07 + rte_drand; rte_thread_get_affinity_by_id; rte_thread_self; rte_thread_set_affinity_by_id; -- 2.35.1