From: Li Li <dualli@chromium.org>
To: dualli@google.com, tkjos@google.com, gregkh@linuxfoundation.org,
christian@brauner.io, arve@android.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
maco@google.com, hridya@google.com, surenb@google.com
Cc: joel@joelfernandes.org, kernel-team@android.com
Subject: [RESEND PATCH v3 0/1] Binder: add TF_UPDATE_TXN to replace outdated txn
Date: Thu, 26 May 2022 15:00:17 -0700 [thread overview]
Message-ID: <20220526220018.3334775-1-dualli@chromium.org> (raw)
From: Li Li <dualli@google.com>
Resend [Patch v3] with cover letter in case my previous email failed
to reach the maillist (no comments for 2 weeks).
The previous comments of the old patch can be found at the following link:
https://lore.kernel.org/lkml/CANBPYPjkNWsO94nuG1TkR1DgK2W2kBxiJTriyVB7S3czHTZ1Yg@mail.gmail.com/
I copy and paste the key information here for your convenience.
* Question #1
Note, your subject does not say what TF_UPDATE_TXN is, so it's a bit
hard to determine what is happening here. Can you clean that up a bit
and sumarize what this new addition does?
How was this tested?
* Answer #1 ===
A more descriptive summary has been added to the new version of patch.
* Question #2
How was this tested?
* Answer #2
Old kernel: without this TF_UPDATE_TXN patch
New kernel: with this TF_UPDATE_TXN patch
Old apps: without setting TF_UPDATE_TXN
New apps: if (flags & TF_ONE_WAY) flags |= TF_UPDATE_TXN;
1. Compatibility: New kernel + Old apps, to verify the original
behavior doesn't change;
2. Compatibility: Old kernel + New apps, to verify the original
behavior doesn't change;
3. Unit test: New kernel + New apps, to verify the outdated oneway
binder transaction is actually superseded by the latest one (by
enabling BINDER_DEBUG logs);
4. Stress test: New kernel + New apps sending oneway binder
transactions repeatedly, to verify the size of the available async
binder buffer over time, and if the transactions fail as before
(due to async buffer running out).
* Question #3
Did checkpatch pass this? Please always use --strict and fix up all the
issues that it reports as this is not a normal kernel coding style.
* Answer #3
Yes, the latest version has passed "./scripts/checkpatch.pl --strict"
* Changelog
v3:
- Add this changelog required by "The canonical patch format"
v2:
- Fix alignment warnings reported by checkpatch --strict
- Add descriptive summary in patch subject
Li Li (1):
Binder: add TF_UPDATE_TXN to replace outdated txn
drivers/android/binder.c | 85 ++++++++++++++++++++++++++++-
drivers/android/binder_trace.h | 4 ++
include/uapi/linux/android/binder.h | 1 +
3 files changed, 87 insertions(+), 3 deletions(-)
--
2.36.1.124.g0e6072fb45-goog
next reply other threads:[~2022-05-26 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 22:00 Li Li [this message]
2022-05-26 22:00 ` [RESEND PATCH v3 1/1] Binder: add TF_UPDATE_TXN to replace outdated txn Li Li
2022-06-21 17:11 ` Todd Kjos
[not found] ` <YpBmmVa+09ZhP9LH@kroah.com>
2022-06-15 18:05 ` [RESEND PATCH v3 0/1] " Li Li
2022-06-16 5:58 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220526220018.3334775-1-dualli@chromium.org \
--to=dualli@chromium.org \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=dualli@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@google.com \
--cc=surenb@google.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.