All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hongnan Li <hongnan.li@linux.alibaba.com>
To: linux-erofs@lists.ozlabs.org, xiang@kernel.org, chao@kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] erofs: update ctx->pos for every emitted dirent
Date: Fri, 27 May 2022 15:25:36 +0800	[thread overview]
Message-ID: <20220527072536.68516-1-hongnan.li@linux.alibaba.com> (raw)

erofs_readdir update ctx->pos after filling a batch of dentries
and it may cause dir/files duplication for NFS readdirplus which
depends on ctx->pos to fill dir correctly. So update ctx->pos for
every emitted dirent in erofs_fill_dentries to fix it.

Fixes: 3e917cc305c6 ("erofs: make filesystem exportable")
Signed-off-by: Hongnan Li <hongnan.li@linux.alibaba.com>
---
 fs/erofs/dir.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/fs/erofs/dir.c b/fs/erofs/dir.c
index 18e59821c597..3015974fe2ff 100644
--- a/fs/erofs/dir.c
+++ b/fs/erofs/dir.c
@@ -22,11 +22,12 @@ static void debug_one_dentry(unsigned char d_type, const char *de_name,
 }
 
 static int erofs_fill_dentries(struct inode *dir, struct dir_context *ctx,
-			       void *dentry_blk, unsigned int *ofs,
+			       void *dentry_blk, void *dentry_begin,
 			       unsigned int nameoff, unsigned int maxsize)
 {
-	struct erofs_dirent *de = dentry_blk + *ofs;
+	struct erofs_dirent *de = dentry_begin;
 	const struct erofs_dirent *end = dentry_blk + nameoff;
+	loff_t begin_pos = ctx->pos;
 
 	while (de < end) {
 		const char *de_name;
@@ -59,9 +60,9 @@ static int erofs_fill_dentries(struct inode *dir, struct dir_context *ctx,
 			/* stopped by some reason */
 			return 1;
 		++de;
-		*ofs += sizeof(struct erofs_dirent);
+		ctx->pos += sizeof(struct erofs_dirent);
 	}
-	*ofs = maxsize;
+	ctx->pos = begin_pos + maxsize;
 	return 0;
 }
 
@@ -110,11 +111,9 @@ static int erofs_readdir(struct file *f, struct dir_context *ctx)
 				goto skip_this;
 		}
 
-		err = erofs_fill_dentries(dir, ctx, de, &ofs,
+		err = erofs_fill_dentries(dir, ctx, de, de + ofs,
 					  nameoff, maxsize);
 skip_this:
-		ctx->pos = blknr_to_addr(i) + ofs;
-
 		if (err)
 			break;
 		++i;
-- 
2.35.1


             reply	other threads:[~2022-05-27  7:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27  7:25 Hongnan Li [this message]
2022-05-28 12:56 ` [PATCH] erofs: update ctx->pos for every emitted dirent Gao Xiang
2022-05-28 12:56   ` Gao Xiang
2022-05-29  6:26 ` Chao Yu
2022-06-09  3:40 ` [PATCH v2] " Hongnan Li
2022-06-19  0:19   ` Chao Yu
2022-06-20  9:37     ` hongnanLi
2022-06-20 12:19       ` Gao Xiang
2022-06-20 12:19         ` Gao Xiang
2022-06-24  9:31         ` hongnanLi
2022-06-24  9:31           ` hongnanLi
2022-06-29  8:15 ` [PATCH v3] " Hongnan Li
2022-07-22  8:16   ` JeffleXu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220527072536.68516-1-hongnan.li@linux.alibaba.com \
    --to=hongnan.li@linux.alibaba.com \
    --cc=chao@kernel.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.