All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org
Subject: [PATCH v3 08/15] target/arm: Add el_is_in_host
Date: Fri, 27 May 2022 11:06:16 -0700	[thread overview]
Message-ID: <20220527180623.185261-9-richard.henderson@linaro.org> (raw)
In-Reply-To: <20220527180623.185261-1-richard.henderson@linaro.org>

This (newish) ARM pseudocode function is easier to work with
than open-coded tests for HCR_E2H etc.  Use of the function
will be staged into the code base in parts.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/internals.h |  2 ++
 target/arm/helper.c    | 28 ++++++++++++++++++++++++++++
 2 files changed, 30 insertions(+)

diff --git a/target/arm/internals.h b/target/arm/internals.h
index b587901be1..008e377887 100644
--- a/target/arm/internals.h
+++ b/target/arm/internals.h
@@ -1295,6 +1295,8 @@ static inline void define_cortex_a72_a57_a53_cp_reginfo(ARMCPU *cpu) { }
 void define_cortex_a72_a57_a53_cp_reginfo(ARMCPU *cpu);
 #endif
 
+bool el_is_in_host(CPUARMState *env, int el);
+
 void aa32_max_features(ARMCPU *cpu);
 bool arm_singlestep_active(CPUARMState *env);
 bool arm_generate_debug_exceptions(CPUARMState *env, int cur_el);
diff --git a/target/arm/helper.c b/target/arm/helper.c
index cd0a8992ba..d1b6c2459b 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -5288,6 +5288,34 @@ uint64_t arm_hcr_el2_eff(CPUARMState *env)
     return ret;
 }
 
+/*
+ * Corresponds to ARM pseudocode function ELIsInHost().
+ */
+bool el_is_in_host(CPUARMState *env, int el)
+{
+    uint64_t mask;
+
+    /*
+     * Since we only care about E2H and TGE, we can skip arm_hcr_el2_eff().
+     * Perform the simplest bit tests first, and validate EL2 afterward.
+     */
+    if (el & 1) {
+        return false; /* EL1 or EL3 */
+    }
+
+    /*
+     * Note that hcr_write() checks isar_feature_aa64_vh(),
+     * aka HaveVirtHostExt(), in allowing HCR_E2H to be set.
+     */
+    mask = el ? HCR_E2H : HCR_E2H | HCR_TGE;
+    if ((env->cp15.hcr_el2 & mask) != mask) {
+        return false;
+    }
+
+    /* TGE and/or E2H set: double check those bits are currently legal. */
+    return arm_is_el2_enabled(env) && arm_el_is_aa64(env, 2);
+}
+
 static void hcrx_write(CPUARMState *env, const ARMCPRegInfo *ri,
                        uint64_t value)
 {
-- 
2.34.1



  parent reply	other threads:[~2022-05-27 18:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27 18:06 [PATCH v3 00/15] target/arm: SME prep patches Richard Henderson
2022-05-27 18:06 ` [PATCH v3 01/15] target/arm: Rename TBFLAG_A64 ZCR_LEN to SVE_LEN Richard Henderson
2022-05-31 12:13   ` Peter Maydell
2022-05-27 18:06 ` [PATCH v3 02/15] linux-user/aarch64: Use SVE_LEN from hflags Richard Henderson
2022-05-31 12:15   ` Peter Maydell
2022-05-27 18:06 ` [PATCH v3 03/15] target/arm: Do not use aarch64_sve_zcr_get_valid_len in reset Richard Henderson
2022-05-31 12:15   ` Peter Maydell
2022-05-31 14:28     ` Richard Henderson
2022-05-31 14:55       ` Peter Maydell
2022-05-27 18:06 ` [PATCH v3 04/15] target/arm: Merge aarch64_sve_zcr_get_valid_len into caller Richard Henderson
2022-05-27 18:06 ` [PATCH v3 05/15] target/arm: Use uint32_t instead of bitmap for sve vq's Richard Henderson
2022-05-27 18:06 ` [PATCH v3 06/15] target/arm: Rename sve_zcr_len_for_el to sve_vqm1_for_el Richard Henderson
2022-05-31 12:19   ` Peter Maydell
2022-05-27 18:06 ` [PATCH v3 07/15] target/arm: Remove fp checks from sve_exception_el Richard Henderson
2022-05-27 18:06 ` Richard Henderson [this message]
2022-05-31 12:24   ` [PATCH v3 08/15] target/arm: Add el_is_in_host Peter Maydell
2022-05-27 18:06 ` [PATCH v3 09/15] target/arm: Use el_is_in_host for sve_vqm1_for_el Richard Henderson
2022-05-31 12:26   ` Peter Maydell
2022-05-27 18:06 ` [PATCH v3 10/15] target/arm: Split out load/store primitives to sve_ldst_internal.h Richard Henderson
2022-05-31 12:26   ` Peter Maydell
2022-05-27 18:06 ` [PATCH v3 11/15] target/arm: Export sve contiguous ldst support functions Richard Henderson
2022-05-31 12:27   ` Peter Maydell
2022-05-27 18:06 ` [PATCH v3 12/15] target/arm: Move expand_pred_b to vec_internal.h Richard Henderson
2022-05-31 12:30   ` Peter Maydell
2022-05-27 18:06 ` [PATCH v3 13/15] target/arm: Use expand_pred_b in mve_helper.c Richard Henderson
2022-05-31 12:33   ` Peter Maydell
2022-05-27 18:06 ` [PATCH v3 14/15] target/arm: Move expand_pred_h to vec_internal.h Richard Henderson
2022-05-31 12:34   ` Peter Maydell
2022-05-27 18:06 ` [PATCH v3 15/15] target/arm: Export bfdotadd from vec_helper.c Richard Henderson
2022-05-31 12:35   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220527180623.185261-9-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.