From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFF25C433FE for ; Fri, 27 May 2022 20:56:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354647AbiE0U4Y (ORCPT ); Fri, 27 May 2022 16:56:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237744AbiE0U4W (ORCPT ); Fri, 27 May 2022 16:56:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0FA115FC0; Fri, 27 May 2022 13:56:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A8CEEB82522; Fri, 27 May 2022 20:56:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F714C385A9; Fri, 27 May 2022 20:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653684979; bh=ouLxdfpPr93wSzVLMEJWXsalJLxfF1Dpqw0Ygd5TG3U=; h=From:To:Cc:Subject:Date:From; b=eLtrHsjt76J6u2ihrMzg64T6VTrtgYFZ7JyOqOBXFuLeXlkWIPtO+Uu8utoGSXkN9 HAIhIOcB/8tgxaHVLoTQS8TLbSbeAfpdiWgHRg35b8sgeBRMDMiiQDwRUgAiSb7Fv2 g2eIj40wujY2zKxDTY3Kq5rRz31aRjbuWgWLzsBoUWlsK3yHFEzO/0fUk/LtOL20UE mQ4iTKknT+6s3fraTmGwZBoAzEbYUXfwlF9jyQq5wdp27vMTjNn+yr64ssq2kkii3B 2LDO3s7+YR/vo7KgoPejDWg2EOEFXMoXwwGzUNV5RZjaQ7ouVJrJYk3WTGgp8Bh0kf wEcFg5MK6Rm/g== From: Jiri Olsa To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, lkml , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Steven Rostedt , Masami Hiramatsu Subject: [PATCH bpf-next 0/3] bpf: Fix cookie values for kprobe multi Date: Fri, 27 May 2022 22:56:08 +0200 Message-Id: <20220527205611.655282-1-jolsa@kernel.org> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, there's bug in kprobe_multi link that makes cookies misplaced when using symbols to attach. The reason is that we sort symbols by name but not adjacent cookie values. Current test did not find it because bpf_fentry_test* are already sorted by name. thanks, jirka --- Jiri Olsa (3): selftests/bpf: Shuffle cookies symbols in kprobe multi test ftrace: Keep address offset in ftrace_lookup_symbols bpf: Force cookies array to follow symbols sorting kernel/trace/bpf_trace.c | 65 ++++++++++++++++++++++++++++++++++++++++++++++++++--------------- kernel/trace/ftrace.c | 13 +++++++++++-- tools/testing/selftests/bpf/prog_tests/bpf_cookie.c | 78 +++++++++++++++++++++++++++++++++++++++--------------------------------------- tools/testing/selftests/bpf/progs/kprobe_multi.c | 24 ++++++++++++------------ 4 files changed, 112 insertions(+), 68 deletions(-)