From: Yu Kuai <yukuai3@huawei.com> To: <tj@kernel.org>, <mkoutny@suse.com>, <axboe@kernel.dk>, <ming.lei@redhat.com> Cc: <cgroups@vger.kernel.org>, <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <yukuai3@huawei.com>, <yi.zhang@huawei.com> Subject: [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle Date: Sat, 28 May 2022 14:43:22 +0800 [thread overview] Message-ID: <20220528064330.3471000-1-yukuai3@huawei.com> (raw) Changes in v5: - add comments in patch 4 - clear bytes/io_skipped in throtl_start_new_slice_with_credit() in patch 4 - and cleanup patches 5-8 Changes in v4: - add reviewed-by tag for patch 1 - add patch 2,3 - use a different way to fix io hung in patch 4 Changes in v3: - fix a check in patch 1 - fix link err in patch 2 on 32-bit platform - handle overflow in patch 2 Changes in v2: - use a new solution suggested by Ming - change the title of patch 1 - add patch 2 Patch 1 fix that blk-throttle can't work if multiple bios are throttle, Patch 2 fix overflow while calculating wait time Patch 3,4 fix io hung due to configuration updates. Patch 5-8 are cleanup patches, there are no functional changes, just some places that I think can be optimized during code review. Previous version: v1: https://lore.kernel.org/all/20220517134909.2910251-1-yukuai3@huawei.com/ v2: https://lore.kernel.org/all/20220518072751.1188163-1-yukuai3@huawei.com/ v3: https://lore.kernel.org/all/20220519085811.879097-1-yukuai3@huawei.com/ v4: https://lore.kernel.org/all/20220523082633.2324980-1-yukuai3@huawei.com/ Yu Kuai (8): blk-throttle: fix that io throttle can only work for single bio blk-throttle: prevent overflow while calculating wait time blk-throttle: factor out code to calculate ios/bytes_allowed blk-throttle: fix io hung due to config updates blk-throttle: use 'READ/WRITE' instead of '0/1' blk-throttle: calling throtl_dequeue/enqueue_tg in pairs blk-throttle: cleanup tg_update_disptime() blk-throttle: clean up flag 'THROTL_TG_PENDING' block/blk-throttle.c | 158 +++++++++++++++++++++++++++++-------------- block/blk-throttle.h | 16 +++-- 2 files changed, 120 insertions(+), 54 deletions(-) -- 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Yu Kuai <yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> To: tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mkoutny-IBi9RG/b67k@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org Subject: [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle Date: Sat, 28 May 2022 14:43:22 +0800 [thread overview] Message-ID: <20220528064330.3471000-1-yukuai3@huawei.com> (raw) Changes in v5: - add comments in patch 4 - clear bytes/io_skipped in throtl_start_new_slice_with_credit() in patch 4 - and cleanup patches 5-8 Changes in v4: - add reviewed-by tag for patch 1 - add patch 2,3 - use a different way to fix io hung in patch 4 Changes in v3: - fix a check in patch 1 - fix link err in patch 2 on 32-bit platform - handle overflow in patch 2 Changes in v2: - use a new solution suggested by Ming - change the title of patch 1 - add patch 2 Patch 1 fix that blk-throttle can't work if multiple bios are throttle, Patch 2 fix overflow while calculating wait time Patch 3,4 fix io hung due to configuration updates. Patch 5-8 are cleanup patches, there are no functional changes, just some places that I think can be optimized during code review. Previous version: v1: https://lore.kernel.org/all/20220517134909.2910251-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org/ v2: https://lore.kernel.org/all/20220518072751.1188163-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org/ v3: https://lore.kernel.org/all/20220519085811.879097-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org/ v4: https://lore.kernel.org/all/20220523082633.2324980-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org/ Yu Kuai (8): blk-throttle: fix that io throttle can only work for single bio blk-throttle: prevent overflow while calculating wait time blk-throttle: factor out code to calculate ios/bytes_allowed blk-throttle: fix io hung due to config updates blk-throttle: use 'READ/WRITE' instead of '0/1' blk-throttle: calling throtl_dequeue/enqueue_tg in pairs blk-throttle: cleanup tg_update_disptime() blk-throttle: clean up flag 'THROTL_TG_PENDING' block/blk-throttle.c | 158 +++++++++++++++++++++++++++++-------------- block/blk-throttle.h | 16 +++-- 2 files changed, 120 insertions(+), 54 deletions(-) -- 2.31.1
next reply other threads:[~2022-05-28 6:30 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-28 6:43 Yu Kuai [this message] 2022-05-28 6:43 ` [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle Yu Kuai 2022-05-28 6:43 ` [PATCH -next v5 1/8] blk-throttle: fix that io throttle can only work for single bio Yu Kuai 2022-05-28 6:43 ` Yu Kuai 2022-05-28 6:43 ` [PATCH -next v5 2/8] blk-throttle: prevent overflow while calculating wait time Yu Kuai 2022-05-28 6:43 ` Yu Kuai 2022-05-28 6:43 ` [PATCH -next v5 3/8] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai 2022-05-28 6:43 ` Yu Kuai 2022-06-22 17:27 ` Michal Koutný 2022-06-23 12:03 ` Yu Kuai 2022-06-23 12:03 ` Yu Kuai 2022-05-28 6:43 ` [PATCH -next v5 4/8] blk-throttle: fix io hung due to config updates Yu Kuai 2022-05-28 6:43 ` Yu Kuai 2022-06-22 17:26 ` Michal Koutný 2022-06-23 12:27 ` Yu Kuai 2022-06-23 12:27 ` Yu Kuai 2022-06-23 16:26 ` Michal Koutný 2022-06-25 8:36 ` Yu Kuai 2022-06-25 8:36 ` Yu Kuai 2022-06-25 16:41 ` Jens Axboe 2022-06-25 16:41 ` Jens Axboe 2022-06-26 2:39 ` Yu Kuai 2022-06-26 2:39 ` Yu Kuai 2022-07-05 11:42 ` Yu Kuai 2022-07-05 11:42 ` Yu Kuai 2022-05-28 6:43 ` [PATCH -next v5 5/8] blk-throttle: use 'READ/WRITE' instead of '0/1' Yu Kuai 2022-05-28 6:43 ` Yu Kuai 2022-05-28 6:43 ` [PATCH -next v5 6/8] blk-throttle: calling throtl_dequeue/enqueue_tg in pairs Yu Kuai 2022-05-28 6:43 ` Yu Kuai 2022-05-28 6:43 ` [PATCH -next v5 7/8] blk-throttle: cleanup tg_update_disptime() Yu Kuai 2022-05-28 6:43 ` Yu Kuai 2022-05-28 6:43 ` [PATCH -next v5 8/8] blk-throttle: clean up flag 'THROTL_TG_PENDING' Yu Kuai 2022-05-28 6:43 ` Yu Kuai 2022-06-02 11:14 ` [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle Yu Kuai 2022-06-02 11:14 ` Yu Kuai 2022-06-09 0:59 ` Yu Kuai 2022-06-09 0:59 ` Yu Kuai 2022-06-17 1:15 ` Yu Kuai 2022-06-17 1:15 ` Yu Kuai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220528064330.3471000-1-yukuai3@huawei.com \ --to=yukuai3@huawei.com \ --cc=axboe@kernel.dk \ --cc=cgroups@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ming.lei@redhat.com \ --cc=mkoutny@suse.com \ --cc=tj@kernel.org \ --cc=yi.zhang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.