From: Zorro Lang <zlang@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Zorro Lang <zlang@kernel.org>, fstests <fstests@vger.kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH 5/5] generic/623: add overlay into the blacklist
Date: Mon, 30 May 2022 14:22:10 +0800 [thread overview]
Message-ID: <20220530062210.pwnmnylo6hhs7lej@zlang-mailbox> (raw)
In-Reply-To: <CAOQ4uxix_Un2EZUO=7PGMuFgimmKx0QDS_jvkBmgyFQjUgZHrg@mail.gmail.com>
On Mon, May 30, 2022 at 08:54:23AM +0300, Amir Goldstein wrote:
> On Sun, May 29, 2022 at 8:59 PM Zorro Lang <zlang@kernel.org> wrote:
> >
> > The _require_scratch_shutdown can't help this test case, except use
> > _scratch_shutdown or _scratch_shutdown_handle with it. But this test
> > case does 'shutdown' on $SCRATCH_MNT/file directly. It's not suitable
> > for overlay.
> >
>
> This is not about testing overlayfs.
> It is about testing FS under overlayfs which can detect bugs in FS
> that are otherwise hard to trigger.
> mmap is an especially odd case of overlayfs so I rather not loose this
> test coverage. Please do not apply this patch I will send a fix to the test.
Thanks, if you think it's worth keeping for overlay, I'll drop this patch.
If we change the code as:
if [ $FSTYP = "overlay" ];then
file=$OVL_BASE_SCRATCH_MNT/file
fi
It's actually not testing overlay at all. We might need all testing operations
run on overlay, then shutdown the $OVL_BASE_SCRATCH_MNT. But it looks not simple
to separate the 'shutdown' from the:
$XFS_IO_PROG -x -c "mmap 0 4k" -c "mwrite 0 4k" -c shutdown -c fsync \
-c "mwrite 0 4k" $file | _filter_xfs_io
So what's your plan?
Thanks,
Zorro
>
> Thanks,
> Amir.
>
> > Signed-off-by: Zorro Lang <zlang@kernel.org>
> > ---
> > tests/generic/623 | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/generic/623 b/tests/generic/623
> > index ea016d91..1083e796 100755
> > --- a/tests/generic/623
> > +++ b/tests/generic/623
> > @@ -11,7 +11,7 @@ _begin_fstest auto quick shutdown
> >
> > . ./common/filter
> >
> > -_supported_fs generic
> > +_supported_fs ^overlay
> > _fixed_by_kernel_commit e4826691cc7e \
> > "xfs: restore shutdown check in mapped write fault path"
> >
> > --
> > 2.31.1
> >
>
prev parent reply other threads:[~2022-05-30 6:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 10:55 [PATCH 0/5] random fixes for fstests Zorro Lang
2022-05-29 10:55 ` [PATCH 1/5] generic/139: require 512 bytes to be the minimum dio size Zorro Lang
2022-05-30 0:11 ` Dave Chinner
2022-05-29 10:55 ` [PATCH 2/5] generic/506: call _require_quota before _qmount Zorro Lang
2022-05-30 0:12 ` Dave Chinner
2022-05-29 10:55 ` [PATCH 3/5] generic/591: remove redundant output from golden image Zorro Lang
2022-05-30 0:44 ` Dave Chinner
2022-05-30 5:43 ` Zorro Lang
2022-05-29 10:55 ` [PATCH 4/5] generic/591: use proper sector size Zorro Lang
2022-05-29 23:57 ` Dave Chinner
2022-05-30 6:02 ` Zorro Lang
2022-05-29 10:55 ` [PATCH 5/5] generic/623: add overlay into the blacklist Zorro Lang
2022-05-30 5:54 ` Amir Goldstein
2022-05-30 6:22 ` Zorro Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220530062210.pwnmnylo6hhs7lej@zlang-mailbox \
--to=zlang@redhat.com \
--cc=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.