From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B4CAC433EF for ; Mon, 30 May 2022 07:54:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234317AbiE3HyI (ORCPT ); Mon, 30 May 2022 03:54:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234263AbiE3HxS (ORCPT ); Mon, 30 May 2022 03:53:18 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5072A2FE4F for ; Mon, 30 May 2022 00:52:59 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id b5so9608439plx.10 for ; Mon, 30 May 2022 00:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=B2+w4CyIic04O74zsrr6J9+GENsUdcPxtqUHqciF3k4=; b=Q6l/LLUJpBKs6UbTNbbyAyCSplHUSXQg+QSc7jsKHgHPx+ORbJNODgrdDW4eT2ruJQ wBiAkAt+Zw0pjmdUoFjYoeliM4zzlYHvSuWeVG4POyrMu2tAgXdTrCYZPXcMXxSNooz0 ZgnYSZ2o/8+Pu9cgADwesgYA+jTarZ5JxKT4YAg0PhyokaVxPqUn6tPYCi3we+cyBQ9K ZWMx0pt42nq8B9a15nMMRQv9/35W2WIX7O8M7jlBKMjQjANXJsQ7ItsavXzsIiHwF7hV 2jpQt0tsf7tvszb5AWu7SUnnVSzgd2WIMq1lWpiYOLTWEF/9ZzeH8nQrmSM4vK31eamU E01A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B2+w4CyIic04O74zsrr6J9+GENsUdcPxtqUHqciF3k4=; b=ZUaMUBMMS0Vu+LFEkml1cOQ0Bz/vpMUyun1t2CzGgFqMgyczx/2pvaKPFYlbhU+wtZ /vi3IJtTNx/bQ4XdB3wwkOy47D5Li4ffM9NHvdbYRHqNQFlpJIBUkeKh5aKa3z6THMRd 83+BMrgKm92yhpW3xCh6DXp/89bFMe4wdImYucOgkmIXFbK1x3mn95ltwpxwcNg1L2CC Qqt1gK9zspbsLbfYWfyqpHwrzmnC/9fn8rT75nLI+odD0ZIsclnNqpIlXZix8IiEHqob t9wX0vBI5rcklvKLWdgzBJ9O+9kXNdid5fk5F0gMPIGkDdFLqPVLJAirSo9BKyJ4ep4E KsoA== X-Gm-Message-State: AOAM531qgccQvzXnm0iQSAefxRyeiCpg8VFLyp8RN6Glm8dsAGCGKUY5 iq7OhA+VXmH1yLbQa7hLdtQtmQ== X-Google-Smtp-Source: ABdhPJxXiWB4Udg+C4V+oB24Pg38eAB7p/6ABy0vwd/GBnFZwjfvY6tXy6qK8sBqrFdCIbsVNcdijA== X-Received: by 2002:a17:902:f682:b0:163:f4e9:5145 with SMTP id l2-20020a170902f68200b00163f4e95145mr430859plg.63.1653897178844; Mon, 30 May 2022 00:52:58 -0700 (PDT) Received: from localhost ([122.162.234.2]) by smtp.gmail.com with ESMTPSA id c11-20020a624e0b000000b005182deb6c1bsm8182208pfb.62.2022.05.30.00.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 May 2022 00:52:58 -0700 (PDT) Date: Mon, 30 May 2022 13:22:56 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: "Rafael J. Wysocki" , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Krzysztof Kozlowski , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 08/31] cpufreq: tegra20: Migrate to dev_pm_opp_set_config() Message-ID: <20220530075256.lpw6bhupejy2dnqi@vireshk-i7> References: <4b38ceed657bfcf87ff9ab0dd69dd1f2f5658b24.1653564321.git.viresh.kumar@linaro.org> <793e49ea-aeb0-a47a-9fe8-742a6397bb35@collabora.com> <5c0e697e-abca-bcf0-cf68-d9c240d82527@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c0e697e-abca-bcf0-cf68-d9c240d82527@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On 29-05-22, 19:59, Dmitry Osipenko wrote: > > Please keep the PTR_ERR_OR_ZERO. Ahh, sorry about that. Fixed. > > tegra20-cpufreq tegra20-cpufreq: failed to set OPP config: -1042688000 > > With that fixed, now there is another error: > > [ 1.761945] cpu cpu0: _of_add_opp_table_v2: no supported OPPs > [ 1.761960] cpu cpu0: OPP table can't be empty So we failed to find any OPPs which work with the hardware version of updated with dev_pm_opp_set_config(). I tried to follow the path and see if there is something wrong here. Failed to find that :( > I see this on Tegra30, but not on Tegra20. Apparently OPP table > refcounting is broken on Tegra30 by this patchset. To make it clear, > there are no error without these OPP patches applied. I may take a > closer look if will be needed, just ping me. Yes, it would be very helpful as I don't have the necessary hardware. -- viresh