From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B791EC433EF for ; Mon, 30 May 2022 08:56:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 48780842AD; Mon, 30 May 2022 10:56:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="GBHa7Gqs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A9E9B842AD; Mon, 30 May 2022 10:56:21 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7801980FC8 for ; Mon, 30 May 2022 10:56:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0CEE8B80C92; Mon, 30 May 2022 08:56:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82F57C34119; Mon, 30 May 2022 08:56:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653900976; bh=eHvvC7ySg8w6xlQeDf/qUflMEs4dd3FH55pIBh6ZvYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GBHa7GqsqThHBloxImGqiZYGIb2TFciLjFtXaijVNfxkHeElfngX88W1vX9v+W+or yiFlXFqXTnKoYWLtvjqqN26jkcpC1IyHgK0Ax7aPH25ZIXD0/V11oXHJboHMjsGwYp yj1QpCNvNrsYpoIRgUm+/Plz7v8NeEeiEN1jCOZgto5WZ3rkPiYOx/7A98XWZW42PH ICM3oo44d87/YhCZ3zXjcuahqhdZ8j1QwF5zI40wHQvA0LRyra0x/6x9gdkm3EH+Pc fXIFe2Qfz+NutdEgPnfEt2RAD8vgjEOvrlFeqMOrivt4IJJKk2I6Ni2HML/sOEjqEP 3L5EpZiBFq/5Q== Received: by pali.im (Postfix) id 11C15731; Mon, 30 May 2022 10:56:14 +0200 (CEST) Date: Mon, 30 May 2022 10:56:13 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Masahisa Kojima Cc: Heinrich Schuchardt , Tom Rini , U-Boot Mailing List , Bin Meng , Sean Anderson , Vincent =?utf-8?Q?Stehl=C3=A9?= , Ilias Apalodimas Subject: Re: Pull request for efi-2022-07-rc4-2 Message-ID: <20220530085613.g2d23g7fqdnsrbik@pali> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Monday 30 May 2022 09:32:53 Masahisa Kojima wrote: > Hi Heinrich, > > On Mon, 30 May 2022 at 01:16, Heinrich Schuchardt wrote: > > > > Dear Tom, > > > > this replaces pull request for efi-2022-07-rc4. > > > > The following changes since commit 4fe629d2e8bbda5f265e870d771b92be26e885f6: > > > > Merge https://source.denx.de/u-boot/custodians/u-boot-riscv > > (2022-05-27 08:50:42 -0400) > > > > are available in the Git repository at: > > > > https://source.denx.de/u-boot/custodians/u-boot-efi.git > > tags/efi-2022-07-rc4-2 > > > > for you to fetch changes up to de8471a30eb399d46412b2037ba76cfa258c6115: > > > > bootmenu: use utf-8 for menu title (2022-05-29 13:18:18 +0200) > > > > Gitlab CI showed no issues: > > https://source.denx.de/u-boot/custodians/u-boot-efi/-/pipelines/12157 > > > > ---------------------------------------------------------------- > > Pull request for efi-2022-07-rc4-2 > > > > UEFI: > > > > * fix a problem in loading an image from a short-path > > * fix building the bootmenu command for CONFIG_EFI_LOADER=n > > * correct the bootefi command syntax > > * add firmware management protocol to the documentation > > > > Others: > > > > * bootmenu: fix bootmenu title handling > > > > ---------------------------------------------------------------- > > AKASHI Takahiro (2): > > efi_loader: disk: add efi_disk_is_removable() > > efi_loader: bootmgr: fix a problem in loading an image from a > > short-path > > > > Bin Meng (2): > > doc: sandbox: Correct the memory size config option > > doc: sandbox: Add a note of disabling LTO when using gdb > > > > Heinrich Schuchardt (6): > > disk: incorrect message in is_gpt_valid() > > test: restore timeout after bootmenu unit test > > doc/build/gcc: add more required packages > > test: fix pylint warnings in test_efi_selftest.py > > test: don't change console timeout in EFI selftest. > > cmd/bootefi: correct command syntax > > > > Masahisa Kojima (3): > > bootmenu: U-Boot console is enabled as default > > lib/charset: fix compile warnings > > bootmenu: use utf-8 for menu title > > With your fix to the last patch, the bootmenu output > is as below. > > *** U-Boot Boot Menu *** > > Boot 1. kernel=bootm 0x82000000 > Boot 2. kernel=bootm 0x83000000 > Reset board=reset > U-Boot console > > Press UP/DOWN to move, ENTER to select, ESC/CTRL+C to quit > > The menu title includes both the title and command of "bootmenu_x". > Is it intended? Hello! This is really not intended. Issue is in commit: https://source.denx.de/u-boot/custodians/u-boot-efi/-/commit/de8471a30eb399d46412b2037ba76cfa258c6115 There is line: 184 + entry->title = strdup(option); But it rather should be: 184 + entry->title = strndup(option, sep-option); > Thanks, > Masahias Kojima > > > > > Sean Anderson (2): > > valgrind: Disable on Risc-V > > doc: sandbox: Add additional valgrind documentation > > > > Vincent Stehlé (2): > > efi: fix documentation warnings > > doc/efi: add firmware management protocol to the documentation > > > > Kconfig | 1 + > > boot/Kconfig | 7 +++ > > cmd/Kconfig | 10 ---- > > cmd/bootefi.c | 21 +++++--- > > cmd/bootmenu.c | 47 ++++++++-------- > > disk/part_efi.c | 4 +- > > doc/api/efi.rst | 6 +++ > > doc/arch/sandbox.rst | 107 > > +++++++++++++++++++++++++++++++++---- > > doc/build/gcc.rst | 8 +-- > > doc/usage/cmd/bootefi.rst | 8 +-- > > include/charset.h | 2 +- > > include/efi_loader.h | 3 ++ > > lib/efi_loader/efi_bootmgr.c | 107 > > +++++++++++++++++++++++++++++++++++-- > > lib/efi_loader/efi_disk.c | 27 ++++++++++ > > lib/efi_loader/efi_firmware.c | 10 ++-- > > test/py/tests/test_bootmenu.py | 66 +++++++++++------------ > > test/py/tests/test_efi_selftest.py | 91 ++++++++++--------------------- > > 17 files changed, 359 insertions(+), 166 deletions(-)