All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC
@ 2022-05-31  1:10 David Wang
  2022-05-31  1:10 ` [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles David Wang
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: David Wang @ 2022-05-31  1:10 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-kernel
  Cc: edward_chen, ben_pai, David Wang

The initial introduction of the jabil server with AST2600 BMC SoC.

---

v5
- Compatible value chamged to "jabil,rbp-bmc".

v4
- Add document the new compatible.
- Delete redundant blank lines.
- Add a new line at end of file.

v3
- Adjustment entries are ordered by name.
- Remove the bootargs property and modify the stdout-path property.
- Group multiple LED devices into a group.
- Modify the "gpio3_71" node name format.
- Delete unneeded blank line at the end.

v2
- Disable empty i2c bus.
- Remove gfx node because aspeed-g6.dtsi isn't supported.
- Modify the led format and add some properties.
- Fix wrong indentation.
- Add stdout property in chosen node.
- Rename temp to temperature-sensor in i2c bus 0.

---

Signed-off-by: David Wang <David_Wang6097@jabil.com>
---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../boot/dts/aspeed-bmc-jabil-rubypass.dts    | 442 ++++++++++++++++++
 2 files changed, 443 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-jabil-rubypass.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 7c16f8a2b738..5339e9339ce4 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -1543,6 +1543,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-intel-s2600wf.dtb \
 	aspeed-bmc-inspur-fp5280g2.dtb \
 	aspeed-bmc-inspur-nf5280m6.dtb \
+	aspeed-bmc-jabil-rubypass.dtb \
 	aspeed-bmc-lenovo-hr630.dtb \
 	aspeed-bmc-lenovo-hr855xg2.dtb \
 	aspeed-bmc-microsoft-olympus.dtb \
diff --git a/arch/arm/boot/dts/aspeed-bmc-jabil-rubypass.dts b/arch/arm/boot/dts/aspeed-bmc-jabil-rubypass.dts
new file mode 100644
index 000000000000..902be5fa15fd
--- /dev/null
+++ b/arch/arm/boot/dts/aspeed-bmc-jabil-rubypass.dts
@@ -0,0 +1,442 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+
+/dts-v1/;
+
+#include "aspeed-g6.dtsi"
+#include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/leds/common.h>
+
+/ {
+	model = "Jabil rbp";
+	compatible = "jabil,rbp-bmc", "aspeed,ast2600";
+
+	chosen {
+		stdout-path = "/uart5:115200n8";
+	};
+
+	memory@80000000 {
+		device_type = "memory";
+		reg = <0x80000000 0x80000000>;
+	};
+
+	vcc_sdhci0: regulator-vcc-sdhci0 {
+		compatible = "regulator-fixed";
+		regulator-name = "SDHCI0 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 0) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	vccq_sdhci0: regulator-vccq-sdhci0 {
+		compatible = "regulator-gpio";
+		regulator-name = "SDHCI0 VccQ";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 1) GPIO_ACTIVE_HIGH>;
+		gpios-states = <1>;
+		states = <3300000 1>,
+			 <1800000 0>;
+	};
+
+	vcc_sdhci1: regulator-vcc-sdhci1 {
+		compatible = "regulator-fixed";
+		regulator-name = "SDHCI1 Vcc";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 2) GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
+	vccq_sdhci1: regulator-vccq-sdhci1 {
+		compatible = "regulator-gpio";
+		regulator-name = "SDHCI1 VccQ";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <3300000>;
+		gpios = <&gpio0 ASPEED_GPIO(V, 3) GPIO_ACTIVE_HIGH>;
+		gpios-states = <1>;
+		states = <3300000 1>,
+			 <1800000 0>;
+	};
+
+	leds {
+		compatible = "gpio-leds";
+		pinctrl-names = "default";
+
+		led-0 {
+			label = "identify";
+			color = <LED_COLOR_ID_BLUE>;
+			function = LED_FUNCTION_INDICATOR;
+			retain-state-shutdown;
+			gpios = <&gpio0 ASPEED_GPIO(B, 7) GPIO_ACTIVE_LOW>;
+		};
+
+		led-1 {
+			label = "status_amber";
+			color = <LED_COLOR_ID_AMBER>;
+			function = LED_FUNCTION_STATUS;
+			gpios = <&gpio0 ASPEED_GPIO(G, 3) GPIO_ACTIVE_LOW>;
+		};
+
+		led-2 {
+			label = "status_green";
+			color = <LED_COLOR_ID_GREEN>;
+			default-state = "keep";
+			function = LED_FUNCTION_STATUS;
+			gpios = <&gpio0 ASPEED_GPIO(G, 2) GPIO_ACTIVE_LOW>;
+		};
+
+		led-3 {
+			label = "status_susack";
+			function = LED_FUNCTION_STATUS;
+			gpios = <&gpio0 ASPEED_GPIO(V, 6) GPIO_ACTIVE_LOW>;
+		};
+
+		led-4 {
+			label = "power-amber";
+			color = <LED_COLOR_ID_AMBER>;
+			function = LED_FUNCTION_POWER;
+			gpios = <&gpio0 ASPEED_GPIO(Y, 0) GPIO_ACTIVE_LOW>;
+		};
+
+		led-5 {
+			label = "fan1-fault";
+			color = <LED_COLOR_ID_YELLOW>;
+			function = LED_FUNCTION_FAULT;
+			retain-state-shutdown;
+			gpios = <&gpio3_71 0 GPIO_ACTIVE_HIGH>;
+		};
+
+		led-6 {
+			label = "fan2-fault";
+			color = <LED_COLOR_ID_YELLOW>;
+			function = LED_FUNCTION_FAULT;
+			retain-state-shutdown;
+			gpios = <&gpio3_71 1 GPIO_ACTIVE_HIGH>;
+		};
+
+		led-7 {
+			label = "fan3-fault";
+			color = <LED_COLOR_ID_YELLOW>;
+			function = LED_FUNCTION_FAULT;
+			retain-state-shutdown;
+			gpios = <&gpio3_71 2 GPIO_ACTIVE_HIGH>;
+		};
+
+		led-8 {
+			label = "fan4-fault";
+			color = <LED_COLOR_ID_YELLOW>;
+			function = LED_FUNCTION_FAULT;
+			retain-state-shutdown;
+			gpios = <&gpio3_71 3 GPIO_ACTIVE_HIGH>;
+		};
+
+		led-9 {
+			label = "fan5-fault";
+			color = <LED_COLOR_ID_YELLOW>;
+			function = LED_FUNCTION_FAULT;
+			retain-state-shutdown;
+			gpios = <&gpio3_71 4 GPIO_ACTIVE_HIGH>;
+		};
+
+		led-10 {
+			label = "fan6-fault";
+			color = <LED_COLOR_ID_YELLOW>;
+			function = LED_FUNCTION_FAULT;
+			retain-state-shutdown;
+			gpios = <&gpio3_71 5 GPIO_ACTIVE_HIGH>;
+		};
+	};
+};
+
+&mdio0 {
+	status = "okay";
+
+	ethphy0: ethernet-phy@0 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0>;
+	};
+};
+
+&mdio1 {
+	status = "okay";
+
+	ethphy1: ethernet-phy@0 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0>;
+	};
+};
+
+&mdio2 {
+	status = "okay";
+
+	ethphy2: ethernet-phy@0 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0>;
+	};
+};
+
+&mdio3 {
+	status = "okay";
+
+	ethphy3: ethernet-phy@0 {
+		compatible = "ethernet-phy-ieee802.3-c22";
+		reg = <0>;
+	};
+};
+
+&mac0 {
+	status = "okay";
+
+	phy-mode = "rgmii-rxid";
+	phy-handle = <&ethphy0>;
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii1_default>;
+};
+
+&mac1 {
+	status = "okay";
+
+	phy-mode = "rgmii-rxid";
+	phy-handle = <&ethphy1>;
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii2_default>;
+};
+
+&mac2 {
+	status = "okay";
+
+	phy-mode = "rgmii";
+	phy-handle = <&ethphy2>;
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii3_default>;
+};
+
+&mac3 {
+	status = "okay";
+
+	phy-mode = "rgmii";
+	phy-handle = <&ethphy3>;
+
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_rgmii4_default>;
+};
+
+&emmc_controller {
+	status = "okay";
+};
+
+&emmc {
+	non-removable;
+	bus-width = <4>;
+	max-frequency = <100000000>;
+	clk-phase-mmc-hs200 = <9>, <225>;
+};
+
+&rtc {
+	status = "okay";
+};
+
+&fmc {
+	status = "okay";
+	flash@0 {
+		status = "okay";
+		m25p,fast-read;
+		label = "bmc";
+		spi-max-frequency = <50000000>;
+#include "openbmc-flash-layout-128.dtsi"
+	};
+};
+
+&spi1 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_spi1_default>;
+
+	flash@0 {
+		status = "okay";
+		m25p,fast-read;
+		label = "pnor";
+		spi-max-frequency = <100000000>;
+	};
+};
+
+&uart1 {
+	status = "okay";
+	pinctrl-0 = <&pinctrl_txd1_default
+			&pinctrl_rxd1_default
+			&pinctrl_nrts1_default
+			&pinctrl_ndtr1_default
+			&pinctrl_ndsr1_default
+			&pinctrl_ncts1_default
+			&pinctrl_ndcd1_default
+			&pinctrl_nri1_default>;
+};
+
+&uart2 {
+	status = "okay";
+	pinctrl-0 = <&pinctrl_txd2_default
+			&pinctrl_rxd2_default
+			&pinctrl_nrts2_default
+			&pinctrl_ndtr2_default
+			&pinctrl_ndsr2_default
+			&pinctrl_ncts2_default
+			&pinctrl_ndcd2_default
+			&pinctrl_nri2_default>;
+};
+
+&uart3 {
+	status = "okay";
+};
+
+&uart4 {
+	status = "okay";
+};
+
+&i2c0 {
+	status = "okay";
+
+	temperature-sensor@2e {
+		compatible = "adi,adt7490";
+		reg = <0x2e>;
+	};
+};
+
+&i2c3 {
+	multi-master;
+	status = "okay";
+
+	gpio@70 {
+		compatible = "nxp,pca9538";
+		reg = <0x70>;
+		interrupt-parent = <&gpio0>;
+		interrupts = <ASPEED_GPIO(O, 7) IRQ_TYPE_EDGE_FALLING>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-line-names =
+			"presence-fan1-n", "presence-fan2-n", "presence-fan3-n", "presence-fan4-n",
+			"presence-fan5-n", "presence-fan6-n", "", "";
+	};
+
+	gpio3_71: gpio@71 {
+		compatible = "nxp,pca9538";
+		reg = <0x71>;
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-line-names =
+			"led-fan1-fault", "led-fan2-fault", "led-fan3-fault", "led-fan4-fault",
+			"led-fan5-fault", "led-fan6-fault", "", "";
+	};
+};
+
+&fsim0 {
+	status = "okay";
+};
+
+&ehci1 {
+	status = "okay";
+};
+
+&uhci {
+	status = "okay";
+};
+
+&sdc {
+	status = "okay";
+};
+
+/*
+ * The signal voltage of sdhci0 and sdhci1 on AST2600-A2 EVB is able to be
+ * toggled by GPIO pins.
+ * In the reference design, GPIOV0 of AST2600-A2 EVB is connected to the
+ * power load switch that provides 3.3v to sdhci0 vdd, GPIOV1 is connected to
+ * a 1.8v and a 3.3v power load switch that provides signal voltage to
+ * sdhci0 bus.
+ * If GPIOV0 is active high, sdhci0 is enabled, otherwise, sdhci0 is disabled.
+ * If GPIOV1 is active high, 3.3v power load switch is enabled, sdhci0 signal
+ * voltage is 3.3v, otherwise, 1.8v power load switch will be enabled,
+ * sdhci0 signal voltage becomes 1.8v.
+ * AST2600-A2 EVB also supports toggling signal voltage for sdhci1.
+ * The design is the same as sdhci0, it uses GPIOV2 as power-gpio and GPIOV3
+ * as power-switch-gpio.
+ */
+&sdhci0 {
+	status = "okay";
+	bus-width = <4>;
+	max-frequency = <100000000>;
+	sdhci-drive-type = /bits/ 8 <3>;
+	sdhci-caps-mask = <0x7 0x0>;
+	sdhci,wp-inverted;
+	vmmc-supply = <&vcc_sdhci0>;
+	vqmmc-supply = <&vccq_sdhci0>;
+	clk-phase-sd-hs = <7>, <200>;
+};
+
+&sdhci1 {
+	status = "okay";
+	bus-width = <4>;
+	max-frequency = <100000000>;
+	sdhci-drive-type = /bits/ 8 <3>;
+	sdhci-caps-mask = <0x7 0x0>;
+	sdhci,wp-inverted;
+	vmmc-supply = <&vcc_sdhci1>;
+	vqmmc-supply = <&vccq_sdhci1>;
+	clk-phase-sd-hs = <7>, <200>;
+};
+
+&gpio0 {
+	status = "okay";
+	gpio-line-names =
+	/*A0-A7*/       "","","","","","","","",
+	/*B0-B7*/       "presence-ncsi-i210-n","","","","","","","led-identify-n",
+	/*C0-C7*/       "","","","","","","","",
+	/*D0-D7*/       "","","","","","","","",
+	/*E0-E7*/       "","","","","","","","",
+	/*F0-F7*/       "","","","","","","id-button","",
+	/*G0-G7*/       "","","led-status-green-n","led-status-amber-n","","","","",
+	/*H0-H7*/       "","","","","","cpu-caterr","","cpu1-caterr-n",
+	/*I0-I7*/       "","","","","","","","",
+	/*J0-J7*/       "","","","","","","","",
+	/*K0-K7*/       "","","","","","","","",
+	/*L0-L7*/       "","","","","","","","",
+	/*M0-M7*/       "","","","","","","","",
+	/*N0-N7*/       "","","","","","","","",
+	/*O0-O7*/       "","","","","","","nmi-button","",
+	/*P0-P7*/       "reset-button","reset-out","power-button","power-out","","","",
+			"led-hartbeat-n",
+	/*Q0-Q7*/       "","","","","","","","",
+	/*R0-R7*/       "","","","","","","","",
+	/*S0-S7*/       "","","","","","","","",
+	/*T0-T7*/       "","","","","","","","",
+	/*U0-U7*/       "","","","","","","","",
+	/*V0-V7*/       "regulator-vcc-sdhci0","regulator-vccq-sdhci0","regulator-vcc-sdhci1",
+			"regulator-vccq-sdhci1","sio-power-good",
+			"led-bmc-fw-config-done-n","","",
+	/*W0-W7*/       "","","","","","","","",
+	/*X0-X7*/       "cpu-err2","","","","","","","",
+	/*Y0-Y7*/       "led-power-amber","","","","","","","",
+	/*Z0-Z7*/       "cpu-err0","cpu-err1","","","","","","";
+	};
+
+&gpio1 {
+	status = "okay";
+};
+
+&kcs3 {
+	aspeed,lpc-io-reg = <0xCA2>;
+	status = "okay";
+};
+
+&kcs4 {
+	aspeed,lpc-io-reg = <0xCA4>;
+	status = "okay";
+};
+
+&lpc_snoop {
+	snoop-ports = <0x80>;
+	status = "okay";
+};
+
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles
  2022-05-31  1:10 [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC David Wang
@ 2022-05-31  1:10 ` David Wang
  2022-05-31 10:23   ` Krzysztof Kozlowski
  2022-06-22 10:14   ` (subset) " Krzysztof Kozlowski
  2022-05-31  1:11 ` [PATCH v5 2/3] dt-bindings: vendor-prefixes: document jabil vendors for Aspeed BMC boards David Wang
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 10+ messages in thread
From: David Wang @ 2022-05-31  1:10 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-kernel
  Cc: edward_chen, ben_pai, David Wang

Document jabil board compatible.

Signed-off-by: David Wang <David_Wang6097@jabil.com>
---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 5c9aa014432d..407cfbe85153 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -78,6 +78,7 @@ properties:
               - ibm,rainier-bmc
               - ibm,tacoma-bmc
               - inventec,transformer-bmc
+              - jabil,rbp-bmc  
               - nuvia,dc-scm-bmc
               - quanta,s6q-bmc
           - const: aspeed,ast2600
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH v5 2/3] dt-bindings: vendor-prefixes: document jabil vendors for Aspeed BMC boards
  2022-05-31  1:10 [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC David Wang
  2022-05-31  1:10 ` [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles David Wang
@ 2022-05-31  1:11 ` David Wang
  2022-05-31 10:24   ` Krzysztof Kozlowski
  2022-05-31 10:23 ` [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC Krzysztof Kozlowski
  2022-06-15 13:28 ` Pavel Machek
  3 siblings, 1 reply; 10+ messages in thread
From: David Wang @ 2022-05-31  1:11 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-kernel
  Cc: edward_chen, ben_pai, David Wang

Added Jabil vendor prefix for Aspeed SoC based BMC board manufacturers

Signed-off-by: David Wang <David_Wang6097@jabil.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 169f11ce4cc5..013ea02fb39a 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -638,6 +638,8 @@ patternProperties:
     description: Jiandangjing Technology Co., Ltd.
   "^joz,.*":
     description: JOZ BV
+  "^jabil,.*":
+    description: Jabil Design Service Branch (Sanchong)
   "^kam,.*":
     description: Kamstrup A/S
   "^karo,.*":
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC
  2022-05-31  1:10 [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC David Wang
  2022-05-31  1:10 ` [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles David Wang
  2022-05-31  1:11 ` [PATCH v5 2/3] dt-bindings: vendor-prefixes: document jabil vendors for Aspeed BMC boards David Wang
@ 2022-05-31 10:23 ` Krzysztof Kozlowski
  2022-06-15 13:28 ` Pavel Machek
  3 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-31 10:23 UTC (permalink / raw)
  To: David Wang, robh+dt, krzysztof.kozlowski+dt, devicetree, linux-kernel
  Cc: edward_chen, ben_pai

On 31/05/2022 03:10, David Wang wrote:
> The initial introduction of the jabil server with AST2600 BMC SoC.
> 
> ---
> 
> v5
> - Compatible value chamged to "jabil,rbp-bmc".
> 
> v4
> - Add document the new compatible.
> - Delete redundant blank lines.
> - Add a new line at end of file.
> 
> v3
> - Adjustment entries are ordered by name.
> - Remove the bootargs property and modify the stdout-path property.
> - Group multiple LED devices into a group.
> - Modify the "gpio3_71" node name format.
> - Delete unneeded blank line at the end.
> 
> v2
> - Disable empty i2c bus.
> - Remove gfx node because aspeed-g6.dtsi isn't supported.
> - Modify the led format and add some properties.
> - Fix wrong indentation.
> - Add stdout property in chosen node.
> - Rename temp to temperature-sensor in i2c bus 0.

Thanks for the changes.

> +&lpc_snoop {
> +	snoop-ports = <0x80>;
> +	status = "okay";
> +};
> +

You still have here additional blank line about which I already
commented. Then you removed both blank lines - this one and the usual
trailing one.

I mean... really... Just remove the unneeded one, leaving the proper
patch like every other file in Linux kernel.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles
  2022-05-31  1:10 ` [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles David Wang
@ 2022-05-31 10:23   ` Krzysztof Kozlowski
  2022-06-22 10:14   ` (subset) " Krzysztof Kozlowski
  1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-31 10:23 UTC (permalink / raw)
  To: David Wang, robh+dt, krzysztof.kozlowski+dt, devicetree, linux-kernel
  Cc: edward_chen, ben_pai

On 31/05/2022 03:10, David Wang wrote:
> Document jabil board compatible.
> 
> Signed-off-by: David Wang <David_Wang6097@jabil.com>
> ---

Thanks, this looks good. You however need cover letter explaining the
dependencies (on top of my patchset).


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v5 2/3] dt-bindings: vendor-prefixes: document jabil vendors for Aspeed BMC boards
  2022-05-31  1:11 ` [PATCH v5 2/3] dt-bindings: vendor-prefixes: document jabil vendors for Aspeed BMC boards David Wang
@ 2022-05-31 10:24   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-31 10:24 UTC (permalink / raw)
  To: David Wang, robh+dt, krzysztof.kozlowski+dt, devicetree, linux-kernel
  Cc: edward_chen, ben_pai

On 31/05/2022 03:11, David Wang wrote:
> Added Jabil vendor prefix for Aspeed SoC based BMC board manufacturers
> 
> Signed-off-by: David Wang <David_Wang6097@jabil.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 169f11ce4cc5..013ea02fb39a 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -638,6 +638,8 @@ patternProperties:
>      description: Jiandangjing Technology Co., Ltd.
>    "^joz,.*":
>      description: JOZ BV
> +  "^jabil,.*":

Still not properly ordered. "a" is before "o" in latin alphabet, so
please put the new entry in appropriate place.

> +    description: Jabil Design Service Branch (Sanchong)




Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC
  2022-05-31  1:10 [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC David Wang
                   ` (2 preceding siblings ...)
  2022-05-31 10:23 ` [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC Krzysztof Kozlowski
@ 2022-06-15 13:28 ` Pavel Machek
  3 siblings, 0 replies; 10+ messages in thread
From: Pavel Machek @ 2022-06-15 13:28 UTC (permalink / raw)
  To: David Wang
  Cc: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-kernel,
	edward_chen, ben_pai

Hi!

> The initial introduction of the jabil server with AST2600 BMC SoC.


> +		led-0 {
> +			label = "identify";
> +			color = <LED_COLOR_ID_BLUE>;
> +			function = LED_FUNCTION_INDICATOR;
> +			retain-state-shutdown;
> +			gpios = <&gpio0 ASPEED_GPIO(B, 7) GPIO_ACTIVE_LOW>;
> +		};
> +
> +		led-1 {
> +			label = "status_amber";
> +			label = "status_green";
> +			label = "status_susack";
> +		led-4 {
> +			label = "power-amber";
> +			label = "fan1-fault";

Please take a look at LED documentation and try to come up with something more in line
with existing conventions. Also please cc linux-leds list.

Best regards,
										Pavel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: (subset) [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles
  2022-05-31  1:10 ` [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles David Wang
  2022-05-31 10:23   ` Krzysztof Kozlowski
@ 2022-06-22 10:14   ` Krzysztof Kozlowski
  1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-22 10:14 UTC (permalink / raw)
  To: David_Wang6097, devicetree, linux-kernel, robh+dt,
	krzysztof.kozlowski+dt
  Cc: Krzysztof Kozlowski, edward_chen, ben_pai

On Tue, 31 May 2022 09:10:59 +0800, David Wang wrote:
> Document jabil board compatible.
> 
> 

Applied, thanks with fixing up the white space.

Please be sure git format-patch and checkpatch do not complain on your patches.

[3/3] dt-bindings: arm: aspeed: document board compatibles
      https://git.kernel.org/krzk/linux-dt/c/ae8980247d5af8528145713e07f1338abc57a00d

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles
  2022-06-01  8:08 ` [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles David Wang
@ 2022-06-01  8:21   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-01  8:21 UTC (permalink / raw)
  To: David Wang, robh+dt, krzysztof.kozlowski+dt, devicetree, linux-kernel
  Cc: edward_chen, ben_pai

On 01/06/2022 10:08, David Wang wrote:
> - Depends on Krzysztof Kozlowski's Document Board Compatibility Patch.
> - Document jabil board compatible.

This is not a proper cover letter.

https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L751

> 
> Signed-off-by: David Wang <David_Wang6097@jabil.com>
> ---
>  Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> index 5c9aa014432d..407cfbe85153 100644
> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> @@ -78,6 +78,7 @@ properties:
>                - ibm,rainier-bmc
>                - ibm,tacoma-bmc
>                - inventec,transformer-bmc
> +              - jabil,rbp-bmc  
>                - nuvia,dc-scm-bmc
>                - quanta,s6q-bmc
>            - const: aspeed,ast2600


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles
  2022-06-01  8:08 David Wang
@ 2022-06-01  8:08 ` David Wang
  2022-06-01  8:21   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 10+ messages in thread
From: David Wang @ 2022-06-01  8:08 UTC (permalink / raw)
  To: robh+dt, krzysztof.kozlowski+dt, devicetree, linux-kernel
  Cc: edward_chen, ben_pai, David Wang

- Depends on Krzysztof Kozlowski's Document Board Compatibility Patch.
- Document jabil board compatible.

Signed-off-by: David Wang <David_Wang6097@jabil.com>
---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
index 5c9aa014432d..407cfbe85153 100644
--- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
+++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
@@ -78,6 +78,7 @@ properties:
               - ibm,rainier-bmc
               - ibm,tacoma-bmc
               - inventec,transformer-bmc
+              - jabil,rbp-bmc  
               - nuvia,dc-scm-bmc
               - quanta,s6q-bmc
           - const: aspeed,ast2600
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-06-22 10:14 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-31  1:10 [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC David Wang
2022-05-31  1:10 ` [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles David Wang
2022-05-31 10:23   ` Krzysztof Kozlowski
2022-06-22 10:14   ` (subset) " Krzysztof Kozlowski
2022-05-31  1:11 ` [PATCH v5 2/3] dt-bindings: vendor-prefixes: document jabil vendors for Aspeed BMC boards David Wang
2022-05-31 10:24   ` Krzysztof Kozlowski
2022-05-31 10:23 ` [PATCH 1/3] ARM: dts: aspeed: Adding Jabil Rubypass BMC Krzysztof Kozlowski
2022-06-15 13:28 ` Pavel Machek
2022-06-01  8:08 David Wang
2022-06-01  8:08 ` [PATCH v5 3/3] dt-bindings: arm: aspeed: document board compatibles David Wang
2022-06-01  8:21   ` Krzysztof Kozlowski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.