From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Keith Busch <kbusch@fb.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
axboe@kernel.dk, Kernel Team <Kernel-team@fb.com>,
hch@lst.de, bvanassche@acm.org, ebiggers@kernel.org,
pankydev8@gmail.com, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv4 5/9] block: add a helper function for dio alignment
Date: Tue, 31 May 2022 08:22:27 +0200 [thread overview]
Message-ID: <20220531062227.GB21098@lst.de> (raw)
In-Reply-To: <fb8bd4ec-10bf-3a8a-dbb9-cdd4aeec7ebe@opensource.wdc.com>
On Thu, May 26, 2022 at 10:54:02AM +0900, Damien Le Moal wrote:
> Nit: The name of this helper really suggest a bool return, which would be a more
> flexible interface I think:
>
> if (!blkdev_dio_aligned(bdev, pos, iter))
> return -EINVAL; <-- or whatever error code the caller wants.
>
> And that will allow you to get rid of the ret variable in a least
> __blkdev_direct_IO_async.
I agree, a bool return looks more natural here.
Otherwise this looks good to me.
next prev parent reply other threads:[~2022-05-31 6:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 1:06 [PATCHv4 0/9] direct io dma alignment Keith Busch
2022-05-26 1:06 ` [PATCHv4 1/9] block: fix infiniate loop for invalid zone append Keith Busch
2022-05-26 1:48 ` Damien Le Moal
2022-05-31 6:19 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 2/9] block/bio: remove duplicate append pages code Keith Busch
2022-05-26 1:06 ` [PATCHv4 3/9] block: export dma_alignment attribute Keith Busch
2022-05-26 7:30 ` Eric Biggers
2022-05-26 1:06 ` [PATCHv4 4/9] block: introduce bdev_dma_alignment helper Keith Busch
2022-05-26 1:06 ` [PATCHv4 5/9] block: add a helper function for dio alignment Keith Busch
2022-05-26 1:54 ` Damien Le Moal
2022-05-31 6:22 ` Christoph Hellwig [this message]
2022-05-26 1:06 ` [PATCHv4 6/9] block/merge: count bytes instead of sectors Keith Busch
2022-05-26 1:57 ` Damien Le Moal
2022-05-31 6:25 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 7/9] block/bounce: " Keith Busch
2022-05-26 1:58 ` Damien Le Moal
2022-05-30 15:08 ` Pankaj Raghav
2022-05-31 6:26 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 8/9] block: relax direct io memory alignment Keith Busch
2022-05-26 2:03 ` Damien Le Moal
2022-05-26 7:29 ` Eric Biggers
2022-05-26 13:50 ` Keith Busch
2022-05-26 18:13 ` Eric Biggers
2022-05-26 18:55 ` Keith Busch
2022-05-26 20:32 ` Keith Busch
2022-05-31 6:30 ` Christoph Hellwig
2022-05-26 1:06 ` [PATCHv4 9/9] fs: add support for dma aligned direct-io Keith Busch
2022-05-26 2:01 ` Damien Le Moal
2022-05-31 6:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531062227.GB21098@lst.de \
--to=hch@lst.de \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=ebiggers@kernel.org \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pankydev8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.