From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1360C433EF for ; Tue, 31 May 2022 06:26:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244256AbiEaG0B (ORCPT ); Tue, 31 May 2022 02:26:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237554AbiEaG0B (ORCPT ); Tue, 31 May 2022 02:26:01 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A03A29345C; Mon, 30 May 2022 23:26:00 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id C1F1B68AFE; Tue, 31 May 2022 08:25:56 +0200 (CEST) Date: Tue, 31 May 2022 08:25:56 +0200 From: Christoph Hellwig To: Keith Busch Cc: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk, Kernel Team , hch@lst.de, bvanassche@acm.org, damien.lemoal@opensource.wdc.com, ebiggers@kernel.org, pankydev8@gmail.com, Keith Busch Subject: Re: [PATCHv4 6/9] block/merge: count bytes instead of sectors Message-ID: <20220531062556.GC21098@lst.de> References: <20220526010613.4016118-1-kbusch@fb.com> <20220526010613.4016118-7-kbusch@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220526010613.4016118-7-kbusch@fb.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, May 25, 2022 at 06:06:10PM -0700, Keith Busch wrote: > + /* > + * Individual bvecs may not be logical block aligned, so round down to > + * that size to ensure both sides of the split bio are appropriately > + * sized. > + */ Maybe I'd word this as: /* * Individual bvecs may not be logical block aligned. Round down * the split size so that each bio is properly sector size aligned, * even if we do not use the full hardware limits. */ Otherwise this looks good: Reviewed-by: Christoph Hellwig