Re: [PATCH v9 2/9] PCI: Replace magic constant for PCI Sig Vendor ID

From: Davidlohr Bueso <dave@stgolabs.net>
To: "ira.weiny@intel.com" <ira.weiny@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Ben Widawsky <ben@bwidawsk.net>,
	linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org,
	linux-pci@vger.kernel.org, a.manzanares@samsung.com
Subject: Re: [PATCH v9 2/9] PCI: Replace magic constant for PCI Sig Vendor ID
Date: Tue, 31 May 2022 10:00:50 -0700	[thread overview]
Message-ID: <20220531170050.ue6hizqjugz2g4wl@offworld> (raw)
In-Reply-To: <20220531152632.1397976-3-ira.weiny@intel.com>

On Tue, 31 May 2022, ira.weiny@intel.com wrote:

>From: Ira Weiny <ira.weiny@intel.com>
>
>Replace the magic value in pci_bus_crs_vendor_id() with
>PCI_VENDOR_ID_PCI_SIG.
>
>Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
>Acked-by: Bjorn Helgaas <bhelgaas@google.com>
>Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>

>---
>Changes from V6
>	Simplify commit message
>---
> drivers/pci/probe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
>index 17a969942d37..6280e780a48c 100644
>--- a/drivers/pci/probe.c
>+++ b/drivers/pci/probe.c
>@@ -2312,7 +2312,7 @@ EXPORT_SYMBOL(pci_alloc_dev);
>
> static bool pci_bus_crs_vendor_id(u32 l)
> {
>-	return (l & 0xffff) == 0x0001;
>+	return (l & 0xffff) == PCI_VENDOR_ID_PCI_SIG;
> }
>
> static bool pci_bus_wait_crs(struct pci_bus *bus, int devfn, u32 *l,
>
>-- 
>2.35.1
>