All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: Bhargav R <bgvmysore@gmail.com>
Cc: meta-arago@lists.yoctoproject.org, reatmon@ti.com, denys@konsulko.com
Subject: Re: [meta-arago] [PATCH] meta-arago-distro: classes: image_types_md5.bbclass: Fix hardcoded filename containing .rootfs to use IMAGE_NAME_SUFFIX.
Date: Tue, 31 May 2022 15:35:06 -0400	[thread overview]
Message-ID: <20220531193506.GD9834@denix.org> (raw)
In-Reply-To: <20220528081806.11354-1-bgvmysore@gmail.com>

On Sat, May 28, 2022 at 01:48:06PM +0530, Bhargav R wrote:
> From: bgvmysore <bgvmysore@gmail.com>
> 
> The filename for md5sum is is hardcoded with .rootfs as suffix.
> The build fails in do_image_tar if IMAGE_NAME_SUFFIX is set to a different value.
> Changing '.rootfs' to ${IMAGE_NAME_SUFFIX} to fix this issue.

FWIW, this is specific to Dunfell and this class is completely deprecated in 
master/Kirkstone.


> Signed-off-by: Bhargav Raviprakash <bgvmysore@gmail.com>
> ---
>  meta-arago-distro/classes/image_types_md5.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-arago-distro/classes/image_types_md5.bbclass b/meta-arago-distro/classes/image_types_md5.bbclass
> index 9e2c04fa..4712e1a1 100644
> --- a/meta-arago-distro/classes/image_types_md5.bbclass
> +++ b/meta-arago-distro/classes/image_types_md5.bbclass
> @@ -1,9 +1,9 @@
>  inherit image_types
>  
>  COMPRESSIONTYPES += "gz.md5"
> -COMPRESS_CMD_gz.md5 = "${COMPRESS_CMD_gz}; md5sum ${IMAGE_NAME}.rootfs.${type}.gz > ${IMAGE_NAME}.rootfs.${type}.gz.md5"
> +COMPRESS_CMD_gz.md5 = "${COMPRESS_CMD_gz}; md5sum ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.gz.md5"
>  IMAGE_TYPES += "tar.gz.md5"
>  
>  COMPRESSIONTYPES += "xz.md5"
> -COMPRESS_CMD_xz.md5 = "${COMPRESS_CMD_xz}; md5sum ${IMAGE_NAME}.rootfs.${type}.xz > ${IMAGE_NAME}.rootfs.${type}.xz.md5"
> +COMPRESS_CMD_xz.md5 = "${COMPRESS_CMD_xz}; md5sum ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.xz > ${IMAGE_NAME}${IMAGE_NAME_SUFFIX}.${type}.xz.md5"
>  IMAGE_TYPES += "tar.xz.md5"
> -- 
> 2.34.1


           reply	other threads:[~2022-05-31 19:35 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20220528081806.11354-1-bgvmysore@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220531193506.GD9834@denix.org \
    --to=denis@denix.org \
    --cc=bgvmysore@gmail.com \
    --cc=denys@konsulko.com \
    --cc=meta-arago@lists.yoctoproject.org \
    --cc=reatmon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.