From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: [ammarfaizi2-block:dhowells/linux-fs/cifs-netfs 21/41] fs/netfs/buffered_read.c:262:12-13: WARNING opportunity for min()
Date: Wed, 01 Jun 2022 00:46:43 +0800 [thread overview]
Message-ID: <202206010053.m39d9soU-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 5443 bytes --]
CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
CC: linux-kernel(a)vger.kernel.org
TO: David Howells <dhowells@redhat.com>
tree: https://github.com/ammarfaizi2/linux-block dhowells/linux-fs/cifs-netfs
head: 1fc71b6b30f6d2a981c163b77c9aee0aecaecb29
commit: 7dda728e404354bcb6e11492413a1e92fe16b35d [21/41] netfs: Implement support for DIO read
:::::: branch date: 2 days ago
:::::: commit date: 4 days ago
config: openrisc-randconfig-c003-20220531 (https://download.01.org/0day-ci/archive/20220601/202206010053.m39d9soU-lkp(a)intel.com/config)
compiler: or1k-linux-gcc (GCC) 11.3.0
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>)
>> fs/netfs/buffered_read.c:262:12-13: WARNING opportunity for min()
vim +262 fs/netfs/buffered_read.c
16211268fcb366 David Howells 2022-03-01 214
16211268fcb366 David Howells 2022-03-01 215 /**
16211268fcb366 David Howells 2022-03-01 216 * netfs_readpage - Helper to manage a readpage request
16211268fcb366 David Howells 2022-03-01 217 * @file: The file to read from
16211268fcb366 David Howells 2022-03-01 218 * @subpage: A subpage of the folio to read
16211268fcb366 David Howells 2022-03-01 219 *
16211268fcb366 David Howells 2022-03-01 220 * Fulfil a readpage request by drawing data from the cache if possible, or the
16211268fcb366 David Howells 2022-03-01 221 * netfs if not. Space beyond the EOF is zero-filled. Multiple I/O requests
16211268fcb366 David Howells 2022-03-01 222 * from different sources will get munged together.
16211268fcb366 David Howells 2022-03-01 223 *
16211268fcb366 David Howells 2022-03-01 224 * The calling netfs must initialise a netfs context contiguous to the vfs
16211268fcb366 David Howells 2022-03-01 225 * inode before calling this.
16211268fcb366 David Howells 2022-03-01 226 *
16211268fcb366 David Howells 2022-03-01 227 * This is usable whether or not caching is enabled.
16211268fcb366 David Howells 2022-03-01 228 */
16211268fcb366 David Howells 2022-03-01 229 int netfs_readpage(struct file *file, struct page *subpage)
16211268fcb366 David Howells 2022-03-01 230 {
16211268fcb366 David Howells 2022-03-01 231 struct folio *folio = page_folio(subpage);
16211268fcb366 David Howells 2022-03-01 232 struct address_space *mapping = folio_file_mapping(folio);
16211268fcb366 David Howells 2022-03-01 233 struct netfs_io_request *rreq;
16211268fcb366 David Howells 2022-03-01 234 struct netfs_i_context *ctx = netfs_i_context(mapping->host);
7dda728e404354 David Howells 2022-01-14 235 ssize_t ret;
16211268fcb366 David Howells 2022-03-01 236
16211268fcb366 David Howells 2022-03-01 237 _enter("%lx", folio_index(folio));
16211268fcb366 David Howells 2022-03-01 238
16211268fcb366 David Howells 2022-03-01 239 rreq = netfs_alloc_request(mapping, file,
16211268fcb366 David Howells 2022-03-01 240 folio_file_pos(folio), folio_size(folio),
16211268fcb366 David Howells 2022-03-01 241 NETFS_READPAGE);
16211268fcb366 David Howells 2022-03-01 242 if (IS_ERR(rreq)) {
16211268fcb366 David Howells 2022-03-01 243 ret = PTR_ERR(rreq);
16211268fcb366 David Howells 2022-03-01 244 goto alloc_error;
16211268fcb366 David Howells 2022-03-01 245 }
16211268fcb366 David Howells 2022-03-01 246
81b451668a2656 David Howells 2021-08-10 247 ret = netfs_begin_cache_operation(rreq, ctx);
16211268fcb366 David Howells 2022-03-01 248 if (ret == -ENOMEM || ret == -EINTR || ret == -ERESTARTSYS)
16211268fcb366 David Howells 2022-03-01 249 goto discard;
16211268fcb366 David Howells 2022-03-01 250
16211268fcb366 David Howells 2022-03-01 251 netfs_stat(&netfs_n_rh_readpage);
16211268fcb366 David Howells 2022-03-01 252 trace_netfs_read(rreq, rreq->start, rreq->len, netfs_read_trace_readpage);
c1e70ea1e5b0be David Howells 2021-07-09 253
c1e70ea1e5b0be David Howells 2021-07-09 254 /* Set up the output buffer */
c1e70ea1e5b0be David Howells 2021-07-09 255 rreq->buffering = NETFS_BUFFER;
c1e70ea1e5b0be David Howells 2021-07-09 256 ret = netfs_set_up_buffer(&rreq->buffer, rreq->mapping, NULL, folio,
c1e70ea1e5b0be David Howells 2021-07-09 257 folio_index(folio), folio_nr_pages(folio));
c1e70ea1e5b0be David Howells 2021-07-09 258 if (ret < 0)
c1e70ea1e5b0be David Howells 2021-07-09 259 goto discard;
c1e70ea1e5b0be David Howells 2021-07-09 260
7dda728e404354 David Howells 2022-01-14 261 ret = netfs_begin_read(rreq, true);
7dda728e404354 David Howells 2022-01-14 @262 return ret < 0 ? ret : 0;
16211268fcb366 David Howells 2022-03-01 263
16211268fcb366 David Howells 2022-03-01 264 discard:
16211268fcb366 David Howells 2022-03-01 265 netfs_put_request(rreq, false, netfs_rreq_trace_put_discard);
16211268fcb366 David Howells 2022-03-01 266 alloc_error:
16211268fcb366 David Howells 2022-03-01 267 folio_unlock(folio);
16211268fcb366 David Howells 2022-03-01 268 return ret;
16211268fcb366 David Howells 2022-03-01 269 }
16211268fcb366 David Howells 2022-03-01 270 EXPORT_SYMBOL(netfs_readpage);
16211268fcb366 David Howells 2022-03-01 271
--
0-DAY CI Kernel Test Service
https://01.org/lkp
reply other threads:[~2022-05-31 16:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202206010053.m39d9soU-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.