All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: airlied@redhat.com, jfalempe@redhat.com, airlied@linux.ie,
	daniel@ffwll.ch
Cc: Thomas Zimmermann <tzimmermann@suse.de>, dri-devel@lists.freedesktop.org
Subject: [PATCH 00/10] drm/mgag200: Convert device init to use device-info structure
Date: Wed,  1 Jun 2022 13:25:12 +0200	[thread overview]
Message-ID: <20220601112522.5774-1-tzimmermann@suse.de> (raw)

Convert the device-init code to use a device-info structure for each
model. The device info contains constants and flags that were previously
located in different places of the code.

Also refactor the PCI and VRAM initialization handling. A later patchset
could convert the PCI magic numbers into constants.

For modesetting, the per-model init functions currently don't do much.
This will change when more model-specific code gets moved there. The
modesetting and PLL code contains model-specific handling that should
be refactored.

Tested with G200 and G200EV hardware.

Thomas Zimmermann (10):
  drm/mgag200: Remove special case for G200SE with <2 MiB
  drm/mgag200: Initialize each model in separate function
  drm/mgag200: Move PCI-option setup into model-specific code
  drm/mgag200: Call mgag200_device_probe_vram() from per-model init
  drm/mgag200: Implement new init logic
  drm/mgag200: Add struct mgag200_device_info
  drm/mgag200: Store HW_BUG_NO_STARTADD flag in device info
  drm/mgag200: Store maximum resolution and memory bandwith in device
    info
  drm/mgag200: Store vidrst flag in device info
  drm/mgag200: Store positions of I2C data and clock bits in device info

 drivers/gpu/drm/mgag200/Makefile          |  14 +-
 drivers/gpu/drm/mgag200/mgag200_drv.c     | 386 ++++++++--------------
 drivers/gpu/drm/mgag200/mgag200_drv.h     | 135 ++++++--
 drivers/gpu/drm/mgag200/mgag200_g200.c    | 200 +++++++++++
 drivers/gpu/drm/mgag200/mgag200_g200eh.c  |  50 +++
 drivers/gpu/drm/mgag200/mgag200_g200eh3.c |  51 +++
 drivers/gpu/drm/mgag200/mgag200_g200er.c  |  46 +++
 drivers/gpu/drm/mgag200/mgag200_g200ev.c  |  50 +++
 drivers/gpu/drm/mgag200/mgag200_g200ew3.c |  60 ++++
 drivers/gpu/drm/mgag200/mgag200_g200se.c  | 130 ++++++++
 drivers/gpu/drm/mgag200/mgag200_g200wb.c  |  50 +++
 drivers/gpu/drm/mgag200/mgag200_i2c.c     |  27 +-
 drivers/gpu/drm/mgag200/mgag200_mm.c      | 116 -------
 drivers/gpu/drm/mgag200/mgag200_mode.c    | 100 ++----
 drivers/gpu/drm/mgag200/mgag200_pll.c     |  12 +-
 drivers/gpu/drm/mgag200/mgag200_reg.h     |   2 +
 16 files changed, 942 insertions(+), 487 deletions(-)
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200eh.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200eh3.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200er.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200ev.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200ew3.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200se.c
 create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200wb.c
 delete mode 100644 drivers/gpu/drm/mgag200/mgag200_mm.c


base-commit: 2c8cc5cd20e28afe6b63acb28890e5f57d9bf055
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
-- 
2.36.1


             reply	other threads:[~2022-06-01 11:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01 11:25 Thomas Zimmermann [this message]
2022-06-01 11:25 ` [PATCH 01/10] drm/mgag200: Remove special case for G200SE with <2 MiB Thomas Zimmermann
2022-06-01 11:25 ` [PATCH 02/10] drm/mgag200: Initialize each model in separate function Thomas Zimmermann
2022-06-01 11:25 ` [PATCH 03/10] drm/mgag200: Move PCI-option setup into model-specific code Thomas Zimmermann
2022-06-01 11:25 ` [PATCH 04/10] drm/mgag200: Call mgag200_device_probe_vram() from per-model init Thomas Zimmermann
2022-06-01 11:25 ` [PATCH 05/10] drm/mgag200: Implement new init logic Thomas Zimmermann
2022-06-01 11:25 ` [PATCH 06/10] drm/mgag200: Add struct mgag200_device_info Thomas Zimmermann
2022-06-01 11:25 ` [PATCH 07/10] drm/mgag200: Store HW_BUG_NO_STARTADD flag in device info Thomas Zimmermann
2022-06-01 11:25 ` [PATCH 08/10] drm/mgag200: Store maximum resolution and memory bandwith " Thomas Zimmermann
2022-06-01 11:25 ` [PATCH 09/10] drm/mgag200: Store vidrst flag " Thomas Zimmermann
2022-06-01 11:25 ` [PATCH 10/10] drm/mgag200: Store positions of I2C data and clock bits " Thomas Zimmermann
2022-06-02  9:52 ` [PATCH 00/10] drm/mgag200: Convert device init to use device-info structure Jocelyn Falempe
2022-06-02 11:07   ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220601112522.5774-1-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jfalempe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.