From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D62C433EF for ; Wed, 1 Jun 2022 20:54:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230292AbiFAUyp (ORCPT ); Wed, 1 Jun 2022 16:54:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230124AbiFAUyp (ORCPT ); Wed, 1 Jun 2022 16:54:45 -0400 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15026212C8E for ; Wed, 1 Jun 2022 13:54:28 -0700 (PDT) Received: by mail-pg1-x549.google.com with SMTP id q13-20020a65624d000000b003fa74c57243so1465739pgv.19 for ; Wed, 01 Jun 2022 13:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=MtH8Hz1X124NCWwEXnuLD44TX9SlL7+U3QIB1SL8T2g=; b=H+zlnQUyQ7wgiN5l7ikqahpCnKh+GmSJ6KYEP2NY9Evx31r2htc7pgEbabKn+WEDMp LSRCLZFslgH3grnQnRQu0hyQ7UHu6eP3v1ywzD/my7hdflbAJ3xpVEnwpULfj3Hpo3Oc 63XH8kvnROK/FH9EbgwEG0FI8H6gKC6UOW0FMC84/ekIOeEhVm4a5tbTzppYfq4Vxev+ 4wrgQkEs3akijG9Z/RMAL1GVxs0bAXIkRM8BKgAByB9FS8h2BdZI2zaWinxXdM5LdIAa OgDpH4dwuK2pNLmO3hNRJ+Dlzf3rO8DMsURGJ/dbD8i22nNB5c9HeGiop88rjVh1A1+P TBFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=MtH8Hz1X124NCWwEXnuLD44TX9SlL7+U3QIB1SL8T2g=; b=jC203cWZxlg/ut9wC+J0Sl6neT4zw8Kg5afQ+NiciGHtPlaTqMlJqyS49cVOv55E8I elOV5MkQog9tpa7TP+1KBMD1bz//HFFWF9mT9+rQXPSATLm0hRUKgZxYt31xNKXtChq5 M4g6JFRCv9crORmWZbZ8Xgg+uL/n8waw87iLsLTbjtPFCB3kP4TSBUHLZbi0A3CxDp1D eOukQxvzssxLJL3mWK3SB+jKBstyQs7f2a+tDZU8cX2As7QI0va6l4bnZfW/op+HpZ28 GNfstUyaBQpsD1r6edRwj+cwJ0sHStGI9uVDxKSPgreK5f4TToEyXwEwcUjUX4gIiiJc n6bw== X-Gm-Message-State: AOAM533sYxeANTqTaHMFYPa1YDuy59PT12lQUYFa7gWTqb0UULXJdTp6 wyvHGc517G1Idc/mCz8SbTEE3Ac= X-Google-Smtp-Source: ABdhPJw8yDf18Kwulq7LUUNeI3POC5BlyGQGYNYGIkmaGrakDJMu3Zn8PP4V73Mn/uh+GBEgI4Hdc6Q= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a17:903:11d0:b0:156:6c35:9588 with SMTP id q16-20020a17090311d000b001566c359588mr880028plh.50.1654110159080; Wed, 01 Jun 2022 12:02:39 -0700 (PDT) Date: Wed, 1 Jun 2022 12:02:18 -0700 In-Reply-To: <20220601190218.2494963-1-sdf@google.com> Message-Id: <20220601190218.2494963-12-sdf@google.com> Mime-Version: 1.0 References: <20220601190218.2494963-1-sdf@google.com> X-Mailer: git-send-email 2.36.1.255.ge46751e96f-goog Subject: [PATCH bpf-next v8 11/11] selftests/bpf: verify lsm_cgroup struct sock access From: Stanislav Fomichev To: netdev@vger.kernel.org, bpf@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, Stanislav Fomichev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org sk_priority & sk_mark are writable, the rest is readonly. One interesting thing here is that the verifier doesn't really force me to add NULL checks anywhere :-/ Signed-off-by: Stanislav Fomichev --- .../selftests/bpf/prog_tests/lsm_cgroup.c | 69 +++++++++++++++++++ 1 file changed, 69 insertions(+) diff --git a/tools/testing/selftests/bpf/prog_tests/lsm_cgroup.c b/tools/testing/selftests/bpf/prog_tests/lsm_cgroup.c index a96057ec7dd4..a730acd9dfdd 100644 --- a/tools/testing/selftests/bpf/prog_tests/lsm_cgroup.c +++ b/tools/testing/selftests/bpf/prog_tests/lsm_cgroup.c @@ -270,8 +270,77 @@ static void test_lsm_cgroup_functional(void) lsm_cgroup__destroy(skel); } +static int field_offset(const char *type, const char *field) +{ + const struct btf_member *memb; + const struct btf_type *tp; + const char *name; + struct btf *btf; + int btf_id; + int i; + + btf = btf__load_vmlinux_btf(); + if (!btf) + return -1; + + btf_id = btf__find_by_name_kind(btf, type, BTF_KIND_STRUCT); + if (btf_id < 0) + return -1; + + tp = btf__type_by_id(btf, btf_id); + memb = btf_members(tp); + + for (i = 0; i < btf_vlen(tp); i++) { + name = btf__name_by_offset(btf, + memb->name_off); + if (strcmp(field, name) == 0) + return memb->offset / 8; + memb++; + } + + return -1; +} + +static bool sk_writable_field(const char *type, const char *field, int size) +{ + LIBBPF_OPTS(bpf_prog_load_opts, opts, + .expected_attach_type = BPF_LSM_CGROUP); + struct bpf_insn insns[] = { + /* r1 = *(u64 *)(r1 + 0) */ + BPF_LDX_MEM(BPF_DW, BPF_REG_1, BPF_REG_1, 0), + /* r1 = *(u64 *)(r1 + offsetof(struct socket, sk)) */ + BPF_LDX_MEM(BPF_DW, BPF_REG_1, BPF_REG_1, field_offset("socket", "sk")), + /* r2 = *(u64 *)(r1 + offsetof(struct sock, )) */ + BPF_LDX_MEM(size, BPF_REG_2, BPF_REG_1, field_offset(type, field)), + /* *(u64 *)(r1 + offsetof(struct sock, )) = r2 */ + BPF_STX_MEM(size, BPF_REG_1, BPF_REG_2, field_offset(type, field)), + BPF_MOV64_IMM(BPF_REG_0, 1), + BPF_EXIT_INSN(), + }; + int fd; + + opts.attach_btf_id = libbpf_find_vmlinux_btf_id("socket_post_create", + opts.expected_attach_type); + + fd = bpf_prog_load(BPF_PROG_TYPE_LSM, NULL, "GPL", insns, ARRAY_SIZE(insns), &opts); + if (fd >= 0) + close(fd); + return fd >= 0; +} + +static void test_lsm_cgroup_access(void) +{ + ASSERT_FALSE(sk_writable_field("sock_common", "skc_family", BPF_H), "skc_family"); + ASSERT_FALSE(sk_writable_field("sock", "sk_sndtimeo", BPF_DW), "sk_sndtimeo"); + ASSERT_TRUE(sk_writable_field("sock", "sk_priority", BPF_W), "sk_priority"); + ASSERT_TRUE(sk_writable_field("sock", "sk_mark", BPF_W), "sk_mark"); + ASSERT_FALSE(sk_writable_field("sock", "sk_pacing_rate", BPF_DW), "sk_pacing_rate"); +} + void test_lsm_cgroup(void) { if (test__start_subtest("functional")) test_lsm_cgroup_functional(); + if (test__start_subtest("access")) + test_lsm_cgroup_access(); } -- 2.36.1.255.ge46751e96f-goog