All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Lingshan <lingshan.zhu@intel.com>
To: jasowang@redhat.com, mst@redhat.com
Cc: virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, Zhu Lingshan <lingshan.zhu@intel.com>
Subject: [PATCH 1/6] vDPA/ifcvf: get_config_size should return a value no greater than dev implementation
Date: Thu,  2 Jun 2022 10:38:40 +0800	[thread overview]
Message-ID: <20220602023845.2596397-2-lingshan.zhu@intel.com> (raw)
In-Reply-To: <20220602023845.2596397-1-lingshan.zhu@intel.com>

ifcvf_get_config_size() should return a virtio device type specific value,
however the ret_value should not be greater than the onboard size of
the device implementation. E.g., for virtio_net, config_size should be
the minimum value of sizeof(struct virtio_net_config) and the onboard
cap size.

Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
---
 drivers/vdpa/ifcvf/ifcvf_base.c | 8 ++++++--
 drivers/vdpa/ifcvf/ifcvf_base.h | 2 ++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf/ifcvf_base.c
index 48c4dadb0c7c..6bccc8291c26 100644
--- a/drivers/vdpa/ifcvf/ifcvf_base.c
+++ b/drivers/vdpa/ifcvf/ifcvf_base.c
@@ -128,6 +128,7 @@ int ifcvf_init_hw(struct ifcvf_hw *hw, struct pci_dev *pdev)
 			break;
 		case VIRTIO_PCI_CAP_DEVICE_CFG:
 			hw->dev_cfg = get_cap_addr(hw, &cap);
+			hw->cap_dev_config_size = le32_to_cpu(cap.length);
 			IFCVF_DBG(pdev, "hw->dev_cfg = %p\n", hw->dev_cfg);
 			break;
 		}
@@ -233,15 +234,18 @@ int ifcvf_verify_min_features(struct ifcvf_hw *hw, u64 features)
 u32 ifcvf_get_config_size(struct ifcvf_hw *hw)
 {
 	struct ifcvf_adapter *adapter;
+	u32 net_config_size = sizeof(struct virtio_net_config);
+	u32 blk_config_size = sizeof(struct virtio_blk_config);
+	u32 cap_size = hw->cap_dev_config_size;
 	u32 config_size;
 
 	adapter = vf_to_adapter(hw);
 	switch (hw->dev_type) {
 	case VIRTIO_ID_NET:
-		config_size = sizeof(struct virtio_net_config);
+		config_size = cap_size >= net_config_size ? net_config_size : cap_size;
 		break;
 	case VIRTIO_ID_BLOCK:
-		config_size = sizeof(struct virtio_blk_config);
+		config_size = cap_size >= blk_config_size ? blk_config_size : cap_size;
 		break;
 	default:
 		config_size = 0;
diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h b/drivers/vdpa/ifcvf/ifcvf_base.h
index 115b61f4924b..f5563f665cc6 100644
--- a/drivers/vdpa/ifcvf/ifcvf_base.h
+++ b/drivers/vdpa/ifcvf/ifcvf_base.h
@@ -87,6 +87,8 @@ struct ifcvf_hw {
 	int config_irq;
 	int vqs_reused_irq;
 	u16 nr_vring;
+	/* VIRTIO_PCI_CAP_DEVICE_CFG size */
+	u32 cap_dev_config_size;
 };
 
 struct ifcvf_adapter {
-- 
2.31.1


  reply	other threads:[~2022-06-02  2:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02  2:38 [PATCH 0/6] ifcvf/vDPA: support query device config space through netlink Zhu Lingshan
2022-06-02  2:38 ` Zhu Lingshan [this message]
2022-06-02  7:11   ` [PATCH 1/6] vDPA/ifcvf: get_config_size should return a value no greater than dev implementation Jason Wang
2022-06-02  7:11     ` Jason Wang
2022-06-06  8:17     ` Zhu, Lingshan
2022-06-02  2:38 ` [PATCH 2/6] vDPA/ifcvf: support userspace to query features and MQ of a management device Zhu Lingshan
2022-06-02  7:21   ` Jason Wang
2022-06-02  7:21     ` Jason Wang
2022-06-06  8:18     ` Zhu, Lingshan
2022-06-02  2:38 ` [PATCH 3/6] vDPA/ifcvf: support userspace to query device feature bits Zhu Lingshan
2022-06-02  7:32   ` Jason Wang
2022-06-02  7:32     ` Jason Wang
2022-06-02  7:46     ` Eli Cohen
2022-06-06  8:24       ` Zhu, Lingshan
2022-06-02  2:38 ` [PATCH 4/6] vDPA: !FEATURES_OK should not block querying device config space Zhu Lingshan
2022-06-02  7:36   ` Jason Wang
2022-06-02  7:36     ` Jason Wang
2022-06-06  8:19     ` Zhu, Lingshan
2022-06-02  2:38 ` [PATCH 5/6] vDPA: answer num of queue pairs = 1 to userspace when VIRTIO_NET_F_MQ == 0 Zhu Lingshan
2022-06-02  7:38   ` Jason Wang
2022-06-02  7:38     ` Jason Wang
2022-06-06  8:21     ` Zhu, Lingshan
2022-06-07  6:14       ` Jason Wang
2022-06-07  6:14         ` Jason Wang
2022-06-07  8:40         ` Zhu, Lingshan
2022-06-02  2:38 ` [PATCH 6/6] vDPA: fix 'cast to restricted le16' warnings in vdpa_dev_net_config_fill() Zhu Lingshan
2022-06-02  7:40   ` Jason Wang
2022-06-02  7:40     ` Jason Wang
2022-06-06  8:22     ` Zhu, Lingshan
2022-06-07  6:15       ` Jason Wang
2022-06-07  6:15         ` Jason Wang
2022-06-07  6:41         ` Zhu, Lingshan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220602023845.2596397-2-lingshan.zhu@intel.com \
    --to=lingshan.zhu@intel.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.