Re: [PATCH 0/4] clean up zero-length arrays

From: Stephen Hemminger <stephen@networkplumber.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [PATCH 0/4] clean up zero-length arrays
Date: Thu, 2 Jun 2022 08:35:09 -0700	[thread overview]
Message-ID: <20220602083509.1b71d418@hermes.local> (raw)
In-Reply-To: <20220602150834.643745-1-bruce.richardson@intel.com>

On Thu,  2 Jun 2022 16:08:30 +0100
Bruce Richardson <bruce.richardson@intel.com> wrote:

> This patchset adds a coccinelle script to clean-up zero-length
> arrays in structures. The final patches are the result of running
> that script on the DPDK repository.
> 
> Bruce Richardson (4):
>   cocci: add script for zero-length arrays in structs
>   drivers: replace zero-length arrays with undimensioned ones
>   lib: replace zero-length arrays with undimensioned ones
>   app: examples: replace zero-length arrays with undimensioned ones
> 
>  app/test/test_table_tables.c                  |  2 +-
>  devtools/cocci/zero_length_array.cocci        | 21 +++++++++++++++
>  drivers/bus/dpaa/include/netcfg.h             |  4 +--
>  drivers/bus/vmbus/rte_vmbus_reg.h             |  4 +--
>  drivers/common/cnxk/roc_se.h                  |  2 +-
>  drivers/common/dpaax/caamflib/desc/ipsec.h    |  2 +-
>  drivers/common/dpaax/dpaax_iova_table.h       |  2 +-
>  drivers/common/mlx5/mlx5_prm.h                | 10 +++----
>  drivers/crypto/ipsec_mb/ipsec_mb_private.h    |  4 +--
>  drivers/crypto/virtio/virtio_ring.h           |  4 +--
>  drivers/crypto/virtio/virtqueue.h             |  2 +-
>  drivers/net/atlantic/hw_atl/hw_atl_utils.h    |  2 +-
>  drivers/net/cxgbe/clip_tbl.h                  |  2 +-
>  drivers/net/cxgbe/l2t.h                       |  2 +-
>  drivers/net/cxgbe/mps_tcam.h                  |  2 +-
>  drivers/net/cxgbe/smt.h                       |  2 +-
>  drivers/net/enic/base/vnic_devcmd.h           |  2 +-
>  drivers/net/hinic/hinic_pmd_tx.h              |  2 +-
>  drivers/net/mlx5/mlx5_tx.h                    |  2 +-
>  drivers/net/nfp/nfpcore/nfp_nsp.h             |  2 +-
>  drivers/net/virtio/virtio_ring.h              |  4 +--
>  drivers/net/virtio/virtio_user/vhost_kernel.c |  2 +-
>  drivers/net/virtio/virtio_user/vhost_vdpa.c   |  2 +-
>  drivers/net/virtio/virtqueue.h                |  2 +-
>  drivers/regex/mlx5/mlx5_rxp.h                 |  4 +--
>  examples/ip_reassembly/main.c                 |  2 +-
>  examples/ptpclient/ptpclient.c                |  4 +--
>  lib/cryptodev/cryptodev_pmd.h                 |  2 +-
>  lib/cryptodev/rte_cryptodev.h                 |  2 +-
>  lib/eventdev/rte_event_timer_adapter.h        |  2 +-
>  lib/ip_frag/ip_reassembly.h                   |  2 +-
>  lib/ipsec/sa.h                                |  2 +-
>  lib/rib/rte_rib.c                             |  2 +-
>  lib/rib/rte_rib6.c                            |  2 +-
>  lib/table/rte_swx_table_learner.c             |  4 +--
>  lib/table/rte_table_hash_key16.c              |  4 +--
>  lib/table/rte_table_hash_key32.c              |  4 +--
>  lib/table/rte_table_hash_key8.c               |  4 +--
>  lib/vhost/rte_vhost.h                         |  4 +--
>  40 files changed, 101 insertions(+), 54 deletions(-)
>  create mode 100644 devtools/cocci/zero_length_array.cocci
>  create mode 100644 lib/count_comments.py
> 
> --
> 2.34.1
> 

Series-acked-by: Stephen Hemminger <stephen@networkplumber.org>

Would it be possible to add check for zero length arrays in checkpatch?
So that new drivers don't bring the problem back.