From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B563CC433EF for ; Thu, 2 Jun 2022 11:20:47 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 917A584323; Thu, 2 Jun 2022 13:20:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 030978431C; Thu, 2 Jun 2022 13:02:56 +0200 (CEST) Received: from mx1.tinet.cat (mx1.dipta.cat [195.76.233.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5CAE183E8A for ; Thu, 2 Jun 2022 13:02:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=tinet.cat Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xdrudis@tinet.cat X-ASG-Debug-ID: 1654167733-12aaf267664c0ef0001-4l7tJC Received: from smtp01.tinet.cat (smtp.tinet.org [195.77.216.131]) by mx1.tinet.cat with ESMTP id 4JHqQR6TKc9QWeQu; Thu, 02 Jun 2022 13:02:13 +0200 (CEST) X-Barracuda-Envelope-From: xdrudis@tinet.cat X-Barracuda-Effective-Source-IP: smtp.tinet.org[195.77.216.131] X-Barracuda-Apparent-Source-IP: 195.77.216.131 Received: from begut (50.red-79-152-182.dynamicip.rima-tde.net [79.152.182.50]) by smtp01.tinet.cat (Postfix) with ESMTPSA id 2198B605D0AC; Thu, 2 Jun 2022 13:02:13 +0200 (CEST) Date: Thu, 2 Jun 2022 13:02:00 +0200 From: Xavier Drudis Ferran To: u-boot@lists.denx.de Cc: sjg@chromium.org, philipp.tomsich@vrull.eu, kever.yang@rock-chips.com, lukma@denx.de, seanga2@gmail.com Subject: [PATCH 0/3] arm: rockchip: rk3399: rock-pi-4: power domain driver to boot from MMCSD Message-ID: <20220602110200.GB1727@begut> X-ASG-Orig-Subj: [PATCH 0/3] arm: rockchip: rk3399: rock-pi-4: power domain driver to boot from MMCSD MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Barracuda-Connect: smtp.tinet.org[195.77.216.131] X-Barracuda-Start-Time: 1654167733 X-Barracuda-URL: https://webmail.tinet.cat:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 1443 X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.8855 1.0000 3.0730 X-Barracuda-Spam-Score: 3.07 X-Barracuda-Spam-Status: No, SCORE=3.07 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=6.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.98432 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-Mailman-Approved-At: Thu, 02 Jun 2022 13:20:24 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hello. I've been trying to compile myself all the stack to boot a Radxa Rock Pi 4B. I've found and worked around a few issues and I'm starting to select, clean up and send the patches I used. Since I'm new to the project I may have overseen something obvious. If so sorry. For the rest I hope something can be useful to others. Likewise I've found a couple of suspicions lines in clk_rk3399.c, but since I haven't found cases where they give problems, I should not send changes, or should I? This series is the minimum I needed to be able to boot linux-libre from a SD card, which wasn't possible for me just from master. It still displays some errors, but I leave them for later because it boots. The series is basically about trying not to overlap ATF, enabling a couple of clocks that MMCSD uses, and adding a power domain driver for rockchip, since I guess the DTS must have been updated from linux and the board may have worked before but the new DTS maybe broke boot from SD. I'm not sure why power domain drivers in U-Boot leave the clocks they need enabled, but I tried to disable them once powered up and it didn't boot. If people wants to test with other rockchip SOCs that'd be welcome, but I'm not sure whether they need the new driver. For now I only configured it for Rock Pi 4. Thanks beforehand for any feedback. Specially if I should run any tests. -- Xavier Drudis Ferran