From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC45C43334 for ; Thu, 2 Jun 2022 11:24:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234122AbiFBLYk (ORCPT ); Thu, 2 Jun 2022 07:24:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231266AbiFBLYi (ORCPT ); Thu, 2 Jun 2022 07:24:38 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B777E23356B for ; Thu, 2 Jun 2022 04:24:37 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id s68so4495141pgs.10 for ; Thu, 02 Jun 2022 04:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=/UviAPw6MVTun+p1meC75VFrnzsHlfU+tXdnWRM4ero=; b=R0jGR2UNz89lSMNrXmYn+tG9AJzhiCUoStselCRkCR/NOXJfrPJjYaEv+1hjEK7ayj xxi8yhx18W7TUO++IRoOKPH1kv3Wphzv27c/4bnjB/NsPBe/t8Zy3AJZ1zs2YNXeJ/B6 iyjVtD/QRJxEpHh2ksIpZYkGt4QOJUT8Ux1j3gNGPTnekRgEXrUCysEl1NNSsKI9Hf/L IRnIfKiEJExZLlfmkgCFTPLvq9uDiLWcETVqHtw/zWRhhMz84BzVY+ZF9khjo856lK9A csc3U0Zf+ZX3Z8594T4AdaeIMyRkoBKN1Ed2H2X4O2UuZsBuMWz9DTwH9At1/lLCXiaA rcNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=/UviAPw6MVTun+p1meC75VFrnzsHlfU+tXdnWRM4ero=; b=bJD4HOaATURyquHnQwJSL12Tgod8rWH/ymfjNZqSSVN6e6fEnsAUDqB5GCyAd/PBHr 7+3x43uTXbipnD7yo2d9HHgwXcs88owiX7Prh5RSRMMbXfqjKxNOIchoN488UTxNsHXW CQ+oqGiDPmF9SMfUG414wWq4kq8avZIlzohmo6w6/2I8HhCs6UGYqrrmxG4Rr0FxuJwm 1eBA/mtr3MYQnJm/WDexkKZDk5r3CBPSl0rFNGDfxLJha2xt/U1Bm+qdWbIpmogYZ9IU u4v3CMbVCB4JK1KUS2OFtykIGpVePv77ydnnOmqwAF2jmfoppkOF28xopcOSVliefwXd 1hxQ== X-Gm-Message-State: AOAM533D5DZ0CjRnBIsfXm3p7uhVVMu8xgPVJC8pfmoLU8dt216m0jO1 PSMred8B2eYJE0xv68cAOX4= X-Google-Smtp-Source: ABdhPJzty2L83Yb6F5pcpnNIYPmmPuhhuOwoP/lHnm+WllkboYqVQ5sSbX0lDdTrvwBAURr+82kwTw== X-Received: by 2002:a63:d209:0:b0:3fb:b455:deb2 with SMTP id a9-20020a63d209000000b003fbb455deb2mr3870838pgg.323.1654169077266; Thu, 02 Jun 2022 04:24:37 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id t4-20020a170902b20400b001617ffc6d25sm3262140plr.19.2022.06.02.04.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 04:24:36 -0700 (PDT) From: Miaoqian Lin To: Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Miaoqian Lin , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] bus: vexpress-config: Fix refcount leak in vexpress_syscfg_probe Date: Thu, 2 Jun 2022 15:24:26 +0400 Message-Id: <20220602112428.3002-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: a5a38765ac79 ("bus: vexpress-config: simplify config bus probing") Signed-off-by: Miaoqian Lin --- drivers/bus/vexpress-config.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c index a58ac0c8e282..b368e2f01f8b 100644 --- a/drivers/bus/vexpress-config.c +++ b/drivers/bus/vexpress-config.c @@ -395,10 +395,13 @@ static int vexpress_syscfg_probe(struct platform_device *pdev) struct device_node *bridge_np; bridge_np = of_parse_phandle(node, "arm,vexpress,config-bridge", 0); - if (bridge_np != pdev->dev.parent->of_node) + if (bridge_np != pdev->dev.parent->of_node) { + of_node_put(bridge_np); continue; + } of_platform_populate(node, NULL, NULL, &pdev->dev); + of_node_put(bridge_np); } return 0; -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 159FEC43334 for ; Thu, 2 Jun 2022 11:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=SU87PI5P08pHK9AX+PG8yULEWCbfOk5n29JlO1+YAH0=; b=Lf8icO4gQGDzHy usHGjGMCmRioOjcEFIF8nefc5XIp9Sm72SQOc+HXGGmyoSa46jQsLFyiqY1uRpMCgUu+VKVQzjHsm Pmnq+VMRn3+AM5A6rhjwVnmzZ9lFKxEaU+QB8mBcjg3r5a+UOXt73K3MfHASaub3LZaw7OAsy6YaU O4LilHBAcsIvgcGa7PbzQ0aJAmZL+NVDhyELK+AOPj1NkkUF0dqB4hLoTSe7vdG5JXx7nJ1FT1fr2 2dqZ5LwyID1i9LZAlcF5SXMR9MBanBomwEU2uBvC56YhyW89dtRWK9PjkpffjoY7CQgLDCDjqD7Sy VH9RaxGRMJdQ2rdMW3+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwiwU-002voT-JX; Thu, 02 Jun 2022 11:24:42 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwiwS-002vnh-3E for linux-arm-kernel@lists.infradead.org; Thu, 02 Jun 2022 11:24:41 +0000 Received: by mail-pf1-x42f.google.com with SMTP id w21so4550897pfc.0 for ; Thu, 02 Jun 2022 04:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=/UviAPw6MVTun+p1meC75VFrnzsHlfU+tXdnWRM4ero=; b=R0jGR2UNz89lSMNrXmYn+tG9AJzhiCUoStselCRkCR/NOXJfrPJjYaEv+1hjEK7ayj xxi8yhx18W7TUO++IRoOKPH1kv3Wphzv27c/4bnjB/NsPBe/t8Zy3AJZ1zs2YNXeJ/B6 iyjVtD/QRJxEpHh2ksIpZYkGt4QOJUT8Ux1j3gNGPTnekRgEXrUCysEl1NNSsKI9Hf/L IRnIfKiEJExZLlfmkgCFTPLvq9uDiLWcETVqHtw/zWRhhMz84BzVY+ZF9khjo856lK9A csc3U0Zf+ZX3Z8594T4AdaeIMyRkoBKN1Ed2H2X4O2UuZsBuMWz9DTwH9At1/lLCXiaA rcNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=/UviAPw6MVTun+p1meC75VFrnzsHlfU+tXdnWRM4ero=; b=2O8SJgyNC6rz0StCSWtwT4Z61/CphaeUKF4ADYVoIGyGlZ1dGXR1dBO1XzuPihq75K iPA3g88lW7WOf4I1fkRFRyBnKHWhRZF8BUWCIElLaOHqEioU179aVm3V4cnEe7pKJCso Q2yEf54mow0z20A+xxwJ/89GETnjRLE6y9mzxc/X0JoTX5c/hl1kD1+XHfWEnZja9sWm yu3HInL9utwK1mXiwT0JC87RQLDm28xwtvXWuYwu7AXOdNgMHAh3InG+bRkCd85d+TSQ YG7EQoNf9X10Hz3oI6ydAR5NM4Fh5+lTiOzcREOHZeA1PEeIoteDapu4luDfkfaQY2nX okUg== X-Gm-Message-State: AOAM5339NnMI7eFaFtnaOpThQ1USMIXLkrfuii3kiVAZ9XB4sFyaGeSE 6J5sVJeRZm/6yJGP61fhll4= X-Google-Smtp-Source: ABdhPJzty2L83Yb6F5pcpnNIYPmmPuhhuOwoP/lHnm+WllkboYqVQ5sSbX0lDdTrvwBAURr+82kwTw== X-Received: by 2002:a63:d209:0:b0:3fb:b455:deb2 with SMTP id a9-20020a63d209000000b003fbb455deb2mr3870838pgg.323.1654169077266; Thu, 02 Jun 2022 04:24:37 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id t4-20020a170902b20400b001617ffc6d25sm3262140plr.19.2022.06.02.04.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 04:24:36 -0700 (PDT) From: Miaoqian Lin To: Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Miaoqian Lin , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] bus: vexpress-config: Fix refcount leak in vexpress_syscfg_probe Date: Thu, 2 Jun 2022 15:24:26 +0400 Message-Id: <20220602112428.3002-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_042440_169904_39D4AC98 X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: a5a38765ac79 ("bus: vexpress-config: simplify config bus probing") Signed-off-by: Miaoqian Lin --- drivers/bus/vexpress-config.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c index a58ac0c8e282..b368e2f01f8b 100644 --- a/drivers/bus/vexpress-config.c +++ b/drivers/bus/vexpress-config.c @@ -395,10 +395,13 @@ static int vexpress_syscfg_probe(struct platform_device *pdev) struct device_node *bridge_np; bridge_np = of_parse_phandle(node, "arm,vexpress,config-bridge", 0); - if (bridge_np != pdev->dev.parent->of_node) + if (bridge_np != pdev->dev.parent->of_node) { + of_node_put(bridge_np); continue; + } of_platform_populate(node, NULL, NULL, &pdev->dev); + of_node_put(bridge_np); } return 0; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel