All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Baruch Siach via buildroot <buildroot@buildroot.org>
Cc: Oscar Gomez Fuente <oscargomezf@gmail.com>,
	James Hilliard <james.hilliard1@gmail.com>
Subject: Re: [Buildroot] How to select python-cryptograhy package
Date: Thu, 2 Jun 2022 19:00:01 +0200	[thread overview]
Message-ID: <20220602190001.0c4c9f35@windsurf> (raw)
In-Reply-To: <871qwiozwd.fsf@tarshish>

Hello,

On Wed, 25 May 2022 10:01:06 +0300
Baruch Siach via buildroot <buildroot@buildroot.org> wrote:

> The '*' in the table indicates no_std, that is, bare metal. That's most
> likely not what we want for Buildroot. Can we map BR2_ARM_CPU_ARMV8A to
> armv7 line the following:
> 
> diff --git a/package/rustc/Config.in.host b/package/rustc/Config.in.host
> index a86d95236d90..6aac703b2a4f 100644
> --- a/package/rustc/Config.in.host
> +++ b/package/rustc/Config.in.host
> @@ -42,6 +42,8 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_TIER2_HOST_TOOLS_PLATFORMS
>  	default y if BR2_ARM_CPU_ARMV6 && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC
>  	# armv7-unknown-linux-gnueabihf
>  	default y if BR2_ARM_CPU_ARMV7A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC
> +	# armv8-unknown-linux-gnueabihf

I think this comment would be misleading. Indeed, based on this
comment, you could think that for this configuration (BR2_arm &&
BR2_ARM_CPU_ARMV8A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC) we
would use the armv8-unknown-linux-gnueabihf variant of rustc, but
that's not the one we would be using.

> +	default y if BR2_arm && BR2_ARM_CPU_ARMV8A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_GLIBC
>  	# mips-unknown-linux-gnu
>  	default y if BR2_mips && BR2_TOOLCHAIN_USES_GLIBC && !BR2_MIPS_CPU_MIPS32R6
>  	# mips64-unknown-linux-gnuabi64
> @@ -86,6 +88,8 @@ config BR2_PACKAGE_HOST_RUSTC_TARGET_TIER2_PLATFORMS
>  	default y if BR2_ARM_CPU_ARMV7A && BR2_ARM_EABI && BR2_TOOLCHAIN_USES_MUSL
>  	# armv7-unknown-linux-musleabihf
>  	default y if BR2_ARM_CPU_ARMV7A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_MUSL
> +	# armv8-unknown-linux-musleabihf
> +	default y if BR2_arm && BR2_ARM_CPU_ARMV8A && BR2_ARM_EABIHF && BR2_TOOLCHAIN_USES_MUSL

Same comment of course here.

Other than that, it looks good to me.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-06-02 17:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 15:25 [Buildroot] How to select python-cryptograhy package Oscar Gomez Fuente
2022-05-21 20:22 ` Baruch Siach via buildroot
2022-05-22 18:45   ` Oscar Gomez Fuente
2022-05-23  3:38     ` Baruch Siach via buildroot
2022-05-23 10:22       ` Oscar Gomez Fuente
2022-05-23 15:38         ` Baruch Siach via buildroot
2022-05-23 16:07           ` Oscar Gomez Fuente
2022-05-24 19:14             ` Baruch Siach via buildroot
2022-05-25  5:31               ` Oscar Gomez Fuente
2022-05-25  6:05                 ` Baruch Siach via buildroot
2022-05-25  6:28                   ` James Hilliard
2022-05-25  7:01                     ` Baruch Siach via buildroot
2022-05-25  7:36                       ` James Hilliard
2022-06-02 17:00                       ` Thomas Petazzoni via buildroot [this message]
2022-06-03 13:47                         ` Baruch Siach via buildroot
2022-06-03 14:03                           ` Thomas Petazzoni via buildroot
2022-05-24 20:24             ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220602190001.0c4c9f35@windsurf \
    --to=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=oscargomezf@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.