Re: [PATCH v7] eal: add bus cleanup to eal cleanup

From: Stephen Hemminger <stephen@networkplumber.org>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, "Morten Brørup" <mb@smartsharesystems.com>,
	"Bruce Richardson" <bruce.richardson@intel.com>
Subject: Re: [PATCH v7] eal: add bus cleanup to eal cleanup
Date: Fri, 3 Jun 2022 08:11:54 -0700	[thread overview]
Message-ID: <20220603081154.12568fa1@hermes.local> (raw)
In-Reply-To: <20220603143601.230519-1-kevin.laatz@intel.com>

On Fri,  3 Jun 2022 15:36:01 +0100
Kevin Laatz <kevin.laatz@intel.com> wrote:

> +/* Clean up all devices of all buses */
> +int
> +eal_bus_cleanup(void)
> +{
> +	int ret = 0;
> +	struct rte_bus *bus;
> +
> +	TAILQ_FOREACH(bus, &rte_bus_list, next) {
> +		if (bus->cleanup == NULL)
> +			continue;
> +		if (bus->cleanup() != 0)
> +			ret = -1;
> +	}
> +
> +	return ret;
> +}
> +

This is an internal  function, and all users of it
look like they don't use the return value.

Why not make the function void eal_bus_cleanup()
and simplify back up the call chain?