From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Support Opensource <support.opensource@diasemi.com>
Cc: alsa-devel@alsa-project.org, kernel@pengutronix.de
Subject: [PATCH 2/4] ASoC: da7219: Drop no-op remove function
Date: Fri, 3 Jun 2022 16:05:11 +0200 [thread overview]
Message-ID: <20220603140513.131142-3-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20220603140513.131142-1-u.kleine-koenig@pengutronix.de>
A remove callback that just returns 0 is equivalent to no callback at all
as can be seen in i2c_device_remove(). So simplify accordingly.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Previous submission:
https://lore.kernel.org/alsa-devel/20220526204145.1725323-1-u.kleine-koenig@pengutronix.de
sound/soc/codecs/da7219.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index 7fdef38ed8cd..c18f76f370fc 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
@@ -2693,11 +2693,6 @@ static int da7219_i2c_probe(struct i2c_client *i2c)
return ret;
}
-static int da7219_i2c_remove(struct i2c_client *client)
-{
- return 0;
-}
-
static const struct i2c_device_id da7219_i2c_id[] = {
{ "da7219", },
{ }
@@ -2711,7 +2706,6 @@ static struct i2c_driver da7219_i2c_driver = {
.acpi_match_table = ACPI_PTR(da7219_acpi_match),
},
.probe_new = da7219_i2c_probe,
- .remove = da7219_i2c_remove,
.id_table = da7219_i2c_id,
};
--
2.36.1
next prev parent reply other threads:[~2022-06-03 14:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 14:05 [PATCH 0/4] ASoC: Drop some i2c noop remove callbacks Uwe Kleine-König
2022-06-03 14:05 ` [PATCH 1/4] ASoC: ak4642: Drop no-op remove function Uwe Kleine-König
2022-06-03 14:05 ` Uwe Kleine-König [this message]
2022-06-03 14:05 ` [PATCH 3/4] ASoC: lm49453: " Uwe Kleine-König
2022-06-03 14:05 ` [PATCH 4/4] ASoC: da732x: " Uwe Kleine-König
2022-06-07 10:55 ` [PATCH 0/4] ASoC: Drop some i2c noop remove callbacks Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220603140513.131142-3-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.