All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
	kernel@pengutronix.de
Subject: Re: [PATCH] io:health:afe4404: Remove duplicated error reporting in .remove()
Date: Fri, 3 Jun 2022 16:19:14 +0100	[thread overview]
Message-ID: <20220603161914.2191e4f1@jic23-huawei> (raw)
In-Reply-To: <20220603161638.604ab6b7@jic23-huawei>

On Fri, 3 Jun 2022 16:16:38 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> On Sun, 22 May 2022 21:58:42 +0200
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> 
> > Hello Jonathan,
> > 
> > On Sat, May 14, 2022 at 02:38:12PM +0100, Jonathan Cameron wrote:  
> > > On Sat, 14 May 2022 15:04:32 +0200
> > > Uwe Kleine-König         <u.kleine-koenig@pengutronix.de> wrote:
> > >     
> > > > Returning an error value in an i2c remove callback results in an error
> > > > message being emitted by the i2c core, but otherwise it doesn't make a
> > > > difference.
> > > > 
> > > > As afe4404_remove() already emits an error message on failure and the
> > > > additional error message by the i2c core doesn't add any useful
> > > > information, change the return value to zero to suppress this message.
> > > > 
> > > > This patch is a preparation for making i2c remove callbacks return void.
> > > > 
> > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>    
> > > Applied.
> > > 
> > > Like the others this will sit in testing until I can rebase the togreg
> > > branch.    
> > 
> > Don't know if it's to late to fix already, but I just noticed we'd want
> > s/io/iio/ in the Subject line.  
> Good spot. Fixed up as haven't pushed the tree out as non rebasing yet
> (I'm waiting as I normally rebase on rc1).
> 

Might get delayed a little longer than that as I've just seen Greg has
sent a late pull request for char-misc (unrelated to the IIO changes),
so might need to wait a little past rc1.

Jonathan

> Jonathan
> 
> > 
> > Best regards
> > Uwe
> >   
> 


      reply	other threads:[~2022-06-03 15:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-14 13:04 [PATCH] io:health:afe4404: Remove duplicated error reporting in .remove() Uwe Kleine-König
2022-05-14 13:38 ` Jonathan Cameron
2022-05-22 19:58   ` Uwe Kleine-König
2022-06-03 15:16     ` Jonathan Cameron
2022-06-03 15:19       ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220603161914.2191e4f1@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.