All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Luca Ceresoli <luca@lucaceresoli.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qpid-proton: needs C++ and threads
Date: Sat, 4 Jun 2022 16:49:31 +0200	[thread overview]
Message-ID: <20220604144931.GL427639@scaer> (raw)
In-Reply-To: <20220521204348.1023965-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2022-05-21 22:43 +0200, Fabrice Fontaine spake thusly:
> qpid-proton needs C++ (and so threads due to proactor) to avoid the
> following build failure:
> 
> CMake Error at /nvmedata/autobuild/instance-3/output-1/host/share/cmake-3.18/Modules/CMakeTestCXXCompiler.cmake:59 (message):
>   The C++ compiler
> 
>     "/usr/bin/c++"
> 
>   is not able to compile a simple test program.
> 
> C++ check can't easily be removed:
> https://github.com/apache/qpid-proton/pull/366
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/76f8deccc9c4eee29eddf42586cc28e96eec0827
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/qpid-proton/Config.in      |  7 +++++--
>  package/qpid-proton/qpid-proton.mk | 15 +--------------
>  2 files changed, 6 insertions(+), 16 deletions(-)
> 
> diff --git a/package/qpid-proton/Config.in b/package/qpid-proton/Config.in
> index b49a2afa7e..adddc6eca0 100644
> --- a/package/qpid-proton/Config.in
> +++ b/package/qpid-proton/Config.in
> @@ -1,6 +1,8 @@
>  config BR2_PACKAGE_QPID_PROTON
>  	bool "qpid-proton"
> +	depends on BR2_INSTALL_LIBSTDCPP
>  	depends on !BR2_STATIC_LIBS # build a shared library
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	select BR2_PACKAGE_UTIL_LINUX
>  	select BR2_PACKAGE_UTIL_LINUX_LIBUUID
>  	help
> @@ -13,5 +15,6 @@ config BR2_PACKAGE_QPID_PROTON
>  
>  	  https://qpid.apache.org/proton/
>  
> -comment "qpid-proton needs a toolchain w/ dynamic library"
> -	depends on BR2_STATIC_LIBS
> +comment "qpid-proton needs a toolchain w/ C++, dynamic library, threads"
> +	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || \
> +		!BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/qpid-proton/qpid-proton.mk b/package/qpid-proton/qpid-proton.mk
> index 103cf9fd31..fae6ecc413 100644
> --- a/package/qpid-proton/qpid-proton.mk
> +++ b/package/qpid-proton/qpid-proton.mk
> @@ -23,6 +23,7 @@ QPID_PROTON_DEPENDENCIES = \
>  # go language binding is enabled when host-go is present
>  # For now, disable all of them.
>  QPID_PROTON_CONF_OPTS = \
> +	-DBUILD_CPP=ON \
>  	-DBUILD_GO=OFF \
>  	-DBUILD_PYTHON=OFF \
>  	-DBUILD_RUBY=OFF \
> @@ -31,20 +32,6 @@ QPID_PROTON_CONF_OPTS = \
>  	-DENABLE_WARNING_ERROR=OFF \
>  	-DPYTHON_EXECUTABLE=$(HOST_DIR)/bin/python3
>  
> -# epoll proactor unconditionally uses pthread and cpp (C++) bindings
> -# unconditionally use proactor
> -ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> -ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
> -QPID_PROTON_CONF_OPTS += -DBUILD_CPP=ON
> -else
> -QPID_PROTON_CONF_OPTS += -DBUILD_CPP=OFF
> -endif
> -else
> -QPID_PROTON_CONF_OPTS += \
> -	-DBUILD_CPP=OFF \
> -	-DPROACTOR=none
> -endif
> -
>  ifeq ($(BR2_PACKAGE_JSONCPP),y)
>  QPID_PROTON_DEPENDENCIES += jsoncpp
>  QPID_PROTON_CONF_OPTS += -DENABLE_JSONCPP=ON
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2022-06-04 14:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21 20:43 [Buildroot] [PATCH 1/1] package/qpid-proton: needs C++ and threads Fabrice Fontaine
2022-05-23 13:19 ` Luca Ceresoli
2022-06-04 14:52   ` Yann E. MORIN
2022-06-04 14:49 ` Yann E. MORIN [this message]
2022-06-07 15:44 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220604144931.GL427639@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=luca@lucaceresoli.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.