From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qpid-proton: needs C++ and threads
Date: Sat, 4 Jun 2022 16:52:21 +0200 [thread overview]
Message-ID: <20220604145221.GM427639@scaer> (raw)
In-Reply-To: <e828792d-8371-7fe1-bdd1-b7f729fa7097@lucaceresoli.net>
Luca, All,
On 2022-05-23 15:19 +0200, Luca Ceresoli spake thusly:
> On 21/05/22 22:43, Fabrice Fontaine wrote:
> > qpid-proton needs C++ (and so threads due to proactor) to avoid the
> > following build failure:
[--SNIP--]
> If upstream does not provide _working_ support for building without C++,
> then I would not spend much time in trying to do so.
Yes, upstream jsut dismissed the issue by requiring C++:
https://github.com/apache/qpid-proton/pull/366#issuecomment-1146334165
This change won't work - you actually do need a C++ compiler to run
the tests so the CMake build configuration is correct. So yes you
actually do need to make a build dependency on c++.
I don't think they are correct in that statement, (i.e. testing for the
presence of a C++ compiler should not require a C++ compiler...), but
that's their call to not want to deal with the issue, so I applied
Fabrice's patch.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-06-04 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 20:43 [Buildroot] [PATCH 1/1] package/qpid-proton: needs C++ and threads Fabrice Fontaine
2022-05-23 13:19 ` Luca Ceresoli
2022-06-04 14:52 ` Yann E. MORIN [this message]
2022-06-04 14:49 ` Yann E. MORIN
2022-06-07 15:44 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220604145221.GM427639@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=luca@lucaceresoli.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.