Re: [PATCH] mac80211 : Add support to track mesh peer beacon miss event

[kernel test robot <lkp@intel.com>]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.18]
[cannot apply to wireless-next/main wireless/main next-20220603]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/quic_haric-quicinc-com/mac80211-Add-support-to-track-mesh-peer-beacon-miss-event/20220530-145016
base:    4b0986a3613c92f4ec1bdc7f60ec66fea135991f
config: h8300-randconfig-s031-20220603 (https://download.01.org/0day-ci/archive/20220604/202206041752.4zr7FmwF-lkp@intel.com/config)
compiler: h8300-linux-gcc (GCC) 11.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-18-g56afb504-dirty
        # https://github.com/intel-lab-lkp/linux/commit/e7cd136811bad4e11720ee71054c97d225848dd4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review quic_haric-quicinc-com/mac80211-Add-support-to-track-mesh-peer-beacon-miss-event/20220530-145016
        git checkout e7cd136811bad4e11720ee71054c97d225848dd4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=h8300 SHELL=/bin/bash net/mac80211/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> net/mac80211/mesh_plink.c:626:31: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] beacon_int @@     got restricted __le16 [usertype] beacon_int @@
   net/mac80211/mesh_plink.c:626:31: sparse:     expected unsigned int [usertype] beacon_int
   net/mac80211/mesh_plink.c:626:31: sparse:     got restricted __le16 [usertype] beacon_int

vim +626 net/mac80211/mesh_plink.c

   595	
   596	/*
   597	 * mesh_bmiss_update - update beacon miss parameters such as
   598	 * beacon count, beacon interval and timeout of beacon miss
   599	 * timer
   600	 *
   601	 * @sdata: local meshif
   602	 * @mgmt: mgmt frame info
   603	 * @elems: IEs from beacon or mesh peering frame.
   604	 * @rx_status: rx status for the frame for signal reporting
   605	 *
   606	 */
   607	
   608	void mesh_bmiss_update(struct ieee80211_sub_if_data *sdata,
   609			       struct ieee80211_mgmt *mgmt,
   610			       struct ieee802_11_elems *elems,
   611			       struct ieee80211_rx_status *rx_status)
   612	{
   613		struct sta_info *sta;
   614		u32 timeout;
   615	
   616		/* mesh_sta_info_get api returns with rcu_read_lock */
   617		sta = mesh_sta_info_get(sdata, mgmt->sa, elems, rx_status);
   618		if (!sta)
   619			goto unlock_rcu;
   620	
   621		if (!(sta->local->hw.dbg_mask & IEEE80211_HW_DBG_BMISS_LOG) ||
   622		    !sta->sdata->vif.bmiss_threshold)
   623			goto unlock_rcu;
   624	
   625		sta->mesh->bmiss_count = 0;
 > 626		sta->mesh->beacon_int = mgmt->u.beacon.beacon_int;
   627		timeout = sta->mesh->beacon_int * sta->sdata->vif.bmiss_threshold;
   628	
   629		mod_timer(&sta->mesh->bmiss_timer, (jiffies + msecs_to_jiffies(timeout)));
   630	
   631	unlock_rcu:
   632		rcu_read_unlock();
   633	}
   634	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp