All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, vsementsov@yandex-team.ru,
	eblake@redhat.com, jsnow@redhat.com,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: [PATCH v2 10/11] tests/vm/basevm.py: use cmd() instead of qmp()
Date: Mon,  6 Jun 2022 10:27:30 +0300	[thread overview]
Message-ID: <20220606072731.878226-11-vsementsov@yandex-team.ru> (raw)
In-Reply-To: <20220606072731.878226-1-vsementsov@yandex-team.ru>

We don't expect failure here and need 'result' object. cmd() is better
in this case.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
 tests/vm/basevm.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 254e11c932..dfb6307aaf 100644
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -305,8 +305,8 @@ def boot(self, img, extra_args=[]):
         self._guest = guest
         # Init console so we can start consuming the chars.
         self.console_init()
-        usernet_info = guest.qmp("human-monitor-command",
-                                 command_line="info usernet").get("return")
+        usernet_info = guest.cmd("human-monitor-command",
+                                 command_line="info usernet")
         self.ssh_port = get_info_usernet_hostfwd_port(usernet_info)
         if not self.ssh_port:
             raise Exception("Cannot find ssh port from 'info usernet':\n%s" % \
-- 
2.25.1



  parent reply	other threads:[~2022-06-06  7:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06  7:27 [PATCH v2 00/11] iotests: use vm.cmd() Vladimir Sementsov-Ogievskiy
2022-06-06  7:27 ` [PATCH v2 01/11] python: rename QEMUMonitorProtocol.cmd() to cmd_raw() Vladimir Sementsov-Ogievskiy
2022-06-06  7:27 ` [PATCH v2 02/11] python/qemu: rename command() to cmd() Vladimir Sementsov-Ogievskiy
2022-06-06  7:27 ` [PATCH v2 03/11] python/machine.py: upgrade vm.cmd() method Vladimir Sementsov-Ogievskiy
2022-06-06  7:27 ` [PATCH v2 04/11] iotests: QemuStorageDaemon: add cmd() method like in QEMUMachine Vladimir Sementsov-Ogievskiy
2022-06-06  7:27 ` [PATCH v2 05/11] iotests: add some missed checks of qmp result Vladimir Sementsov-Ogievskiy
2022-06-06  7:27 ` [PATCH v2 06/11] iotests: refactor some common qmp result checks into generic pattern Vladimir Sementsov-Ogievskiy
2022-06-06  7:27 ` [PATCH v2 07/11] iotests: drop some occasional semicolons Vladimir Sementsov-Ogievskiy
2022-06-06  7:27 ` [PATCH v2 08/11] iotests: drop some extra ** in qmp() call Vladimir Sementsov-Ogievskiy
2022-06-06  7:27 ` [PATCH v2 09/11] iotests.py: pause_job(): drop return value Vladimir Sementsov-Ogievskiy
2022-06-06  7:27 ` Vladimir Sementsov-Ogievskiy [this message]
2022-06-06  7:27 ` [PATCH v2 11/11] python: use vm.cmd() instead of vm.qmp() where appropriate Vladimir Sementsov-Ogievskiy
2022-09-19 17:16 ` [PATCH v2 00/11] iotests: use vm.cmd() Vladimir Sementsov-Ogievskiy
2022-10-12 13:25   ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220606072731.878226-11-vsementsov@yandex-team.ru \
    --to=vsementsov@yandex-team.ru \
    --cc=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=eblake@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.