From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C937EC433EF for ; Mon, 6 Jun 2022 13:18:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238432AbiFFNS4 (ORCPT ); Mon, 6 Jun 2022 09:18:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238428AbiFFNSz (ORCPT ); Mon, 6 Jun 2022 09:18:55 -0400 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B5F215242D for ; Mon, 6 Jun 2022 06:18:50 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 43D8924000A; Mon, 6 Jun 2022 13:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654521528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQMnz3kE25tuaHePTw9IIcU1s7DFhes1/13W4tlWP0g=; b=Q5TqKuS6rm5fKUbW/to2iIks63dYveytMItZN2hQSGiABR1yQZaWIH2Wv3feBM+l71PDhZ 7hym5Z3FW0h+npJn81HTjHLseNMoNrZ0oZ/kspCkbk5Ka7N0ZwnLqP4EYcgXTtQ3/L9X4N zdw6nHv4EtsheM4g0P3UtTdddQD0ITB2W3HM+r4MZNQ/1tuLq5GIG8pvs8TMps7AAAWvDq KWEheiUzVKJwXJ40gpKBdibyxlFHBpB7P1POSyqkmc9F4g26Gm1ZcN7V/ikAnPNjpsZEC8 r6WqDp2Hd1vqY4u3kJfrLvtgLCgxjfK9U+wbX7n6tDiG5WHcgk0IWvmrDbijNA== Date: Mon, 6 Jun 2022 15:18:41 +0200 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Vignesh Raghavendra , Richard Weinberger , Tudor Ambarus , Pratyush Yadav , Joel Stanley , Michael Ellerman , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Stefan Agner , Lucas Stach , Thierry Reding , Jonathan Hunter , Liang Yang , Neil Armstrong , Kevin Hilman , kernel@pengutronix.de, linux-mtd@lists.infradead.org, Michael Walle , Andrew Jeffery , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-tegra@vger.kernel.org, Jerome Brunet , Martin Blumenstingl , linux-amlogic@lists.infradead.org Subject: Re: [PATCH 00/14] mtd: Fix platform remove callbacks to always return 0 Message-ID: <20220606151841.682a5939@xps-13> In-Reply-To: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> References: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Hi Folks, u.kleine-koenig@pengutronix.de wrote on Fri, 3 Jun 2022 23:07:44 +0200: > Hello, >=20 > this series prepares to make platform remove callbacks return void. > Therefor first update them to always return 0. The rationale is that the > Linux device model doesn't handle failures on remove and if a remove > callback returns an error, it just emits a quite generic error message > and still removes the device. Tudor, Pratyush, Richard, Vignesh, The series looks good to me (besides the atmel patch), I think it's best to take it directly through mtd/next instead of going through all the different internal branches, please let me know if you disagree with the idea. Cheers, Miqu=C3=A8l >=20 > Best regards > Uwe >=20 > Uwe Kleine-K=C3=B6nig (14): > mtd: hyperbus: Make hyperbus_unregister_device() return void > mtd: spi-nor: aspeed-smc: Make aspeed_smc_unregister() return void > mtd: powernv_flash: Warn about failure to unregister mtd device > mtd: st-spi_fsm: Warn about failure to unregister mtd device > mtd: lpddr2_nvm: Warn about failure to unregister mtd device > mtd: spear_smi: Don't skip cleanup after mtd_device_unregister() > failed > mtd: spear_smi: Drop if with an always false condition > mtd: rawnand: atmel: Warn about failure to unregister mtd device > mtd: rawnand: omap2: Suppress error message after WARN in .remove() > mtd: rawnand: tegra: Don't skip cleanup after mtd_device_unregister() > failed > mtd: rawnand: meson: Don't skip cleanup after mtd_device_unregister() > failed > mtd: rawnand: meson: Drop cleaning platform data in .remove() > mtd: physmap: Don't skip cleanup after mtd_device_unregister() failed > mtd: physmap: Drop if with an always false condition >=20 > drivers/mtd/devices/powernv_flash.c | 4 +++- > drivers/mtd/devices/spear_smi.c | 10 ++-------- > drivers/mtd/devices/st_spi_fsm.c | 4 +++- > drivers/mtd/hyperbus/hbmc-am654.c | 6 +++--- > drivers/mtd/hyperbus/hyperbus-core.c | 8 ++------ > drivers/mtd/hyperbus/rpc-if.c | 5 +++-- > drivers/mtd/lpddr/lpddr2_nvm.c | 4 +++- > drivers/mtd/maps/physmap-core.c | 13 +++---------- > drivers/mtd/nand/raw/atmel/nand-controller.c | 5 ++++- > drivers/mtd/nand/raw/meson_nand.c | 16 +++------------- > drivers/mtd/nand/raw/omap2.c | 6 ++---- > drivers/mtd/nand/raw/tegra_nand.c | 5 +---- > drivers/mtd/spi-nor/controllers/aspeed-smc.c | 8 ++++---- > include/linux/mtd/hyperbus.h | 4 +--- > 14 files changed, 37 insertions(+), 61 deletions(-) >=20 > base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F2DFC43334 for ; Mon, 6 Jun 2022 13:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DmpJ9iBP1nyMHAmDEXasNWEcN9rb1EdFF7Ecl/ldFsY=; b=Ayhd7zpKpL99tF tA+BMpKKh1l0wpbK6tHTrSTP5Mt2ynvVqVPhdS5gyuXIahp41jj1sd/9HfW/CaIM38q+b3AQwWgtS uheqASuKS8Q/MWpwtAibRQFa/VMMYYiJDzqcfHE/NerkStBruxHppkeqykX1emV1bUt/VPI4Z5Nw6 KeKvXxqRvqI7EEmdGtCTTPa9XVIjhDFW+QkMK+TxijQ+Csoc1OZycgi2Qd7FqMikzja1IjultNDVt sORsT+kdehd05GP+smkJFCQwAX8MsRoqRv7DyfH9f1GSYB6/JpGDLzYmFlw3K7BJaYroiyWhIES5u eDevpDzVDCqBhSqkT9rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyCdO-001KWB-8x; Mon, 06 Jun 2022 13:19:06 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyCdC-001KRT-6U; Mon, 06 Jun 2022 13:18:56 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 43D8924000A; Mon, 6 Jun 2022 13:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654521528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQMnz3kE25tuaHePTw9IIcU1s7DFhes1/13W4tlWP0g=; b=Q5TqKuS6rm5fKUbW/to2iIks63dYveytMItZN2hQSGiABR1yQZaWIH2Wv3feBM+l71PDhZ 7hym5Z3FW0h+npJn81HTjHLseNMoNrZ0oZ/kspCkbk5Ka7N0ZwnLqP4EYcgXTtQ3/L9X4N zdw6nHv4EtsheM4g0P3UtTdddQD0ITB2W3HM+r4MZNQ/1tuLq5GIG8pvs8TMps7AAAWvDq KWEheiUzVKJwXJ40gpKBdibyxlFHBpB7P1POSyqkmc9F4g26Gm1ZcN7V/ikAnPNjpsZEC8 r6WqDp2Hd1vqY4u3kJfrLvtgLCgxjfK9U+wbX7n6tDiG5WHcgk0IWvmrDbijNA== Date: Mon, 6 Jun 2022 15:18:41 +0200 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Vignesh Raghavendra , Richard Weinberger , Tudor Ambarus , Pratyush Yadav , Joel Stanley , Michael Ellerman , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Stefan Agner , Lucas Stach , Thierry Reding , Jonathan Hunter , Liang Yang , Neil Armstrong , Kevin Hilman , kernel@pengutronix.de, linux-mtd@lists.infradead.org, Michael Walle , Andrew Jeffery , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-tegra@vger.kernel.org, Jerome Brunet , Martin Blumenstingl , linux-amlogic@lists.infradead.org Subject: Re: [PATCH 00/14] mtd: Fix platform remove callbacks to always return 0 Message-ID: <20220606151841.682a5939@xps-13> In-Reply-To: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> References: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_061854_543202_18AA869A X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgRm9sa3MsCgp1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGUgd3JvdGUgb24gRnJpLCAg MyBKdW4gMjAyMiAyMzowNzo0NCArMDIwMDoKCj4gSGVsbG8sCj4gCj4gdGhpcyBzZXJpZXMgcHJl cGFyZXMgdG8gbWFrZSBwbGF0Zm9ybSByZW1vdmUgY2FsbGJhY2tzIHJldHVybiB2b2lkLgo+IFRo ZXJlZm9yIGZpcnN0IHVwZGF0ZSB0aGVtIHRvIGFsd2F5cyByZXR1cm4gMC4gVGhlIHJhdGlvbmFs ZSBpcyB0aGF0IHRoZQo+IExpbnV4IGRldmljZSBtb2RlbCBkb2Vzbid0IGhhbmRsZSBmYWlsdXJl cyBvbiByZW1vdmUgYW5kIGlmIGEgcmVtb3ZlCj4gY2FsbGJhY2sgcmV0dXJucyBhbiBlcnJvciwg aXQganVzdCBlbWl0cyBhIHF1aXRlIGdlbmVyaWMgZXJyb3IgbWVzc2FnZQo+IGFuZCBzdGlsbCBy ZW1vdmVzIHRoZSBkZXZpY2UuCgpUdWRvciwgUHJhdHl1c2gsIFJpY2hhcmQsIFZpZ25lc2gsCgpU aGUgc2VyaWVzIGxvb2tzIGdvb2QgdG8gbWUgKGJlc2lkZXMgdGhlIGF0bWVsIHBhdGNoKSwgSSB0 aGluayBpdCdzCmJlc3QgdG8gdGFrZSBpdCBkaXJlY3RseSB0aHJvdWdoIG10ZC9uZXh0IGluc3Rl YWQgb2YgZ29pbmcgdGhyb3VnaCBhbGwKdGhlIGRpZmZlcmVudCBpbnRlcm5hbCBicmFuY2hlcywg cGxlYXNlIGxldCBtZSBrbm93IGlmIHlvdSBkaXNhZ3JlZQp3aXRoIHRoZSBpZGVhLgoKQ2hlZXJz LApNaXF1w6hsCgo+IAo+IEJlc3QgcmVnYXJkcwo+IFV3ZQo+IAo+IFV3ZSBLbGVpbmUtS8O2bmln ICgxNCk6Cj4gICBtdGQ6IGh5cGVyYnVzOiBNYWtlIGh5cGVyYnVzX3VucmVnaXN0ZXJfZGV2aWNl KCkgcmV0dXJuIHZvaWQKPiAgIG10ZDogc3BpLW5vcjogYXNwZWVkLXNtYzogTWFrZSBhc3BlZWRf c21jX3VucmVnaXN0ZXIoKSByZXR1cm4gdm9pZAo+ICAgbXRkOiBwb3dlcm52X2ZsYXNoOiBXYXJu IGFib3V0IGZhaWx1cmUgdG8gdW5yZWdpc3RlciBtdGQgZGV2aWNlCj4gICBtdGQ6IHN0LXNwaV9m c206IFdhcm4gYWJvdXQgZmFpbHVyZSB0byB1bnJlZ2lzdGVyIG10ZCBkZXZpY2UKPiAgIG10ZDog bHBkZHIyX252bTogV2FybiBhYm91dCBmYWlsdXJlIHRvIHVucmVnaXN0ZXIgbXRkIGRldmljZQo+ ICAgbXRkOiBzcGVhcl9zbWk6IERvbid0IHNraXAgY2xlYW51cCBhZnRlciBtdGRfZGV2aWNlX3Vu cmVnaXN0ZXIoKQo+ICAgICBmYWlsZWQKPiAgIG10ZDogc3BlYXJfc21pOiBEcm9wIGlmIHdpdGgg YW4gYWx3YXlzIGZhbHNlIGNvbmRpdGlvbgo+ICAgbXRkOiByYXduYW5kOiBhdG1lbDogV2FybiBh Ym91dCBmYWlsdXJlIHRvIHVucmVnaXN0ZXIgbXRkIGRldmljZQo+ICAgbXRkOiByYXduYW5kOiBv bWFwMjogU3VwcHJlc3MgZXJyb3IgbWVzc2FnZSBhZnRlciBXQVJOIGluIC5yZW1vdmUoKQo+ICAg bXRkOiByYXduYW5kOiB0ZWdyYTogRG9uJ3Qgc2tpcCBjbGVhbnVwIGFmdGVyIG10ZF9kZXZpY2Vf dW5yZWdpc3RlcigpCj4gICAgIGZhaWxlZAo+ICAgbXRkOiByYXduYW5kOiBtZXNvbjogRG9uJ3Qg c2tpcCBjbGVhbnVwIGFmdGVyIG10ZF9kZXZpY2VfdW5yZWdpc3RlcigpCj4gICAgIGZhaWxlZAo+ ICAgbXRkOiByYXduYW5kOiBtZXNvbjogRHJvcCBjbGVhbmluZyBwbGF0Zm9ybSBkYXRhIGluIC5y ZW1vdmUoKQo+ICAgbXRkOiBwaHlzbWFwOiBEb24ndCBza2lwIGNsZWFudXAgYWZ0ZXIgbXRkX2Rl dmljZV91bnJlZ2lzdGVyKCkgZmFpbGVkCj4gICBtdGQ6IHBoeXNtYXA6IERyb3AgaWYgd2l0aCBh biBhbHdheXMgZmFsc2UgY29uZGl0aW9uCj4gCj4gIGRyaXZlcnMvbXRkL2RldmljZXMvcG93ZXJu dl9mbGFzaC5jICAgICAgICAgIHwgIDQgKysrLQo+ICBkcml2ZXJzL210ZC9kZXZpY2VzL3NwZWFy X3NtaS5jICAgICAgICAgICAgICB8IDEwICsrLS0tLS0tLS0KPiAgZHJpdmVycy9tdGQvZGV2aWNl cy9zdF9zcGlfZnNtLmMgICAgICAgICAgICAgfCAgNCArKystCj4gIGRyaXZlcnMvbXRkL2h5cGVy YnVzL2hibWMtYW02NTQuYyAgICAgICAgICAgIHwgIDYgKysrLS0tCj4gIGRyaXZlcnMvbXRkL2h5 cGVyYnVzL2h5cGVyYnVzLWNvcmUuYyAgICAgICAgIHwgIDggKystLS0tLS0KPiAgZHJpdmVycy9t dGQvaHlwZXJidXMvcnBjLWlmLmMgICAgICAgICAgICAgICAgfCAgNSArKystLQo+ICBkcml2ZXJz L210ZC9scGRkci9scGRkcjJfbnZtLmMgICAgICAgICAgICAgICB8ICA0ICsrKy0KPiAgZHJpdmVy cy9tdGQvbWFwcy9waHlzbWFwLWNvcmUuYyAgICAgICAgICAgICAgfCAxMyArKystLS0tLS0tLS0t Cj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2F0bWVsL25hbmQtY29udHJvbGxlci5jIHwgIDUgKysr Ky0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jICAgICAgICAgICAgfCAxNiAr KystLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L29tYXAyLmMgICAgICAgICAg ICAgICAgIHwgIDYgKystLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3RlZ3JhX25hbmQuYyAg ICAgICAgICAgIHwgIDUgKy0tLS0KPiAgZHJpdmVycy9tdGQvc3BpLW5vci9jb250cm9sbGVycy9h c3BlZWQtc21jLmMgfCAgOCArKysrLS0tLQo+ICBpbmNsdWRlL2xpbnV4L210ZC9oeXBlcmJ1cy5o ICAgICAgICAgICAgICAgICB8ICA0ICstLS0KPiAgMTQgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0 aW9ucygrKSwgNjEgZGVsZXRpb25zKC0pCj4gCj4gYmFzZS1jb21taXQ6IDRiMDk4NmEzNjEzYzky ZjRlYzFiZGM3ZjYwZWM2NmZlYTEzNTk5MWYKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBs aXN0Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRk Lwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A5B4C433EF for ; Mon, 6 Jun 2022 13:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PWh4sPw1Sz6j83J8m82anNcbGKQKuYuzxTRZKIxUuIE=; b=nK0+fIzvyGZpwP dIJV1iK7rB+f4nomjzpgW/2XFrYtXqFV0WcaTea/d3kviov3+bDfx/vAZvPkncBQdEMM06V1T7Gbd iEhTMZlhju6tPKGViySx4EDTnlkS9LtveivfLp9sH58neKQXsVSkvZ4xo+v/QMOlc5wm/nzIxmMG9 Ox1q9zu7d8cXZ8mgaTgONXkQWk4kasvcYV8LqSIZttSd3mtiiIY7DeDF2t92KOyC0Mn9d/rqyW0sn 47GPD2VHiwkultIW9sR1eb/mGPVMWb8H1h8/XPcvxJ05AkxJwMFEf53xICiOpyUMuVoEjmC/MJTPX sxFuUJjJBgMrRnoWSKtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyCdF-001KTZ-4N; Mon, 06 Jun 2022 13:18:57 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyCdC-001KRT-6U; Mon, 06 Jun 2022 13:18:56 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 43D8924000A; Mon, 6 Jun 2022 13:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654521528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQMnz3kE25tuaHePTw9IIcU1s7DFhes1/13W4tlWP0g=; b=Q5TqKuS6rm5fKUbW/to2iIks63dYveytMItZN2hQSGiABR1yQZaWIH2Wv3feBM+l71PDhZ 7hym5Z3FW0h+npJn81HTjHLseNMoNrZ0oZ/kspCkbk5Ka7N0ZwnLqP4EYcgXTtQ3/L9X4N zdw6nHv4EtsheM4g0P3UtTdddQD0ITB2W3HM+r4MZNQ/1tuLq5GIG8pvs8TMps7AAAWvDq KWEheiUzVKJwXJ40gpKBdibyxlFHBpB7P1POSyqkmc9F4g26Gm1ZcN7V/ikAnPNjpsZEC8 r6WqDp2Hd1vqY4u3kJfrLvtgLCgxjfK9U+wbX7n6tDiG5WHcgk0IWvmrDbijNA== Date: Mon, 6 Jun 2022 15:18:41 +0200 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Vignesh Raghavendra , Richard Weinberger , Tudor Ambarus , Pratyush Yadav , Joel Stanley , Michael Ellerman , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Stefan Agner , Lucas Stach , Thierry Reding , Jonathan Hunter , Liang Yang , Neil Armstrong , Kevin Hilman , kernel@pengutronix.de, linux-mtd@lists.infradead.org, Michael Walle , Andrew Jeffery , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, linux-tegra@vger.kernel.org, Jerome Brunet , Martin Blumenstingl , linux-amlogic@lists.infradead.org Subject: Re: [PATCH 00/14] mtd: Fix platform remove callbacks to always return 0 Message-ID: <20220606151841.682a5939@xps-13> In-Reply-To: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> References: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_061854_543202_18AA869A X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgRm9sa3MsCgp1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGUgd3JvdGUgb24gRnJpLCAg MyBKdW4gMjAyMiAyMzowNzo0NCArMDIwMDoKCj4gSGVsbG8sCj4gCj4gdGhpcyBzZXJpZXMgcHJl cGFyZXMgdG8gbWFrZSBwbGF0Zm9ybSByZW1vdmUgY2FsbGJhY2tzIHJldHVybiB2b2lkLgo+IFRo ZXJlZm9yIGZpcnN0IHVwZGF0ZSB0aGVtIHRvIGFsd2F5cyByZXR1cm4gMC4gVGhlIHJhdGlvbmFs ZSBpcyB0aGF0IHRoZQo+IExpbnV4IGRldmljZSBtb2RlbCBkb2Vzbid0IGhhbmRsZSBmYWlsdXJl cyBvbiByZW1vdmUgYW5kIGlmIGEgcmVtb3ZlCj4gY2FsbGJhY2sgcmV0dXJucyBhbiBlcnJvciwg aXQganVzdCBlbWl0cyBhIHF1aXRlIGdlbmVyaWMgZXJyb3IgbWVzc2FnZQo+IGFuZCBzdGlsbCBy ZW1vdmVzIHRoZSBkZXZpY2UuCgpUdWRvciwgUHJhdHl1c2gsIFJpY2hhcmQsIFZpZ25lc2gsCgpU aGUgc2VyaWVzIGxvb2tzIGdvb2QgdG8gbWUgKGJlc2lkZXMgdGhlIGF0bWVsIHBhdGNoKSwgSSB0 aGluayBpdCdzCmJlc3QgdG8gdGFrZSBpdCBkaXJlY3RseSB0aHJvdWdoIG10ZC9uZXh0IGluc3Rl YWQgb2YgZ29pbmcgdGhyb3VnaCBhbGwKdGhlIGRpZmZlcmVudCBpbnRlcm5hbCBicmFuY2hlcywg cGxlYXNlIGxldCBtZSBrbm93IGlmIHlvdSBkaXNhZ3JlZQp3aXRoIHRoZSBpZGVhLgoKQ2hlZXJz LApNaXF1w6hsCgo+IAo+IEJlc3QgcmVnYXJkcwo+IFV3ZQo+IAo+IFV3ZSBLbGVpbmUtS8O2bmln ICgxNCk6Cj4gICBtdGQ6IGh5cGVyYnVzOiBNYWtlIGh5cGVyYnVzX3VucmVnaXN0ZXJfZGV2aWNl KCkgcmV0dXJuIHZvaWQKPiAgIG10ZDogc3BpLW5vcjogYXNwZWVkLXNtYzogTWFrZSBhc3BlZWRf c21jX3VucmVnaXN0ZXIoKSByZXR1cm4gdm9pZAo+ICAgbXRkOiBwb3dlcm52X2ZsYXNoOiBXYXJu IGFib3V0IGZhaWx1cmUgdG8gdW5yZWdpc3RlciBtdGQgZGV2aWNlCj4gICBtdGQ6IHN0LXNwaV9m c206IFdhcm4gYWJvdXQgZmFpbHVyZSB0byB1bnJlZ2lzdGVyIG10ZCBkZXZpY2UKPiAgIG10ZDog bHBkZHIyX252bTogV2FybiBhYm91dCBmYWlsdXJlIHRvIHVucmVnaXN0ZXIgbXRkIGRldmljZQo+ ICAgbXRkOiBzcGVhcl9zbWk6IERvbid0IHNraXAgY2xlYW51cCBhZnRlciBtdGRfZGV2aWNlX3Vu cmVnaXN0ZXIoKQo+ICAgICBmYWlsZWQKPiAgIG10ZDogc3BlYXJfc21pOiBEcm9wIGlmIHdpdGgg YW4gYWx3YXlzIGZhbHNlIGNvbmRpdGlvbgo+ICAgbXRkOiByYXduYW5kOiBhdG1lbDogV2FybiBh Ym91dCBmYWlsdXJlIHRvIHVucmVnaXN0ZXIgbXRkIGRldmljZQo+ICAgbXRkOiByYXduYW5kOiBv bWFwMjogU3VwcHJlc3MgZXJyb3IgbWVzc2FnZSBhZnRlciBXQVJOIGluIC5yZW1vdmUoKQo+ICAg bXRkOiByYXduYW5kOiB0ZWdyYTogRG9uJ3Qgc2tpcCBjbGVhbnVwIGFmdGVyIG10ZF9kZXZpY2Vf dW5yZWdpc3RlcigpCj4gICAgIGZhaWxlZAo+ICAgbXRkOiByYXduYW5kOiBtZXNvbjogRG9uJ3Qg c2tpcCBjbGVhbnVwIGFmdGVyIG10ZF9kZXZpY2VfdW5yZWdpc3RlcigpCj4gICAgIGZhaWxlZAo+ ICAgbXRkOiByYXduYW5kOiBtZXNvbjogRHJvcCBjbGVhbmluZyBwbGF0Zm9ybSBkYXRhIGluIC5y ZW1vdmUoKQo+ICAgbXRkOiBwaHlzbWFwOiBEb24ndCBza2lwIGNsZWFudXAgYWZ0ZXIgbXRkX2Rl dmljZV91bnJlZ2lzdGVyKCkgZmFpbGVkCj4gICBtdGQ6IHBoeXNtYXA6IERyb3AgaWYgd2l0aCBh biBhbHdheXMgZmFsc2UgY29uZGl0aW9uCj4gCj4gIGRyaXZlcnMvbXRkL2RldmljZXMvcG93ZXJu dl9mbGFzaC5jICAgICAgICAgIHwgIDQgKysrLQo+ICBkcml2ZXJzL210ZC9kZXZpY2VzL3NwZWFy X3NtaS5jICAgICAgICAgICAgICB8IDEwICsrLS0tLS0tLS0KPiAgZHJpdmVycy9tdGQvZGV2aWNl cy9zdF9zcGlfZnNtLmMgICAgICAgICAgICAgfCAgNCArKystCj4gIGRyaXZlcnMvbXRkL2h5cGVy YnVzL2hibWMtYW02NTQuYyAgICAgICAgICAgIHwgIDYgKysrLS0tCj4gIGRyaXZlcnMvbXRkL2h5 cGVyYnVzL2h5cGVyYnVzLWNvcmUuYyAgICAgICAgIHwgIDggKystLS0tLS0KPiAgZHJpdmVycy9t dGQvaHlwZXJidXMvcnBjLWlmLmMgICAgICAgICAgICAgICAgfCAgNSArKystLQo+ICBkcml2ZXJz L210ZC9scGRkci9scGRkcjJfbnZtLmMgICAgICAgICAgICAgICB8ICA0ICsrKy0KPiAgZHJpdmVy cy9tdGQvbWFwcy9waHlzbWFwLWNvcmUuYyAgICAgICAgICAgICAgfCAxMyArKystLS0tLS0tLS0t Cj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2F0bWVsL25hbmQtY29udHJvbGxlci5jIHwgIDUgKysr Ky0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jICAgICAgICAgICAgfCAxNiAr KystLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L29tYXAyLmMgICAgICAgICAg ICAgICAgIHwgIDYgKystLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3RlZ3JhX25hbmQuYyAg ICAgICAgICAgIHwgIDUgKy0tLS0KPiAgZHJpdmVycy9tdGQvc3BpLW5vci9jb250cm9sbGVycy9h c3BlZWQtc21jLmMgfCAgOCArKysrLS0tLQo+ICBpbmNsdWRlL2xpbnV4L210ZC9oeXBlcmJ1cy5o ICAgICAgICAgICAgICAgICB8ICA0ICstLS0KPiAgMTQgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0 aW9ucygrKSwgNjEgZGVsZXRpb25zKC0pCj4gCj4gYmFzZS1jb21taXQ6IDRiMDk4NmEzNjEzYzky ZjRlYzFiZGM3ZjYwZWM2NmZlYTEzNTk5MWYKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxv Z2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC8C5C43334 for ; Mon, 6 Jun 2022 13:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N2f41N9sdeshGKsAQzZ+i8OCVbASp8zVvUB6Efg6X3w=; b=3NOxcVSyVzW80Z 6Cvu7np//vGmOToCQj9nK4rHQTGRKU6/e8GiLV55qIiMw6lnZ+5NMsHIRDPDTCWOJnfVjvEtxHWHP fTggjDggep7dmd8NNS/3eSk/xm7QkYA7aXSDuXNEeA9hOB4MhmTuheuqutFUhgNCIFSpRvCGHtzzw lYTt4D6V3HcZdAlEs057TVrdlvcGphoeWNdSE75lM4g0yr8RqBOhLRGk9v/RllgA1923GcLKOx0TH mRX11tfRzm6SHi0ROKrZ5j2YwCvTd3a9I+IK/AsP0LvFS6V9l7wJnNOe28IacPxzFerP+1z3cBnvG gltwp82PSyj1ckO34j8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyCdG-001KTk-6K; Mon, 06 Jun 2022 13:18:58 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyCdC-001KRT-6U; Mon, 06 Jun 2022 13:18:56 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 43D8924000A; Mon, 6 Jun 2022 13:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654521528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQMnz3kE25tuaHePTw9IIcU1s7DFhes1/13W4tlWP0g=; b=Q5TqKuS6rm5fKUbW/to2iIks63dYveytMItZN2hQSGiABR1yQZaWIH2Wv3feBM+l71PDhZ 7hym5Z3FW0h+npJn81HTjHLseNMoNrZ0oZ/kspCkbk5Ka7N0ZwnLqP4EYcgXTtQ3/L9X4N zdw6nHv4EtsheM4g0P3UtTdddQD0ITB2W3HM+r4MZNQ/1tuLq5GIG8pvs8TMps7AAAWvDq KWEheiUzVKJwXJ40gpKBdibyxlFHBpB7P1POSyqkmc9F4g26Gm1ZcN7V/ikAnPNjpsZEC8 r6WqDp2Hd1vqY4u3kJfrLvtgLCgxjfK9U+wbX7n6tDiG5WHcgk0IWvmrDbijNA== Date: Mon, 6 Jun 2022 15:18:41 +0200 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH 00/14] mtd: Fix platform remove callbacks to always return 0 Message-ID: <20220606151841.682a5939@xps-13> In-Reply-To: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> References: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220606_061854_543202_18AA869A X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Lucas Stach , Vignesh Raghavendra , linux-aspeed@lists.ozlabs.org, Neil Armstrong , Benjamin Herrenschmidt , Stefan Agner , Thierry Reding , linux-mtd@lists.infradead.org, Jerome Brunet , Michael Ellerman , Jonathan Hunter , Joel Stanley , Kevin Hilman , Tudor Ambarus , Martin Blumenstingl , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Andrew Jeffery , Pratyush Yadav , Michael Walle , Liang Yang , kernel@pengutronix.de, Richard Weinberger , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Claudiu Beznea Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRm9sa3MsCgp1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGUgd3JvdGUgb24gRnJpLCAg MyBKdW4gMjAyMiAyMzowNzo0NCArMDIwMDoKCj4gSGVsbG8sCj4gCj4gdGhpcyBzZXJpZXMgcHJl cGFyZXMgdG8gbWFrZSBwbGF0Zm9ybSByZW1vdmUgY2FsbGJhY2tzIHJldHVybiB2b2lkLgo+IFRo ZXJlZm9yIGZpcnN0IHVwZGF0ZSB0aGVtIHRvIGFsd2F5cyByZXR1cm4gMC4gVGhlIHJhdGlvbmFs ZSBpcyB0aGF0IHRoZQo+IExpbnV4IGRldmljZSBtb2RlbCBkb2Vzbid0IGhhbmRsZSBmYWlsdXJl cyBvbiByZW1vdmUgYW5kIGlmIGEgcmVtb3ZlCj4gY2FsbGJhY2sgcmV0dXJucyBhbiBlcnJvciwg aXQganVzdCBlbWl0cyBhIHF1aXRlIGdlbmVyaWMgZXJyb3IgbWVzc2FnZQo+IGFuZCBzdGlsbCBy ZW1vdmVzIHRoZSBkZXZpY2UuCgpUdWRvciwgUHJhdHl1c2gsIFJpY2hhcmQsIFZpZ25lc2gsCgpU aGUgc2VyaWVzIGxvb2tzIGdvb2QgdG8gbWUgKGJlc2lkZXMgdGhlIGF0bWVsIHBhdGNoKSwgSSB0 aGluayBpdCdzCmJlc3QgdG8gdGFrZSBpdCBkaXJlY3RseSB0aHJvdWdoIG10ZC9uZXh0IGluc3Rl YWQgb2YgZ29pbmcgdGhyb3VnaCBhbGwKdGhlIGRpZmZlcmVudCBpbnRlcm5hbCBicmFuY2hlcywg cGxlYXNlIGxldCBtZSBrbm93IGlmIHlvdSBkaXNhZ3JlZQp3aXRoIHRoZSBpZGVhLgoKQ2hlZXJz LApNaXF1w6hsCgo+IAo+IEJlc3QgcmVnYXJkcwo+IFV3ZQo+IAo+IFV3ZSBLbGVpbmUtS8O2bmln ICgxNCk6Cj4gICBtdGQ6IGh5cGVyYnVzOiBNYWtlIGh5cGVyYnVzX3VucmVnaXN0ZXJfZGV2aWNl KCkgcmV0dXJuIHZvaWQKPiAgIG10ZDogc3BpLW5vcjogYXNwZWVkLXNtYzogTWFrZSBhc3BlZWRf c21jX3VucmVnaXN0ZXIoKSByZXR1cm4gdm9pZAo+ICAgbXRkOiBwb3dlcm52X2ZsYXNoOiBXYXJu IGFib3V0IGZhaWx1cmUgdG8gdW5yZWdpc3RlciBtdGQgZGV2aWNlCj4gICBtdGQ6IHN0LXNwaV9m c206IFdhcm4gYWJvdXQgZmFpbHVyZSB0byB1bnJlZ2lzdGVyIG10ZCBkZXZpY2UKPiAgIG10ZDog bHBkZHIyX252bTogV2FybiBhYm91dCBmYWlsdXJlIHRvIHVucmVnaXN0ZXIgbXRkIGRldmljZQo+ ICAgbXRkOiBzcGVhcl9zbWk6IERvbid0IHNraXAgY2xlYW51cCBhZnRlciBtdGRfZGV2aWNlX3Vu cmVnaXN0ZXIoKQo+ICAgICBmYWlsZWQKPiAgIG10ZDogc3BlYXJfc21pOiBEcm9wIGlmIHdpdGgg YW4gYWx3YXlzIGZhbHNlIGNvbmRpdGlvbgo+ICAgbXRkOiByYXduYW5kOiBhdG1lbDogV2FybiBh Ym91dCBmYWlsdXJlIHRvIHVucmVnaXN0ZXIgbXRkIGRldmljZQo+ICAgbXRkOiByYXduYW5kOiBv bWFwMjogU3VwcHJlc3MgZXJyb3IgbWVzc2FnZSBhZnRlciBXQVJOIGluIC5yZW1vdmUoKQo+ICAg bXRkOiByYXduYW5kOiB0ZWdyYTogRG9uJ3Qgc2tpcCBjbGVhbnVwIGFmdGVyIG10ZF9kZXZpY2Vf dW5yZWdpc3RlcigpCj4gICAgIGZhaWxlZAo+ICAgbXRkOiByYXduYW5kOiBtZXNvbjogRG9uJ3Qg c2tpcCBjbGVhbnVwIGFmdGVyIG10ZF9kZXZpY2VfdW5yZWdpc3RlcigpCj4gICAgIGZhaWxlZAo+ ICAgbXRkOiByYXduYW5kOiBtZXNvbjogRHJvcCBjbGVhbmluZyBwbGF0Zm9ybSBkYXRhIGluIC5y ZW1vdmUoKQo+ICAgbXRkOiBwaHlzbWFwOiBEb24ndCBza2lwIGNsZWFudXAgYWZ0ZXIgbXRkX2Rl dmljZV91bnJlZ2lzdGVyKCkgZmFpbGVkCj4gICBtdGQ6IHBoeXNtYXA6IERyb3AgaWYgd2l0aCBh biBhbHdheXMgZmFsc2UgY29uZGl0aW9uCj4gCj4gIGRyaXZlcnMvbXRkL2RldmljZXMvcG93ZXJu dl9mbGFzaC5jICAgICAgICAgIHwgIDQgKysrLQo+ICBkcml2ZXJzL210ZC9kZXZpY2VzL3NwZWFy X3NtaS5jICAgICAgICAgICAgICB8IDEwICsrLS0tLS0tLS0KPiAgZHJpdmVycy9tdGQvZGV2aWNl cy9zdF9zcGlfZnNtLmMgICAgICAgICAgICAgfCAgNCArKystCj4gIGRyaXZlcnMvbXRkL2h5cGVy YnVzL2hibWMtYW02NTQuYyAgICAgICAgICAgIHwgIDYgKysrLS0tCj4gIGRyaXZlcnMvbXRkL2h5 cGVyYnVzL2h5cGVyYnVzLWNvcmUuYyAgICAgICAgIHwgIDggKystLS0tLS0KPiAgZHJpdmVycy9t dGQvaHlwZXJidXMvcnBjLWlmLmMgICAgICAgICAgICAgICAgfCAgNSArKystLQo+ICBkcml2ZXJz L210ZC9scGRkci9scGRkcjJfbnZtLmMgICAgICAgICAgICAgICB8ICA0ICsrKy0KPiAgZHJpdmVy cy9tdGQvbWFwcy9waHlzbWFwLWNvcmUuYyAgICAgICAgICAgICAgfCAxMyArKystLS0tLS0tLS0t Cj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2F0bWVsL25hbmQtY29udHJvbGxlci5jIHwgIDUgKysr Ky0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jICAgICAgICAgICAgfCAxNiAr KystLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L29tYXAyLmMgICAgICAgICAg ICAgICAgIHwgIDYgKystLS0tCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3RlZ3JhX25hbmQuYyAg ICAgICAgICAgIHwgIDUgKy0tLS0KPiAgZHJpdmVycy9tdGQvc3BpLW5vci9jb250cm9sbGVycy9h c3BlZWQtc21jLmMgfCAgOCArKysrLS0tLQo+ICBpbmNsdWRlL2xpbnV4L210ZC9oeXBlcmJ1cy5o ICAgICAgICAgICAgICAgICB8ICA0ICstLS0KPiAgMTQgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0 aW9ucygrKSwgNjEgZGVsZXRpb25zKC0pCj4gCj4gYmFzZS1jb21taXQ6IDRiMDk4NmEzNjEzYzky ZjRlYzFiZGM3ZjYwZWM2NmZlYTEzNTk5MWYKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E360C43334 for ; Mon, 6 Jun 2022 13:22:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LGvLR3vbtz3bms for ; Mon, 6 Jun 2022 23:22:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Q5TqKuS6; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=217.70.178.240; helo=mslow1.mail.gandi.net; envelope-from=miquel.raynal@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=Q5TqKuS6; dkim-atps=neutral X-Greylist: delayed 207 seconds by postgrey-1.36 at boromir; Mon, 06 Jun 2022 23:22:23 AEST Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LGvKq4yH3z3bc9 for ; Mon, 6 Jun 2022 23:22:22 +1000 (AEST) Received: from relay10.mail.gandi.net (unknown [217.70.178.230]) by mslow1.mail.gandi.net (Postfix) with ESMTP id C14FDCEF43 for ; Mon, 6 Jun 2022 13:19:06 +0000 (UTC) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 43D8924000A; Mon, 6 Jun 2022 13:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654521528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nQMnz3kE25tuaHePTw9IIcU1s7DFhes1/13W4tlWP0g=; b=Q5TqKuS6rm5fKUbW/to2iIks63dYveytMItZN2hQSGiABR1yQZaWIH2Wv3feBM+l71PDhZ 7hym5Z3FW0h+npJn81HTjHLseNMoNrZ0oZ/kspCkbk5Ka7N0ZwnLqP4EYcgXTtQ3/L9X4N zdw6nHv4EtsheM4g0P3UtTdddQD0ITB2W3HM+r4MZNQ/1tuLq5GIG8pvs8TMps7AAAWvDq KWEheiUzVKJwXJ40gpKBdibyxlFHBpB7P1POSyqkmc9F4g26Gm1ZcN7V/ikAnPNjpsZEC8 r6WqDp2Hd1vqY4u3kJfrLvtgLCgxjfK9U+wbX7n6tDiG5WHcgk0IWvmrDbijNA== Date: Mon, 6 Jun 2022 15:18:41 +0200 From: Miquel Raynal To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Subject: Re: [PATCH 00/14] mtd: Fix platform remove callbacks to always return 0 Message-ID: <20220606151841.682a5939@xps-13> In-Reply-To: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> References: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Lucas Stach , Vignesh Raghavendra , linux-aspeed@lists.ozlabs.org, Neil Armstrong , Stefan Agner , Thierry Reding , linux-mtd@lists.infradead.org, Jerome Brunet , Jonathan Hunter , Joel Stanley , Kevin Hilman , Tudor Ambarus , Martin Blumenstingl , linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Andrew Jeffery , Nicolas Ferre , Pratyush Yadav , Michael Walle , Liang Yang , kernel@pengutronix.de, Richard Weinberger , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Claudiu Beznea Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Folks, u.kleine-koenig@pengutronix.de wrote on Fri, 3 Jun 2022 23:07:44 +0200: > Hello, >=20 > this series prepares to make platform remove callbacks return void. > Therefor first update them to always return 0. The rationale is that the > Linux device model doesn't handle failures on remove and if a remove > callback returns an error, it just emits a quite generic error message > and still removes the device. Tudor, Pratyush, Richard, Vignesh, The series looks good to me (besides the atmel patch), I think it's best to take it directly through mtd/next instead of going through all the different internal branches, please let me know if you disagree with the idea. Cheers, Miqu=C3=A8l >=20 > Best regards > Uwe >=20 > Uwe Kleine-K=C3=B6nig (14): > mtd: hyperbus: Make hyperbus_unregister_device() return void > mtd: spi-nor: aspeed-smc: Make aspeed_smc_unregister() return void > mtd: powernv_flash: Warn about failure to unregister mtd device > mtd: st-spi_fsm: Warn about failure to unregister mtd device > mtd: lpddr2_nvm: Warn about failure to unregister mtd device > mtd: spear_smi: Don't skip cleanup after mtd_device_unregister() > failed > mtd: spear_smi: Drop if with an always false condition > mtd: rawnand: atmel: Warn about failure to unregister mtd device > mtd: rawnand: omap2: Suppress error message after WARN in .remove() > mtd: rawnand: tegra: Don't skip cleanup after mtd_device_unregister() > failed > mtd: rawnand: meson: Don't skip cleanup after mtd_device_unregister() > failed > mtd: rawnand: meson: Drop cleaning platform data in .remove() > mtd: physmap: Don't skip cleanup after mtd_device_unregister() failed > mtd: physmap: Drop if with an always false condition >=20 > drivers/mtd/devices/powernv_flash.c | 4 +++- > drivers/mtd/devices/spear_smi.c | 10 ++-------- > drivers/mtd/devices/st_spi_fsm.c | 4 +++- > drivers/mtd/hyperbus/hbmc-am654.c | 6 +++--- > drivers/mtd/hyperbus/hyperbus-core.c | 8 ++------ > drivers/mtd/hyperbus/rpc-if.c | 5 +++-- > drivers/mtd/lpddr/lpddr2_nvm.c | 4 +++- > drivers/mtd/maps/physmap-core.c | 13 +++---------- > drivers/mtd/nand/raw/atmel/nand-controller.c | 5 ++++- > drivers/mtd/nand/raw/meson_nand.c | 16 +++------------- > drivers/mtd/nand/raw/omap2.c | 6 ++---- > drivers/mtd/nand/raw/tegra_nand.c | 5 +---- > drivers/mtd/spi-nor/controllers/aspeed-smc.c | 8 ++++---- > include/linux/mtd/hyperbus.h | 4 +--- > 14 files changed, 37 insertions(+), 61 deletions(-) >=20 > base-commit: 4b0986a3613c92f4ec1bdc7f60ec66fea135991f